From patchwork Tue Jul 8 00:39:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YoungJun Cho X-Patchwork-Id: 4500191 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 263CABEECB for ; Tue, 8 Jul 2014 00:40:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1F0322034F for ; Tue, 8 Jul 2014 00:39:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3E12120351 for ; Tue, 8 Jul 2014 00:39:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C34C76E4B7; Mon, 7 Jul 2014 17:39:54 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 65D406E4C2 for ; Mon, 7 Jul 2014 17:39:53 -0700 (PDT) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N8D00EC0B6ES930@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 08 Jul 2014 09:39:51 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.45]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id D5.5D.19452.6DD3BB35; Tue, 08 Jul 2014 09:39:50 +0900 (KST) X-AuditID: cbfee68e-b7fb96d000004bfc-ce-53bb3dd6b7d8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 6B.42.04943.6DD3BB35; Tue, 08 Jul 2014 09:39:50 +0900 (KST) Received: from localhost.localdomain ([10.252.75.90]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N8D004E2B6BRL90@mmp2.samsung.com>; Tue, 08 Jul 2014 09:39:50 +0900 (KST) From: YoungJun Cho To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH v5 01/14] drm/exynos: dsi: move the EoT packets configuration point Date: Tue, 08 Jul 2014 09:39:34 +0900 Message-id: <1404779987-5337-2-git-send-email-yj44.cho@samsung.com> X-Mailer: git-send-email 1.9.0 In-reply-to: <1404779987-5337-1-git-send-email-yj44.cho@samsung.com> References: <1404779987-5337-1-git-send-email-yj44.cho@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t8zXd1rtruDDQ7vM7e4te4cq0XvuZNM FvOPAFlXvr5ns+h/s5DV4tyrlYwWk+5PYLF4ce8ii0XvgqtsFmeb3rBbzDi/j8li6fWLTBYT pq9lsWjdewQoNvklm8XPXfNYHAQ81sxbw+hxua+XyWPnrLvsHiuXf2Hz2LSqk81j+7cHrB73 u48zefRtWcXo8XmTXABnFJdNSmpOZllqkb5dAlfGtocrmQt+8lasXMfbwHiYu4uRk0NCwERi 5uI3rBC2mMSFe+vZuhi5OIQEljFKrLo4lw2m6P2zD6wQiemMEkfWwlS1MklsXXSSCaSKTUBT 4vnHHWCjRARMJTomLWUBKWIWeMIkcWrzfhaQhLBAqMSZlx8ZQWwWAVWJ5lsvmEFsXgFnia+H zjJCrJOTmPJ7ATuIzSngIrH83HGwuBBQTfffdUwQNV/ZJRadZIWYIyDxbfIhoPkcQHFZiU0H mCFKJCUOrrjBMoFReAEjwypG0dSC5ILipPQiI73ixNzi0rx0veT83E2MkEjr28F484D1IcZk oHETmaVEk/OBkZpXEm9obGZkYWpiamxkbmlGmrCSOO+ih0lBQgLpiSWp2ampBalF8UWlOanF hxiZODilGhhz7Davt+l/avTdfl/kEn4XMSl17v0XxFfxPTX+ZnlYqMXm7YcNk7z5VzF/lLhd V7A6x0N4+l0lLlPWnw7n1R8yrjNiDF5TOsmuNfljsUhH8u4bm+O2+pk/1nbjLfn4VT331uI7 /q8Opfnd11jmKPO9JnYni9+XuV3WGgnyOW//BB0+N+v640glluKMREMt5qLiRAClxxTDygIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsVy+t9jQd1rtruDDf6tNba4te4cq0XvuZNM FvOPAFlXvr5ns+h/s5DV4tyrlYwWk+5PYLF4ce8ii0XvgqtsFmeb3rBbzDi/j8li6fWLTBYT pq9lsWjdewQoNvklm8XPXfNYHAQ81sxbw+hxua+XyWPnrLvsHiuXf2Hz2LSqk81j+7cHrB73 u48zefRtWcXo8XmTXABnVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5i bqqtkotPgK5bZg7QI0oKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwjrGjG0P VzIX/OStWLmOt4HxMHcXIyeHhICJxPtnH1ghbDGJC/fWs3UxcnEICUxnlDiyFsZpZZLYuugk E0gVm4CmxPOPO8A6RARMJTomLWUBKWIWeMIkcWrzfhaQhLBAqMSZlx8ZQWwWAVWJ5lsvmEFs XgFnia+HzjJCrJOTmPJ7ATuIzSngIrH83HGwuBBQTfffdUwTGHkXMDKsYhRNLUguKE5KzzXU K07MLS7NS9dLzs/dxAiO5GdSOxhXNlgcYhTgYFTi4V1xcFewEGtiWXFl7iFGCQ5mJRHeFcuB QrwpiZVVqUX58UWlOanFhxhNga6ayCwlmpwPTDJ5JfGGxiZmRpZGZsYm5sbGSuK8B1qtA4UE 0hNLUrNTUwtSi2D6mDg4pRoYL/xdq2XMvLCqzjl2W0vFfe8NB7KFfmpFii8SkI28/ODDxDmZ 0mvuvRZ78PI7H/vOKaxSyjaHtNI5PEJkjqbVsbSHHc7acTovxapy5jrDQ7GGn4o43kXtr9j0 +4LDsj0XGi7Prerd433hdVrZcq1bluEh+syzHydw1E3ZJaBQ0JO1YInWqqo0JZbijERDLeai 4kQAymb0TPoCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, sw0312.kim@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com, robh+dt@kernel.org, galak@codeaurora.org, kgene.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This configuration could be used in MIPI DSI command mode also. And adds user manual description for display configuration. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 6302aa6..dad543a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -468,13 +468,19 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) /* DSI configuration */ reg = 0; + /* The first bit of mode_flags specifies display configuration. + * If this bit is set[= MIPI_DSI_MODE_VIDEO], dsi will support video + * mode, otherwise it will support command mode. + */ if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { reg |= DSIM_VIDEO_MODE; + /* + * The user manual describes that following bits are ignored in + * command mode. + */ if (!(dsi->mode_flags & MIPI_DSI_MODE_VSYNC_FLUSH)) reg |= DSIM_MFLUSH_VS; - if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET)) - reg |= DSIM_EOT_DISABLE; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) reg |= DSIM_SYNC_INFORM; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) @@ -491,6 +497,9 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) reg |= DSIM_HSA_MODE; } + if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET)) + reg |= DSIM_EOT_DISABLE; + switch (dsi->format) { case MIPI_DSI_FMT_RGB888: reg |= DSIM_MAIN_PIX_FORMAT_RGB888;