From patchwork Thu Jul 17 09:01:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YoungJun Cho X-Patchwork-Id: 4573511 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 47DD5C0515 for ; Thu, 17 Jul 2014 09:01:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7D1772018E for ; Thu, 17 Jul 2014 09:01:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id D0099201B9 for ; Thu, 17 Jul 2014 09:01:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 36FF589E46; Thu, 17 Jul 2014 02:01:43 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id BC6A089E36 for ; Thu, 17 Jul 2014 02:01:41 -0700 (PDT) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N8U00E9GMEKVW50@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 17 Jul 2014 18:01:33 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.45]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id EC.76.13369.CE097C35; Thu, 17 Jul 2014 18:01:32 +0900 (KST) X-AuditID: cbfee690-b7fb56d000003439-f1-53c790ec9830 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 06.8D.04943.CE097C35; Thu, 17 Jul 2014 18:01:32 +0900 (KST) Received: from localhost.localdomain ([10.252.75.90]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N8U00LFFMEI4B80@mmp1.samsung.com>; Thu, 17 Jul 2014 18:01:32 +0900 (KST) From: YoungJun Cho To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH v6 01/14] drm/exynos: dsi: move the EoT packets configuration point Date: Thu, 17 Jul 2014 18:01:16 +0900 Message-id: <1405587689-1466-2-git-send-email-yj44.cho@samsung.com> X-Mailer: git-send-email 1.9.0 In-reply-to: <1405587689-1466-1-git-send-email-yj44.cho@samsung.com> References: <1405587689-1466-1-git-send-email-yj44.cho@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zXd03E44HGzw6p2Fxa905VovecyeZ LOYfAbKufH3PZtH/ZiGrxblXKxktJt2fwGLx4t5FFoveBVfZLM42vWG3mHF+H5PF0usXmSwm TF/LYtG69whQbPJLNoufu+axOAh4rJm3htHjcl8vk8fOWXfZPVYu/8LmsWlVJ5vH9m8PWD3u dx9n8ujbsorR4/MmuQDOKC6blNSczLLUIn27BK6M3sV7WAoa+CouPHBsYDzG3cXIySEhYCJx 5+NUVghbTOLCvfVsXYxcHEICyxglDndvZ4QpujR5EjNEYhGjxIG9u6CcViaJ9r4nLCBVbAKa Es8/7gAbJSJgKtExaSkLSBGzwBMmiVOb94MVCQuESmxZeRRoBwcHi4CqxMFrGSAmr4CzxIMP 8hDL5CSm/F7ADhLmFHCRONOQAxIWAqro2b2GCWSihMBPdomfR6+zgyRYBAQkvk0+xAJSLyEg K7HpADPEGEmJgytusExgFF7AyLCKUTS1ILmgOCm9yESvODG3uDQvXS85P3cTIyTKJuxgvHfA +hBjMtC4icxSosn5wCjNK4k3NDYzsjA1MTU2Mrc0I01YSZxX7VFSkJBAemJJanZqakFqUXxR aU5q8SFGJg5OqQZG7mzNZ0cl4o7He+4wU1yetfmhhX6llV6leZNB+MrdpnuNQw3S/bM895y3 rfmf9G7l3iKDhJTZ+V4XH25uf7Why3deJLPoXLNSyZA/yQ2JCx5+Uy9az96SEjfJ5KLo6bMi xTbrjtm8EbIqWV6jK7aRy9T29rzTO49tz7np81mgbLVK8Lm57aeVWIozEg21mIuKEwGw0len yAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsVy+t9jAd03E44HGyxepmJxa905VovecyeZ LOYfAbKufH3PZtH/ZiGrxblXKxktJt2fwGLx4t5FFoveBVfZLM42vWG3mHF+H5PF0usXmSwm TF/LYtG69whQbPJLNoufu+axOAh4rJm3htHjcl8vk8fOWXfZPVYu/8LmsWlVJ5vH9m8PWD3u dx9n8ujbsorR4/MmuQDOqAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE 3FRbJRefAF23zBygR5QUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhHWMGb2L 97AUNPBVXHjg2MB4jLuLkZNDQsBE4tLkScwQtpjEhXvr2boYuTiEBBYxShzYu4sZwmllkmjv e8ICUsUmoCnx/OMOVhBbRMBUomPSUhaQImaBJ0wSpzbvBysSFgiV2LLyKNAoDg4WAVWJg9cy QExeAWeJBx/kIZbJSUz5vYAdJMwp4CJxpiEHJCwEVNGzew3TBEbeBYwMqxhFUwuSC4qT0nMN 9YoTc4tL89L1kvNzNzGCY/iZ1A7GlQ0WhxgFOBiVeHgTWo8FC7EmlhVX5h5ilOBgVhLh3dZ1 PFiINyWxsiq1KD++qDQntfgQoynQSROZpUST84HpJa8k3tDYxMzI0sjM2MTc2FhJnPdAq3Wg kEB6YklqdmpqQWoRTB8TB6dUA+PxZMOIrHcJN3h1567t0EgMubG4bUvA/YTkpKibAe7Rarld U3+tP/jkOF/z/wuv1oa1nv75KP7dsSVB/vXyJxRjk+JulMVMWesZP3OKIqPP4t6pWrO5vudm tixvdcj4sJi9yuxGQq5ZSui/iZNZ+2sKjFSmPJP9K7VU6dtd309Hb6r7TDVL2KfEUpyRaKjF XFScCABgXbSs9wIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, sw0312.kim@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com, robh+dt@kernel.org, galak@codeaurora.org, kgene.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This configuration could be used in MIPI DSI command mode also. And adds user manual description for display configuration. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 2df3592..58bfb2a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -468,13 +468,20 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) /* DSI configuration */ reg = 0; + /* + * The first bit of mode_flags specifies display configuration. + * If this bit is set[= MIPI_DSI_MODE_VIDEO], dsi will support video + * mode, otherwise it will support command mode. + */ if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { reg |= DSIM_VIDEO_MODE; + /* + * The user manual describes that following bits are ignored in + * command mode. + */ if (!(dsi->mode_flags & MIPI_DSI_MODE_VSYNC_FLUSH)) reg |= DSIM_MFLUSH_VS; - if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET)) - reg |= DSIM_EOT_DISABLE; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) reg |= DSIM_SYNC_INFORM; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) @@ -491,6 +498,9 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) reg |= DSIM_HSA_MODE; } + if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET)) + reg |= DSIM_EOT_DISABLE; + switch (dsi->format) { case MIPI_DSI_FMT_RGB888: reg |= DSIM_MAIN_PIX_FORMAT_RGB888;