| Message ID | 1409307166-12396-7-git-send-email-dh.herrmann@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 29, 2014 at 12:12:32PM +0200, David Herrmann wrote: > Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h. > Unfortunately, drivers still heavily access drm_agp_head so we cannot > move it to drm_legacy.h. However, at least it's no longer visible in > drmP.h now (it's directly included from it, though). > > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> > --- > drivers/gpu/drm/drm_agpsupport.c | 1 + > drivers/gpu/drm/drm_legacy.h | 15 +++++++++++++++ > drivers/gpu/drm/drm_memory.c | 1 + > drivers/gpu/drm/drm_vm.c | 1 + > include/drm/drmP.h | 30 +----------------------------- > include/drm/drm_agpsupport.h | 13 +++++++++++++ > 6 files changed, 32 insertions(+), 29 deletions(-) I don't know exactly what you mean by "move harder" in the subject, but other than that this looks good, so with a better subject this is: Reviewed-by: Thierry Reding <treding@nvidia.com>
On Fri, Aug 29, 2014 at 01:43:10PM +0200, Thierry Reding wrote: > On Fri, Aug 29, 2014 at 12:12:32PM +0200, David Herrmann wrote: > > Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h. > > Unfortunately, drivers still heavily access drm_agp_head so we cannot > > move it to drm_legacy.h. However, at least it's no longer visible in > > drmP.h now (it's directly included from it, though). > > > > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> > > --- > > drivers/gpu/drm/drm_agpsupport.c | 1 + > > drivers/gpu/drm/drm_legacy.h | 15 +++++++++++++++ > > drivers/gpu/drm/drm_memory.c | 1 + > > drivers/gpu/drm/drm_vm.c | 1 + > > include/drm/drmP.h | 30 +----------------------------- > > include/drm/drm_agpsupport.h | 13 +++++++++++++ > > 6 files changed, 32 insertions(+), 29 deletions(-) > > I don't know exactly what you mean by "move harder" in the subject, but > other than that this looks good, so with a better subject this is: I guess "Try to hide AGP definitions harder" would be more accurate. -Daniel > > Reviewed-by: Thierry Reding <treding@nvidia.com>
diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c index dde205c..4b2b4aa 100644 --- a/drivers/gpu/drm/drm_agpsupport.c +++ b/drivers/gpu/drm/drm_agpsupport.c @@ -34,6 +34,7 @@ #include <drm/drmP.h> #include <linux/module.h> #include <linux/slab.h> +#include "drm_legacy.h" #if __OS_HAS_AGP diff --git a/drivers/gpu/drm/drm_legacy.h b/drivers/gpu/drm/drm_legacy.h index 912fe81..d94c564 100644 --- a/drivers/gpu/drm/drm_legacy.h +++ b/drivers/gpu/drm/drm_legacy.h @@ -23,6 +23,9 @@ * OTHER DEALINGS IN THE SOFTWARE. */ +#include <linux/list.h> + +struct agp_memory; struct drm_device; struct drm_file; @@ -63,4 +66,16 @@ int drm_legacy_freebufs(struct drm_device *d, void *v, struct drm_file *f); int drm_legacy_mapbufs(struct drm_device *d, void *v, struct drm_file *f); int drm_legacy_dma_ioctl(struct drm_device *d, void *v, struct drm_file *f); +/* + * AGP Support + */ + +struct drm_agp_mem { + unsigned long handle; + struct agp_memory *memory; + unsigned long bound; + int pages; + struct list_head head; +}; + #endif /* __DRM_LEGACY_H__ */ diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index 00c67c0..7888dad 100644 --- a/drivers/gpu/drm/drm_memory.c +++ b/drivers/gpu/drm/drm_memory.c @@ -36,6 +36,7 @@ #include <linux/highmem.h> #include <linux/export.h> #include <drm/drmP.h> +#include "drm_legacy.h" #if __OS_HAS_AGP static void *agp_remap(unsigned long offset, unsigned long size, diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c index 352e339..be25174 100644 --- a/drivers/gpu/drm/drm_vm.c +++ b/drivers/gpu/drm/drm_vm.c @@ -40,6 +40,7 @@ #include <linux/efi.h> #include <linux/slab.h> #endif +#include "drm_legacy.h" struct drm_vma_entry { struct list_head head; diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 0bf66f9..7a3c73c 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -80,6 +80,7 @@ struct module; struct drm_file; struct drm_device; +struct drm_agp_head; struct device_node; struct videomode; @@ -440,35 +441,6 @@ struct drm_device_dma { }; /** - * AGP memory entry. Stored as a doubly linked list. - */ -struct drm_agp_mem { - unsigned long handle; /**< handle */ - struct agp_memory *memory; - unsigned long bound; /**< address */ - int pages; - struct list_head head; -}; - -/** - * AGP data. - * - * \sa drm_agp_init() and drm_device::agp. - */ -struct drm_agp_head { - struct agp_kern_info agp_info; /**< AGP device information */ - struct list_head memory; - unsigned long mode; /**< AGP mode */ - struct agp_bridge_data *bridge; - int enabled; /**< whether the AGP bus as been enabled */ - int acquired; /**< whether the AGP device has been acquired */ - unsigned long base; - int agp_mtrr; - int cant_use_aperture; - unsigned long page_mask; -}; - -/** * Scatter-gather memory. */ struct drm_sg_mem { diff --git a/include/drm/drm_agpsupport.h b/include/drm/drm_agpsupport.h index 86a0218..3bebeb4 100644 --- a/include/drm/drm_agpsupport.h +++ b/include/drm/drm_agpsupport.h @@ -8,6 +8,19 @@ #include <linux/agp_backend.h> #include <drm/drmP.h> +struct drm_agp_head { + struct agp_kern_info agp_info; + struct list_head memory; + unsigned long mode; + struct agp_bridge_data *bridge; + int enabled; + int acquired; + unsigned long base; + int agp_mtrr; + int cant_use_aperture; + unsigned long page_mask; +}; + #if __OS_HAS_AGP void drm_free_agp(struct agp_memory * handle, int pages);
Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h. Unfortunately, drivers still heavily access drm_agp_head so we cannot move it to drm_legacy.h. However, at least it's no longer visible in drmP.h now (it's directly included from it, though). Signed-off-by: David Herrmann <dh.herrmann@gmail.com> --- drivers/gpu/drm/drm_agpsupport.c | 1 + drivers/gpu/drm/drm_legacy.h | 15 +++++++++++++++ drivers/gpu/drm/drm_memory.c | 1 + drivers/gpu/drm/drm_vm.c | 1 + include/drm/drmP.h | 30 +----------------------------- include/drm/drm_agpsupport.h | 13 +++++++++++++ 6 files changed, 32 insertions(+), 29 deletions(-)