From patchwork Tue Sep 2 02:56:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Kurtz X-Patchwork-Id: 4822691 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AB9A5C0338 for ; Tue, 2 Sep 2014 02:57:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E263020160 for ; Tue, 2 Sep 2014 02:56:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id B259E20154 for ; Tue, 2 Sep 2014 02:56:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CF598966B; Mon, 1 Sep 2014 19:56:56 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by gabe.freedesktop.org (Postfix) with ESMTP id A7DEC8966B for ; Mon, 1 Sep 2014 19:56:55 -0700 (PDT) Received: by mail-pd0-f178.google.com with SMTP id y13so7363174pdi.23 for ; Mon, 01 Sep 2014 19:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=h54VN9BUx5HVeSeVtprABQlwI+rp3qwzkJPOYRbXMKY=; b=CPNBfYV3qYvbHGcqvmzb2V39CAsTGWFUQqgaLiNbSTKrxn6+niXkzI6UMd3WbvCm+t oxY0KB/sJeM3ap//VNMLhQp5hhs+XSVMnV0B4UcS86PfQJ3FsRmHO1ZZz810ycXbkVuU oUDqicZXo81P1Djydegxnt0ASxh3+hKYn28Kw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=h54VN9BUx5HVeSeVtprABQlwI+rp3qwzkJPOYRbXMKY=; b=JaPcpW7KJtRRg+vW/xJBDMJaWAFzIexJGebMic+jEno/m0iwZZH217TCLpcSESHKP8 E/TUM2wzWT2/iUfvfcBYmfHt2e2BKhKWOY4bWgSLOO5ZspouF/PAtWkdBCD9ywoP7K2k KdAFuCSAvyG2zCzzHy2iA0BpBMpsjuOlc8f5i7+SUwDWpTrYg20idLsNTGG12yReZHF3 8ncZchG3m4/Up3ISp39jT7LO7FGcjK8OsExygZ39KPisktUN85ZzS+xDcr0Ybp/YCiE5 D7trUnatU/HGL+ECExx54QfkIid7BcYgPccTaWlznRFKKjz/IPZSG/CUWPRKjAPyUNGZ UQuw== X-Gm-Message-State: ALoCoQkOMa1FmhSh0kvnDLQzyJ2XJqRqMLz2Zg04BuMp1NO1YHnBqb3gv8llB0SCOmLBbibtWImK X-Received: by 10.66.147.67 with SMTP id ti3mr43744480pab.2.1409626615411; Mon, 01 Sep 2014 19:56:55 -0700 (PDT) Received: from djkurtzt530-glaptop.corp.google.com (dhcp-172-30-214-188.tpe.corp.google.com [172.30.214.188]) by mx.google.com with ESMTPSA id yh3sm2342867pbb.38.2014.09.01.19.56.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Sep 2014 19:56:54 -0700 (PDT) From: Daniel Kurtz To: Thierry Reding , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/panel: update innolux n116bge timings Date: Tue, 2 Sep 2014 10:56:46 +0800 Message-Id: <1409626606-15225-1-git-send-email-djkurtz@chromium.org> X-Mailer: git-send-email 2.1.0.rc2.206.gedb03e5 Cc: =?UTF-8?q?St=C3=A9phane=20Marchesin?= , linux-kernel@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There are several different models of N116BGE. According to the commit that added innolux_n116bge_mode [0], this N116BGE is for the eDP variety. [0] commit 0a2288c06aab73c966e82045c8f20b0e713baf2a Author: Thierry Reding Date: Thu Jul 3 14:02:59 2014 +0200 drm/panel: simple: Add Innolux N116BGE panel support The clock and htotal values from add by that patch are out of spec according to the datasheets I have seen for the eDP N116BGE (-EA2 and -EB2). This patch changes the values to the "Typ" values on the datasheet. Signed-off-by: Daniel Kurtz --- Thierry, It is possible that your timings were correct for the panel you are using on the norrin reference board. In that case I'm happy to upload a new patch that creates a new panel entry. However, I'm pretty sure we are using the same N116BGE. drivers/gpu/drm/panel/panel-simple.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 4ce1db0..776764a 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -519,15 +519,15 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = { }; static const struct drm_display_mode innolux_n116bge_mode = { - .clock = 71000, + .clock = 76420, .hdisplay = 1366, - .hsync_start = 1366 + 64, - .hsync_end = 1366 + 64 + 6, - .htotal = 1366 + 64 + 6 + 64, + .hsync_start = 1366 + 136, + .hsync_end = 1366 + 136 + 30, + .htotal = 1366 + 136 + 30 + 60, .vdisplay = 768, .vsync_start = 768 + 8, - .vsync_end = 768 + 8 + 4, - .vtotal = 768 + 8 + 4 + 8, + .vsync_end = 768 + 8 + 12, + .vtotal = 768 + 8 + 12 + 12, .vrefresh = 60, .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, };