From patchwork Wed Oct 1 06:19:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YoungJun Cho X-Patchwork-Id: 5009811 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4CE62BEEA6 for ; Wed, 1 Oct 2014 06:19:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 697D620259 for ; Wed, 1 Oct 2014 06:19:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4909E20220 for ; Wed, 1 Oct 2014 06:19:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BCE16E167; Tue, 30 Sep 2014 23:19:19 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 71CA76E167 for ; Tue, 30 Sep 2014 23:19:18 -0700 (PDT) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NCR0047L5K5NH40@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 01 Oct 2014 15:19:17 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.46]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id F7.9B.19034.5EC9B245; Wed, 01 Oct 2014 15:19:17 +0900 (KST) X-AuditID: cbfee691-f79b86d000004a5a-f1-542b9ce5fbd4 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 26.C1.09430.5EC9B245; Wed, 01 Oct 2014 15:19:17 +0900 (KST) Received: from localhost.localdomain ([10.252.75.90]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NCR002UR5K1JBD0@mmp2.samsung.com>; Wed, 01 Oct 2014 15:19:17 +0900 (KST) From: YoungJun Cho To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH 1/7] drm/exynos: fimd: remove unnecessary waiting vblank routine Date: Wed, 01 Oct 2014 15:19:07 +0900 Message-id: <1412144353-13114-2-git-send-email-yj44.cho@samsung.com> X-Mailer: git-send-email 1.9.0 In-reply-to: <1412144353-13114-1-git-send-email-yj44.cho@samsung.com> References: <1412144353-13114-1-git-send-email-yj44.cho@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t8zPd2nc7RDDG4947e4te4cq0XvuZNM Fle+vmezmHR/AovFi3sXWSzONr1ht5gx+SWbA7vH9m8PWD3udx9n8ujbsooxgDmKyyYlNSez LLVI3y6BK+P0veNMBXc5KnbcuMDWwLiHvYuRk0NCwETi8Ke7bBC2mMSFe+uBbC4OIYFljBJn XzxlhCm6v+Q9VGI6o0TTi6nMEE4rk8SDrefB2tkENCWef9zBCmKLCJhKdExaygJiMwtUSyye OJcJxBYWCJCYvaQfrIZFQFWiZeZRZhCbV8BF4vrdr1AnyUlM+b0AzOYUcJWYevYUUA0H0DIX iekzFUH2Sgi0s0ts/b6PDWKOgMS3yYdYQGokBGQlNh1ghhgjKXFwxQ2WCYzCCxgZVjGKphYk FxQnpReZ6hUn5haX5qXrJefnbmKEBPXEHYz3D1gfYhTgYFTi4VVI0A4RYk0sK67MPcRoCrRh IrOUaHI+MHbySuINjc2MLExNTI2NzC3NlMR5daR/BgsJpCeWpGanphakFsUXleakFh9iZOLg lGpglEuJ7bxsGnCT3+Oepa/hcp52rxulkc8mcZRrb7V8GpV7+MRBpg9fCmcsnnxZfYrP2Scv 2vcG2Cy9tu70j3eedUs45HR/LQk+HFumc618Lgcfx8slh+Jnrl60ez9bgPmUFvFP07xWPpyR uF97p2DnMuvW2J8X50xbbCLfqXkl68PnP20VTtM2KyixFGckGmoxFxUnAgAeXGw4ZQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsVy+t9jQd2nc7RDDJ7u47G4te4cq0XvuZNM Fle+vmezmHR/AovFi3sXWSzONr1ht5gx+SWbA7vH9m8PWD3udx9n8ujbsooxgDmqgdEmIzUx JbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2i9kkJZYk4pUCgg sbhYSd8O04TQEDddC5jGCF3fkCC4HiMDNJCwjjHj9L3jTAV3OSp23LjA1sC4h72LkZNDQsBE 4v6S92wQtpjEhXvrgWwuDiGB6YwSTS+mMkM4rUwSD7aeB6tiE9CUeP5xByuILSJgKtExaSkL iM0sUC2xeOJcJhBbWCBAYvaSfrAaFgFViZaZR5lBbF4BF4nrd79CbZaTmPJ7AZjNKeAqMfXs KaAaDqBlLhLTZypOYORdwMiwilE0tSC5oDgpPddIrzgxt7g0L10vOT93EyM4Zp5J72Bc1WBx iFGAg1GJh7ciSTtEiDWxrLgy9xCjBAezkgjvxAqgEG9KYmVValF+fFFpTmrxIUZToKMmMkuJ JucD4zmvJN7Q2MTMyNLIzNjE3NhYSZz3YKt1oJBAemJJanZqakFqEUwfEwenVAOj87wTd5dv sD2au//Pgm/tj+obtmrPPdsxpftr+M5d1y8XeGleCIqOzuP3ZtKV+N4+h2vazYIHZ38krfab OudU8Mzb8yfHrml1zlv3ZZWignyJR9uRLT4XT5/88Cdrz/wLM698c6vTiRF7dvVCFPPBbN2u rltrD7aLvs7StLvbcobre2PhlqPthkosxRmJhlrMRcWJAP1trcevAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: a.hajda@samsung.com, kyungmin.park@samsung.com, sw0312.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The exynos_drm_crtc_dpms() waits until pended page flip queue is empty, calls the drm_vblank_off() then calls manager->ops->dpms() when mode is DRM_MODE_DPMS_OFF. The fimd_dpms() is one of manager->ops->dpms()s and finally calls fimd_window_suspend(). But there is no active window and vblank is already off when it is called. So addtional waiting vblank is not necessary any more. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 085b066..8b31b7e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -803,7 +803,6 @@ static void fimd_window_suspend(struct exynos_drm_manager *mgr) if (win_data->enabled) fimd_win_disable(mgr, i); } - fimd_wait_for_vblank(mgr); } static void fimd_window_resume(struct exynos_drm_manager *mgr)