| Message ID | 1414675442-3471-2-git-send-email-gautam.vivek@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote: > > DP PHY now require pmu-system-controller to handle PMU register > to control PHY's power isolation. Adding the same to dp-phy > node. > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > Cc: Jingoo Han <jg1.han@samsung.com> Reviewed-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > --- > > Changes from V1: > - none. > > arch/arm/boot/dts/exynos5250.dtsi | 2 +- > arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 012b021..69f5eb0 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -732,7 +732,7 @@ > > dp_phy: video-phy@10040720 { > compatible = "samsung,exynos5250-dp-video-phy"; > - reg = <0x10040720 4>; > + samsung,pmu-syscon = <&pmu_system_controller>; > #phy-cells = <0>; > }; > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 8617a03..1353a09 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -503,8 +503,8 @@ > }; > > dp_phy: video-phy@10040728 { > - compatible = "samsung,exynos5250-dp-video-phy"; > - reg = <0x10040728 4>; > + compatible = "samsung,exynos5420-dp-video-phy"; > + samsung,pmu-syscon = <&pmu_system_controller>; > #phy-cells = <0>; > }; > > -- > 1.7.10.4
[adding Kukjin to cc list] Hello Vivek, On Wed, Nov 12, 2014 at 5:21 AM, Jingoo Han <jg1.han@samsung.com> wrote: > On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote: >> >> DP PHY now require pmu-system-controller to handle PMU register >> to control PHY's power isolation. Adding the same to dp-phy >> node. >> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> >> Cc: Jingoo Han <jg1.han@samsung.com> > > Reviewed-by: Jingoo Han <jg1.han@samsung.com> > Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Kukjin, This patch is -rc material and is needed to have display working in 3.18 again since commit a5ec598 ("phy: exynos-dp-video: Use syscon support to control pmu register") landed in 3.18 and broke the Exynos Display Port PHY: exynos-dp-video-phy 10040728.video-phy: Failed to lookup PMU regmap Best regards, Javier
Hi Javier, On Wed, Nov 19, 2014 at 5:06 PM, Javier Martinez Canillas <javier@dowhile0.org> wrote: > [adding Kukjin to cc list] > > Hello Vivek, > > On Wed, Nov 12, 2014 at 5:21 AM, Jingoo Han <jg1.han@samsung.com> wrote: >> On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote: >>> >>> DP PHY now require pmu-system-controller to handle PMU register >>> to control PHY's power isolation. Adding the same to dp-phy >>> node. >>> >>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> >>> Cc: Jingoo Han <jg1.han@samsung.com> >> >> Reviewed-by: Jingoo Han <jg1.han@samsung.com> >> > > Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Thanks for testing. > > Kukjin, Sorry for not adding Kukjin to the list and thereby for the delay about this patch. > > This patch is -rc material and is needed to have display working in > 3.18 again since commit a5ec598 ("phy: exynos-dp-video: Use syscon > support to control pmu register") landed in 3.18 and broke the Exynos > Display Port PHY: > > exynos-dp-video-phy 10040728.video-phy: Failed to lookup PMU regmap Yes, we should pick this up and merge it since the driver patch is merged now.
Hello Vivek On Wed, Nov 19, 2014 at 1:03 PM, Vivek Gautam <gautamvivek1987@gmail.com> wrote: >> >> Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > > Thanks for testing. > You are welcome >> >> Kukjin, > > Sorry for not adding Kukjin to the list and thereby for the delay > about this patch. > No worries but I'm not sure if Kukjin is aware of this patch. I see he has been applying other patches but didn't pick $subject. Maybe you can resend it to Kukjin just to be sure he will have it in his mailbox? Best regards, Javier
On Sun, Nov 23, 2014 at 12:26 AM, Javier Martinez Canillas <javier@dowhile0.org> wrote: > Hello Vivek > > On Wed, Nov 19, 2014 at 1:03 PM, Vivek Gautam <gautamvivek1987@gmail.com> wrote: >>> >>> Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >> >> Thanks for testing. >> > > You are welcome > >>> >>> Kukjin, >> >> Sorry for not adding Kukjin to the list and thereby for the delay >> about this patch. >> > > No worries but I'm not sure if Kukjin is aware of this patch. I see he > has been applying other patches but didn't pick $subject. Right, > > Maybe you can resend it to Kukjin just to be sure he will have it in > his mailbox? Posted a RESEND version of this patch. Thanks again for noticing.
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 012b021..69f5eb0 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -732,7 +732,7 @@ dp_phy: video-phy@10040720 { compatible = "samsung,exynos5250-dp-video-phy"; - reg = <0x10040720 4>; + samsung,pmu-syscon = <&pmu_system_controller>; #phy-cells = <0>; }; diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 8617a03..1353a09 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -503,8 +503,8 @@ }; dp_phy: video-phy@10040728 { - compatible = "samsung,exynos5250-dp-video-phy"; - reg = <0x10040728 4>; + compatible = "samsung,exynos5420-dp-video-phy"; + samsung,pmu-syscon = <&pmu_system_controller>; #phy-cells = <0>; };
DP PHY now require pmu-system-controller to handle PMU register to control PHY's power isolation. Adding the same to dp-phy node. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Cc: Jingoo Han <jg1.han@samsung.com> --- Changes from V1: - none. arch/arm/boot/dts/exynos5250.dtsi | 2 +- arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)