From patchwork Wed Nov 12 09:42:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 5291101 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 52461C11AC for ; Wed, 12 Nov 2014 17:07:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 56AF7201E4 for ; Wed, 12 Nov 2014 17:06:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 56C61200CA for ; Wed, 12 Nov 2014 17:06:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD8C96E7E4; Wed, 12 Nov 2014 09:06:53 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id E83966E2D4 for ; Wed, 12 Nov 2014 01:48:26 -0800 (PST) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NEX007M778KCI20@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 12 Nov 2014 18:48:20 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.122]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id EE.81.18484.3EC23645; Wed, 12 Nov 2014 18:48:19 +0900 (KST) X-AuditID: cbfee68f-f791c6d000004834-8e-54632ce3d1f8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 2A.E4.20081.3EC23645; Wed, 12 Nov 2014 18:48:19 +0900 (KST) Received: from chromebld-server.sisodomain.com ([107.108.73.106]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NEX00LR977Z7RA0@mmp2.samsung.com>; Wed, 12 Nov 2014 18:48:19 +0900 (KST) From: Vivek Gautam To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH v3 RESEND 1/2] drm/exynos: dp: Remove support for unused dptx-phy Date: Wed, 12 Nov 2014 15:12:10 +0530 Message-id: <1415785330-28123-1-git-send-email-gautam.vivek@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <000001cffe5c3df5500$%han@samsung.com> References: <000001cffe5c3df5500$%han@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsWyRsSkSvexTnKIwZu11hYH3h9ksbjy9T2b RduVg+wWk+5PYLHoXXCVzeLyrjlsFjPO72OymHsw14HDY8GmUo/73ceZPPq2rGL0+LxJLoAl issmJTUnsyy1SN8ugSvj7+TbrAUn5So2PG1nb2D8INHFyMkhIWAi8WjbVyYIW0ziwr31bF2M XBxCAksZJc6vX8wKU/TqYRMTRGI6o8Tj/TdZIZwJTBKHVpwEa2cT0JVoeruLEcQWEXCTaDo8 E6yIWWALo8Tn/i/sIAlhgWCJt/uego1lEVCVuL1rDlgzr4CHxMFjv1i6GDmA1ilIzJlkAxLm FDCW6Nv3gA0kLCRgJPH3ejTISAmBeewS6xfNYYQYIyDxbfIhqFZZiU0HmCGOlpQ4uOIGywRG 4QWMDKsYRVMLkguKk9KLjPWKE3OLS/PS9ZLzczcxAkP89L9n/TsY7x6wPsQowMGoxMObsTkp RIg1say4MvcQoynQhonMUqLJ+cBIyiuJNzQ2M7IwNTE1NjK3NFMS510o9TNYSCA9sSQ1OzW1 ILUovqg0J7X4ECMTB6dUA2P2/Xvu8X/Kl3vW5P/aXfa1JOXNHXWRLBf+byFPvlbmpCUu4p77 dKnmlgNM+kxaO/c8sd3/bMKKWaHSZjHLxI/LnRTqdste1bVy6aKV+o67dAw7Zy3luXoyRC3s w8zVD6/+TzBh+qP4g33x45nVCVXCEesu+p+benxB39mfFocfR865rsRcP0VMiaU4I9FQi7mo OBEAtQ8v+GwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsVy+t9jQd3HOskhBv8eGFoceH+QxeLK1/ds Fm1XDrJbTLo/gcWid8FVNovLu+awWcw4v4/JYu7BXAcOjwWbSj3udx9n8ujbsorR4/MmuQCW qAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygK5QU yhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWMGX8n32YtOClXseFpO3sD4weJ LkZODgkBE4lXD5uYIGwxiQv31rN1MXJxCAlMZ5R4vP8mK4QzgUni0IqTYFVsAroSTW93MYLY IgJuEk2HZ4IVMQtsYZT43P+FHSQhLBAs8XbfU1YQm0VAVeL2rjlgzbwCHhIHj/1i6WLkAFqn IDFnkg1ImFPAWKJv3wM2kLCQgJHE3+vRExh5FzAyrGIUTS1ILihOSs811CtOzC0uzUvXS87P 3cQIjqBnUjsYVzZYHGIU4GBU4uFNXJMUIsSaWFZcmXuIUYKDWUmE99NXoBBvSmJlVWpRfnxR aU5q8SFGU6CbJjJLiSbnA6M7ryTe0NjE3NTY1NLEwsTMUkmc90CrdaCQQHpiSWp2ampBahFM HxMHp1QDo4ztzsPlj49HTDW7P3HjuU9hc09xBugH7Jp1zOW+a//c4Ecffk2311aY19KqfNvy 9I1lO9vP9ga+37FkMdOm1+lvMpetWivLdl9S6sOKQ1P/W87a1JudvFBmaUa6boGJncHGGykv vnPt/FMk483vV8vDV7D/49dojm//N1l7rcz6szLBOnbelVNKLMUZiYZazEXFiQDlp3xDtgIA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Mailman-Approved-At: Wed, 12 Nov 2014 09:06:41 -0800 Cc: kgene.kim@samsung.com, seanpaul@google.com, linux-kernel@vger.kernel.org, Vivek Gautam , ajaykumar.rs@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Now that we have moved to generic phy based bindings, we don't need to have any code related to older dptx-phy. Nobody is using this dptx-phy anymore, so removing the same. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han Cc: Inki Dae --- Problem with my mail client caused change in author's mail id. So resending it with authorship under my Samsung id. drivers/gpu/drm/exynos/exynos_dp_core.c | 74 +++++++------------------------ drivers/gpu/drm/exynos/exynos_dp_core.h | 2 - 2 files changed, 17 insertions(+), 59 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index cd50ece..dbe9add 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c @@ -1052,28 +1052,14 @@ static int exynos_dp_create_connector(struct exynos_drm_display *display, static void exynos_dp_phy_init(struct exynos_dp_device *dp) { - if (dp->phy) { + if (dp->phy) phy_power_on(dp->phy); - } else if (dp->phy_addr) { - u32 reg; - - reg = __raw_readl(dp->phy_addr); - reg |= dp->enable_mask; - __raw_writel(reg, dp->phy_addr); - } } static void exynos_dp_phy_exit(struct exynos_dp_device *dp) { - if (dp->phy) { + if (dp->phy) phy_power_off(dp->phy); - } else if (dp->phy_addr) { - u32 reg; - - reg = __raw_readl(dp->phy_addr); - reg &= ~(dp->enable_mask); - __raw_writel(reg, dp->phy_addr); - } } static void exynos_dp_poweron(struct exynos_drm_display *display) @@ -1210,44 +1196,6 @@ static struct video_info *exynos_dp_dt_parse_pdata(struct device *dev) return dp_video_config; } -static int exynos_dp_dt_parse_phydata(struct exynos_dp_device *dp) -{ - struct device_node *dp_phy_node = of_node_get(dp->dev->of_node); - u32 phy_base; - int ret = 0; - - dp_phy_node = of_find_node_by_name(dp_phy_node, "dptx-phy"); - if (!dp_phy_node) { - dp->phy = devm_phy_get(dp->dev, "dp"); - return PTR_ERR_OR_ZERO(dp->phy); - } - - if (of_property_read_u32(dp_phy_node, "reg", &phy_base)) { - dev_err(dp->dev, "failed to get reg for dptx-phy\n"); - ret = -EINVAL; - goto err; - } - - if (of_property_read_u32(dp_phy_node, "samsung,enable-mask", - &dp->enable_mask)) { - dev_err(dp->dev, "failed to get enable-mask for dptx-phy\n"); - ret = -EINVAL; - goto err; - } - - dp->phy_addr = ioremap(phy_base, SZ_4); - if (!dp->phy_addr) { - dev_err(dp->dev, "failed to ioremap dp-phy\n"); - ret = -ENOMEM; - goto err; - } - -err: - of_node_put(dp_phy_node); - - return ret; -} - static int exynos_dp_dt_parse_panel(struct exynos_dp_device *dp) { int ret; @@ -1277,9 +1225,21 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) if (IS_ERR(dp->video_info)) return PTR_ERR(dp->video_info); - ret = exynos_dp_dt_parse_phydata(dp); - if (ret) - return ret; + dp->phy = devm_phy_get(dp->dev, "dp"); + if (IS_ERR(dp->phy)) { + dev_err(dp->dev, "no DP phy configured\n"); + ret = PTR_ERR(dp->phy); + if (ret) { + /* + * phy itself is not enabled, so we can move forward + * assigning NULL to phy pointer. + */ + if (ret == -ENOSYS || ret == -ENODEV) + dp->phy = NULL; + else + return ret; + } + } if (!dp->panel) { ret = exynos_dp_dt_parse_panel(dp); diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h index a1aee69..6426201 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.h +++ b/drivers/gpu/drm/exynos/exynos_dp_core.h @@ -153,8 +153,6 @@ struct exynos_dp_device { struct clk *clock; unsigned int irq; void __iomem *reg_base; - void __iomem *phy_addr; - unsigned int enable_mask; struct video_info *video_info; struct link_train link_train;