| Message ID | 1415792295-2466-3-git-send-email-daniel.thompson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 12, 2014 at 11:38:13AM +0000, Daniel Thompson wrote: > gem_prime_map is not currently described in the DRM manual, lets document > it. > > Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> Patches 1&2 are Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Nit: Since this fixes an oversight in an earlier patch I usally cc the people of the offending patch: commit 7c397cd97b8f46659698396b420bd48c3e6703e6 Author: Joonyoung Shim <jy0922.shim@samsung.com> Date: Fri Jun 28 14:24:53 2013 +0900 drm: add mmap function to prime helpers Cheers, Daniel
On Wed, Nov 12, 2014 at 6:38 AM, Daniel Thompson <daniel.thompson@linaro.org> wrote: > gem_prime_map is not currently described in the DRM manual, lets document > it. > > Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> Reviewed-by: Rob Clark <robdclark@gmail.com> > --- > drivers/gpu/drm/drm_prime.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c > index 8467b17c8053..5d00c8726133 100644 > --- a/drivers/gpu/drm/drm_prime.c > +++ b/drivers/gpu/drm/drm_prime.c > @@ -309,7 +309,7 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = { > * Drivers can implement @gem_prime_export and @gem_prime_import in terms of > * simpler APIs by using the helper functions @drm_gem_prime_export and > * @drm_gem_prime_import. These functions implement dma-buf support in terms of > - * five lower-level driver callbacks: > + * six lower-level driver callbacks: > * > * Export callbacks: > * > @@ -321,6 +321,8 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = { > * > * - @gem_prime_vunmap: vunmap a buffer exported by your driver > * > + * - @gem_prime_mmap (optional): mmap a buffer exported by your driver > + * > * Import callback: > * > * - @gem_prime_import_sg_table (import): produce a GEM object from another > -- > 1.9.3 >
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index 8467b17c8053..5d00c8726133 100644 --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -309,7 +309,7 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = { * Drivers can implement @gem_prime_export and @gem_prime_import in terms of * simpler APIs by using the helper functions @drm_gem_prime_export and * @drm_gem_prime_import. These functions implement dma-buf support in terms of - * five lower-level driver callbacks: + * six lower-level driver callbacks: * * Export callbacks: * @@ -321,6 +321,8 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = { * * - @gem_prime_vunmap: vunmap a buffer exported by your driver * + * - @gem_prime_mmap (optional): mmap a buffer exported by your driver + * * Import callback: * * - @gem_prime_import_sg_table (import): produce a GEM object from another
gem_prime_map is not currently described in the DRM manual, lets document it. Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> --- drivers/gpu/drm/drm_prime.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)