From patchwork Fri Nov 14 22:12:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 5309851 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 029DAC11AC for ; Fri, 14 Nov 2014 22:13:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 43EDE2015D for ; Fri, 14 Nov 2014 22:13:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 69C9820149 for ; Fri, 14 Nov 2014 22:13:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC51A6E225; Fri, 14 Nov 2014 14:13:04 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qa0-f44.google.com (mail-qa0-f44.google.com [209.85.216.44]) by gabe.freedesktop.org (Postfix) with ESMTP id A86006E225 for ; Fri, 14 Nov 2014 14:13:03 -0800 (PST) Received: by mail-qa0-f44.google.com with SMTP id v10so3024546qac.31 for ; Fri, 14 Nov 2014 14:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=BYctk8SqrQ6hxgLdP80R8D0GTSth9I0qppa8C5AdQj4=; b=ZNV5gkU/WAogf0d28WC2v9/ZBg8LeC+BOPpwxdTQr39YNSGIZpn/V1xQLbiiGvZmh/ PNzKAV4VaxLhJvyoKJ6HTmqFpK6G9EPBUhI2W1/yM4wXjOOy9AB9g2PC8znFqxL3JmJk 1LCFZzAutzTS9lxpIMCm98s+mAL+UwStRUY1nwBj9qMFqtwRbAcig/kw2OYxvvzTVunI CJpc60q9E88pvJ1L6EBk5p9jp2OK6zBOVtcUldNJ1mlioyxRjn2n9zp3lB0R1n1QLVoM BNdI2fnlwmFjr/M3XkHlvmGesaohMPrbVgY/5wflb1NZTNiDDGQpJ0cTuQGoH1fm2GU7 tLag== X-Received: by 10.224.65.4 with SMTP id g4mr14826555qai.20.1416003183369; Fri, 14 Nov 2014 14:13:03 -0800 (PST) Received: from localhost ([2601:6:2c00:943:2677:3ff:fed3:ff40]) by mx.google.com with ESMTPSA id h10sm3083896qge.16.2014.11.14.14.13.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Nov 2014 14:13:02 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/atomic: rip out unnecessary locking checks Date: Fri, 14 Nov 2014 17:12:59 -0500 Message-Id: <1416003179-15292-1-git-send-email-robdclark@gmail.com> X-Mailer: git-send-email 1.9.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For async commit, it is *intentional* that those locks are not held. Reviewed-by: Daniel Vetter Signed-off-by: Rob Clark --- opps, hit send too soon, disregard last one drivers/gpu/drm/drm_atomic_helper.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index c0a07cb..fad2b93 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1006,8 +1006,6 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, if (!crtc) continue; - WARN_ON(!drm_modeset_is_locked(&crtc->mutex)); - funcs = crtc->helper_private; if (!funcs || !funcs->atomic_begin) @@ -1023,8 +1021,6 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, if (!plane) continue; - WARN_ON(!drm_modeset_is_locked(&plane->mutex)); - funcs = plane->helper_private; if (!funcs || !funcs->atomic_update)