From patchwork Mon Nov 17 13:00:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YoungJun Cho X-Patchwork-Id: 5318721 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 83AF9C11AE for ; Mon, 17 Nov 2014 13:00:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C39F120212 for ; Mon, 17 Nov 2014 13:00:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 90C4E2020E for ; Mon, 17 Nov 2014 13:00:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D8496E01A; Mon, 17 Nov 2014 05:00:25 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id D11916E092 for ; Mon, 17 Nov 2014 05:00:24 -0800 (PST) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NF600LK7PGK9T40@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 17 Nov 2014 22:00:21 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.41]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 6F.03.18167.461F9645; Mon, 17 Nov 2014 22:00:20 +0900 (KST) X-AuditID: cbfee690-f79ab6d0000046f7-7e-5469f164c5e1 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 12.52.20081.461F9645; Mon, 17 Nov 2014 22:00:20 +0900 (KST) Received: from localhost.localdomain ([10.252.75.90]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NF60048CPGGHM50@mmp2.samsung.com>; Mon, 17 Nov 2014 22:00:20 +0900 (KST) From: YoungJun Cho To: dri-devel@lists.freedesktop.org Subject: [PATCH 6/9] drm/exynos: fimd: add triggering unset routine in fimd_trigger() Date: Mon, 17 Nov 2014 22:00:13 +0900 Message-id: <1416229216-32018-7-git-send-email-yj44.cho@samsung.com> X-Mailer: git-send-email 1.9.0 In-reply-to: <1416229216-32018-1-git-send-email-yj44.cho@samsung.com> References: <1416229216-32018-1-git-send-email-yj44.cho@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsVy+t8zTd2Uj5khBs/arC1urTvHanHl63s2 i0n3J7BYvLh3kcXibNMbdosZ5/cxWcyY/JLNgd3jfvdxJo++LasYPT5vkgtgjuKySUnNySxL LdK3S+DKmPy7jbFgEmfF5fO72RsYb7F3MXJySAiYSNzc9JIJwhaTuHBvPRuILSSwjFFi5pwi mJrTt+YB1XABxaczShx4cZQRwmllknj3vhesg01AU+L5xx2sILaIgLLE34mrGEFsZoEFjBJX b3B0MXJwCAuES0yf5gESZhFQlfh1ezorSJhXwEXi7SF/iF1yElN+LwC7jVPAVeLN7B5GiHtc JJZ8Owm2VkKgm11i245HzBBzBCS+TT7EAjJHQkBWYtMBZog5khIHV9xgmcAovICRYRWjaGpB ckFxUnqRiV5xYm5xaV66XnJ+7iZGSDhP2MF474D1IUYBDkYlHt4d2ZkhQqyJZcWVuYcYTYE2 TGSWEk3OB0ZNXkm8obGZkYWpiamxkbmlmZI472upn8FCAumJJanZqakFqUXxRaU5qcWHGJk4 OKUaGNfJRH+0PvKXq+Xl58uLlDcq9piu9qx5x86/8VnSs3V69ybfb8h7pz+9dIr08o28zztO 9V1dc4DB+q3rpJy4fz1H/lt1365elB+/iWH6nEgOyayekjOCDNN993xQCj2W9MmVdbvG6lmX PjYvu2LQIPbuYv1utjmsf1PmL25lLOz4H/PsPlejqqQSS3FGoqEWc1FxIgCCYzVLYgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsVy+t9jQd2Uj5khBsf2mVvcWneO1eLK1/ds FpPuT2CxeHHvIovF2aY37BYzzu9jspgx+SWbA7vH/e7jTB59W1YxenzeJBfAHNXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmDH5dxtjwSTOisvnd7M3MN5i72Lk5JAQMJE4 fWseE4QtJnHh3nq2LkYuDiGB6YwSB14cZYRwWpkk3r3vZQOpYhPQlHj+cQcriC0ioCzxd+Iq RhCbWWABo8TVGxxdjBwcwgLhEtOneYCEWQRUJX7dns4KEuYVcJF4e8gfYpecxJTfC8Bu4BRw lXgzuwdsihBQyZJvJxknMPIuYGRYxSiaWpBcUJyUnmuoV5yYW1yal66XnJ+7iREcL8+kdjCu bLA4xCjAwajEw7sjOzNEiDWxrLgy9xCjBAezkghvzEWgEG9KYmVValF+fFFpTmrxIUZToKMm MkuJJucDYzmvJN7Q2MTMyNLIzNjE3NhYSZz3QKt1oJBAemJJanZqakFqEUwfEwenVANjdWJD T9Dqqd+lz6edC/3x6MDXZ5H/pz9PT1nFx3kgZNKhNf+/a9v7zNxg6Ccm+L+Up9SBb2vn1FXd L/ZP37ij7qXXFpfjW3szlic9fm/AuO2yh8xa7vb3uz02Ljco03qh0bjAk39BfNeeEzNN7W5t kPxZtYc30PtmU952628VDYlLlBZvPfBASImlOCPRUIu5qDgRAFQiLsStAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: linux-samsung-soc@vger.kernel.org, sw0312.kim@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is a case like set config which requires triggering but vblank is not enabled yet. So triggering unset routine is required to exit from triggering mode. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 3c63237..e488b80 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -984,6 +984,13 @@ static void fimd_trigger(struct device *dev) reg = readl(timing_base + TRIGCON); reg |= (TRGMODE_I80_RGB_ENABLE_I80 | SWTRGCMD_I80_RGB_ENABLE); writel(reg, timing_base + TRIGCON); + + /* + * Exits triggering mode if vblank is not enabled yet, because when the + * VIDINTCON0 register is not set, it can not exit from triggering mode. + */ + if (!test_bit(0, &ctx->irq_flags)) + atomic_set(&ctx->triggering, 0); } static void fimd_te_handler(struct exynos_drm_manager *mgr)