From patchwork Wed Nov 19 19:47:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 5340791 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2B8899F1E1 for ; Wed, 19 Nov 2014 19:48:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0FA522020E for ; Wed, 19 Nov 2014 19:48:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 972F52021A for ; Wed, 19 Nov 2014 19:48:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D40E06F16F; Wed, 19 Nov 2014 11:48:36 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qc0-f174.google.com (mail-qc0-f174.google.com [209.85.216.174]) by gabe.freedesktop.org (Postfix) with ESMTP id DBA606F16F; Wed, 19 Nov 2014 11:48:35 -0800 (PST) Received: by mail-qc0-f174.google.com with SMTP id c9so1014531qcz.5 for ; Wed, 19 Nov 2014 11:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/gqACc62VkwKEiGX2iMZ7kfYswDs3sVsFHQIHHDN9pI=; b=rTigrpfKwWBBIEqgVVKFks5h2Z2mwNpw7vhFXiwRCefagJI6LRWFiUwcxnCWwkoNMq dnwst/z3c3IYOsyYoVT0HTTuTBGpOIYfSvQwWyKKJS5I9i/G4GztiEf0S8dUvX3O/iFB seFySK3C6cfSpQf8UlRonzKX75Y31l+e1v6MoJf/qhH+HrOOM7+PP9jr0evHmUJ3fzoJ QB7cyPzDXzkYmnvG46XRX6CzWykvjeJe7T43H/vRGo73V4OMMHk5SuAUxyWJaYyRh+dJ 3S2yhYPISpDVBAlAIkCrrPr1h20dNbKL9hP60DAA9um/8xbfJH7ELOAbU0iINWAh6E2I hpaw== X-Received: by 10.224.127.133 with SMTP id g5mr55123703qas.24.1416426515524; Wed, 19 Nov 2014 11:48:35 -0800 (PST) Received: from localhost.localdomain ([177.96.119.122]) by mx.google.com with ESMTPSA id b60sm168806qge.22.2014.11.19.11.48.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Nov 2014 11:48:34 -0800 (PST) From: Paulo Zanoni To: dri-devel@lists.freedesktop.org Subject: [RFC 7/7] drm: make the callers of drm_wait_vblank() allocate the memory Date: Wed, 19 Nov 2014 17:47:15 -0200 Message-Id: <1416426435-2237-9-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1416426435-2237-1-git-send-email-przanoni@gmail.com> References: <1416426435-2237-1-git-send-email-przanoni@gmail.com> Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni This way, the Kernel users will be able to fully control the lifetime of struct drm_vblank_wait_item, and they will also be able to wrap it to store their own information. As a result, one less memory allocation will happen, and the Kernel codepath will not set all those drm_pending_vblank_event struct fields. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/drm_irq.c | 92 ++++++++++++++++++++----------------- drivers/gpu/drm/i915/i915_debugfs.c | 11 ++--- include/drm/drmP.h | 2 +- 3 files changed, 57 insertions(+), 48 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index dd091c3..5fa5431 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -1402,36 +1402,26 @@ static void drm_vblank_event_work_func(struct work_struct *work) static int drm_queue_vblank_event(struct drm_device *dev, int pipe, union drm_wait_vblank *vblwait, - struct drm_file *file_priv, bool callback_from_work, - drm_vblank_callback_t callback) + drm_vblank_callback_t callback, + struct drm_vblank_wait_item *item) { struct drm_vblank_crtc *vblank = &dev->vblank[pipe]; - struct drm_pending_vblank_event *e; struct timeval now; unsigned long flags; unsigned int seq; int ret; - e = kzalloc(sizeof *e, GFP_KERNEL); - if (e == NULL) { - ret = -ENOMEM; + if (WARN_ON(!item)) { + ret = -EINVAL; goto err_put; } - e->item.pipe = pipe; - e->base.pid = current->pid; - e->event.base.type = DRM_EVENT_VBLANK; - e->event.base.length = sizeof e->event; - e->event.user_data = vblwait->request.signal; - e->base.event = &e->event.base; - e->base.file_priv = file_priv; - e->base.destroy = (void (*) (struct drm_pending_event *)) kfree; - e->item.from_user_space = true; - e->item.callback = callback; - e->item.callback_from_work = callback_from_work; + item->pipe = pipe; + item->callback = callback; + item->callback_from_work = callback_from_work; if (callback_from_work) - INIT_WORK(&e->item.callback_work, drm_vblank_event_work_func); + INIT_WORK(&item->callback_work, drm_vblank_event_work_func); spin_lock_irqsave(&dev->event_lock, flags); @@ -1447,15 +1437,6 @@ static int drm_queue_vblank_event(struct drm_device *dev, int pipe, goto err_unlock; } - if (file_priv) { - if (file_priv->event_space < sizeof e->event) { - ret = -EBUSY; - goto err_unlock; - } - - file_priv->event_space -= sizeof e->event; - } - seq = drm_vblank_count_and_time(dev, pipe, &now); if ((vblwait->request.type & _DRM_VBLANK_NEXTONMISS) && @@ -1470,14 +1451,14 @@ static int drm_queue_vblank_event(struct drm_device *dev, int pipe, trace_drm_vblank_event_queued(current->pid, pipe, vblwait->request.sequence); - e->item.wanted_seq = vblwait->request.sequence; + item->wanted_seq = vblwait->request.sequence; if ((seq - vblwait->request.sequence) <= (1 << 23)) { drm_vblank_put(dev, pipe); - drm_wait_vblank_callback(dev, &e->item, seq, &now, false); + drm_wait_vblank_callback(dev, item, seq, &now, false); vblwait->reply.sequence = seq; } else { /* drm_handle_vblank_events will call drm_vblank_put */ - list_add_tail(&e->item.link, &dev->vblank_event_list); + list_add_tail(&item->link, &dev->vblank_event_list); vblwait->reply.sequence = vblwait->request.sequence; } @@ -1487,7 +1468,6 @@ static int drm_queue_vblank_event(struct drm_device *dev, int pipe, err_unlock: spin_unlock_irqrestore(&dev->event_lock, flags); - kfree(e); err_put: drm_vblank_put(dev, pipe); return ret; @@ -1509,9 +1489,9 @@ err_put: */ static int __drm_wait_vblank(struct drm_device *dev, union drm_wait_vblank *vblwait, - struct drm_file *file_priv, bool callback_from_work, - drm_vblank_callback_t callback) + drm_vblank_callback_t callback, + struct drm_vblank_wait_item *item) { struct drm_vblank_crtc *vblank; int ret; @@ -1566,8 +1546,9 @@ static int __drm_wait_vblank(struct drm_device *dev, /* must hold on to the vblank ref until the event fires * drm_vblank_put will be called asynchronously */ - return drm_queue_vblank_event(dev, crtc, vblwait, file_priv, - callback_from_work, callback); + return drm_queue_vblank_event(dev, crtc, vblwait, + callback_from_work, callback, + item); } if ((flags & _DRM_VBLANK_NEXTONMISS) && @@ -1606,15 +1587,44 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) { union drm_wait_vblank *vblwait = data; + struct drm_pending_vblank_event *e = NULL; + unsigned int flags = vblwait->request.type & _DRM_VBLANK_FLAGS_MASK; + int ret; + + if (flags & _DRM_VBLANK_EVENT) { + e = kzalloc(sizeof *e, GFP_KERNEL); + if (e == NULL) + return -ENOMEM; + + e->base.pid = current->pid; + e->event.base.type = DRM_EVENT_VBLANK; + e->event.base.length = sizeof e->event; + e->event.user_data = vblwait->request.signal; + e->base.event = &e->event.base; + e->base.file_priv = file_priv; + e->base.destroy = (void (*) (struct drm_pending_event *)) kfree; + e->item.from_user_space = true; - return __drm_wait_vblank(dev, vblwait, file_priv, false, - send_vblank_event); + if (file_priv->event_space < sizeof e->event) { + kfree(e); + return -EBUSY; + } + file_priv->event_space -= sizeof e->event; + } + + ret = __drm_wait_vblank(dev, vblwait, false, send_vblank_event, + &e->item); + + if (ret && e) + kfree(e); + + return ret; } int drm_wait_vblank_kernel(struct drm_crtc *crtc, int count, bool absolute, bool callback_from_work, drm_vblank_callback_t callback, - unsigned long user_data) + struct drm_vblank_wait_item *item) { struct drm_device *dev = crtc->dev; union drm_wait_vblank vblwait; @@ -1627,10 +1637,10 @@ int drm_wait_vblank_kernel(struct drm_crtc *crtc, int count, bool absolute, vblwait.request.type = type; vblwait.request.sequence = count; - vblwait.request.signal = user_data; + vblwait.request.signal = 0; - return __drm_wait_vblank(dev, &vblwait, NULL, callback_from_work, - callback); + return __drm_wait_vblank(dev, &vblwait, callback_from_work, callback, + item); } EXPORT_SYMBOL(drm_wait_vblank_kernel); diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index b5c3f81..d2f3ca9 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -2719,6 +2719,7 @@ struct vblank_data { int eight; const char *message; bool can_sleep; + struct drm_vblank_wait_item item; }; static void vblank_callback(struct drm_device *dev, @@ -2726,16 +2727,14 @@ static void vblank_callback(struct drm_device *dev, unsigned long seq, struct timeval *now, bool premature) { - struct drm_pending_vblank_event *e = - container_of(item, struct drm_pending_vblank_event, item); - struct vblank_data *data = (struct vblank_data *)e->event.user_data; + struct vblank_data *data = + container_of(item, struct vblank_data, item); WARN_ON(data->can_sleep != drm_can_sleep()); WARN_ON(data->eight != 8); DRM_DEBUG_KMS("vblank callback, seq: %lu, premature: %s message:%s\n", seq, yesno(premature), data->message); - e->base.destroy(&e->base); kfree(data); } @@ -2783,7 +2782,7 @@ static int i915_vblank_queue_test_new(struct seq_file *m, void *unused) DRM_DEBUG_KMS("scheduling 60 vblanks (with callback, can't sleep)\n"); ret = drm_wait_vblank_kernel(&crtc->base, 60, false, false, - vblank_callback, (unsigned long) data1); + vblank_callback, &data1->item); if (ret) { DRM_DEBUG_KMS("vblank schedule error: %d\n", ret); kfree(data1); @@ -2794,7 +2793,7 @@ static int i915_vblank_queue_test_new(struct seq_file *m, void *unused) DRM_DEBUG_KMS("scheduling 60 vblanks (with callback, can sleep)\n"); ret = drm_wait_vblank_kernel(&crtc->base, 60, false, true, - vblank_callback, (unsigned long) data2); + vblank_callback, &data2->item); if (ret) { DRM_DEBUG_KMS("vblank schedule error: %d\n", ret); kfree(data2); diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 46724d9..55d73d0 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -926,7 +926,7 @@ extern int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, extern int drm_wait_vblank_kernel(struct drm_crtc *crtc, int count, bool absolute, bool callback_from_work, drm_vblank_callback_t callback, - unsigned long user_data); + struct drm_vblank_wait_item *item); extern u32 drm_vblank_count(struct drm_device *dev, int crtc); extern u32 drm_vblank_count_and_time(struct drm_device *dev, int crtc, struct timeval *vblanktime);