From patchwork Thu Nov 20 10:24:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 5347291 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5E227C11AD for ; Thu, 20 Nov 2014 10:25:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9D3E9200E9 for ; Thu, 20 Nov 2014 10:25:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3B6E2201FB for ; Thu, 20 Nov 2014 10:25:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EC156F6D9; Thu, 20 Nov 2014 02:24:59 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AF156EE53 for ; Thu, 20 Nov 2014 02:24:52 -0800 (PST) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NFC001UZ29FC440@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 20 Nov 2014 19:24:51 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.116]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id E6.18.19034.371CD645; Thu, 20 Nov 2014 19:24:51 +0900 (KST) X-AuditID: cbfee691-f79b86d000004a5a-51-546dc17375e6 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 40.9F.09430.371CD645; Thu, 20 Nov 2014 19:24:51 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.252.83.67]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NFC000N029CT7B0@mmp1.samsung.com>; Thu, 20 Nov 2014 19:24:51 +0900 (KST) From: Inki Dae To: dri-devel@lists.freedesktop.org Subject: [RFC PATCH v3 4/4] drm/exynos: clean up machine compatible string check Date: Thu, 20 Nov 2014 19:24:48 +0900 Message-id: <1416479088-29371-5-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1416479088-29371-1-git-send-email-inki.dae@samsung.com> References: <1416479088-29371-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsWyRsSkRLf4YG6Iwb8WeYvecyeZLK58fc9m Men+BBaLGef3MTmweGz/9oDV4373cSaPvi2rGD0+b5ILYInisklJzcksSy3St0vgyvjac529 4B53xfv9EQ2MJzi7GDk5JARMJKZP7WSFsMUkLtxbz9bFyMUhJLCUUWLKzG0sMEUnm78zQSQW MUosWnOBEcLpZpI48f00WBWbgKrExBX32UBsEQFlib8TVzGC2MwCURLLDy9lB7GFBQIkpm37 CRZnAarvubwYzOYVcJG4fOgFcxcjB9A2BYk5k2xAwpwCrhK/r6xhAwkLAZX8XCsBslZC4Dub xL7HE9ggxghIfJt8iAWiVVZi0wFmiJslJQ6uuMEygVF4ASPDKkbR1ILkguKk9CJTveLE3OLS vHS95PzcTYzA0D3979nEHYz3D1gfYhTgYFTi4U2wyA0RYk0sK67MPcRoCrRhIrOUaHI+MELy SuINjc2MLExNTI2NzC3NlMR5daR/BgsJpCeWpGanphakFsUXleakFh9iZOLglGpg3Dfj8iYz p3uW284cjX/ZbyJXYvPK6eyJe+nrw2/o86SVzp3bu2IPu0qrlV/ExZXfJz798n++qSOLyKW2 3fqrHM/Lq+Ufujh7o4lcWMIyxvdS4ubrRP3uenrt083efzDhlsPDDcGqUiejdtS4nQ467647 W6W+z2Nu/6a2P6JCP1OKt6ul2MRpKbEUZyQaajEXFScCAK+PPERYAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42I5/e+xgG7xwdwQg4vNkha9504yWVz5+p7N YtL9CSwWM87vY3Jg8dj+7QGrx/3u40wefVtWMXp83iQXwBLVwGiTkZqYklqkkJqXnJ+SmZdu q+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RTSaEsMacUKBSQWFyspG+HaUJoiJuu BUxjhK5vSBBcj5EBGkhYw5jxtec6e8E97or3+yMaGE9wdjFyckgImEicbP7OBGGLSVy4t56t i5GLQ0hgEaPEojUXGCGcbiaJE99Ps4BUsQmoSkxccZ8NxBYRUJb4O3EVI4jNLBAlsfzwUnYQ W1ggQGLatp9gcRag+p7Li8FsXgEXicuHXjB3MXIAbVOQmDPJBiTMKeAq8fvKGjaQsBBQyc+1 EhMYeRcwMqxiFE0tSC4oTkrPNdIrTswtLs1L10vOz93ECI6MZ9I7GFc1WBxiFOBgVOLhTbDI DRFiTSwrrsw9xCjBwawkwquxEyjEm5JYWZValB9fVJqTWnyI0RToponMUqLJ+cCozSuJNzQ2 MTOyNDI3tDAyNlcS572+CqhJID2xJDU7NbUgtQimj4mDU6qBMdFt75nnLw6b66/UO5F3la/5 xR/Ph8a13ndqNSwPOxrZfetx/qLCsGaOfUhF/tJqha99bw4d9oydEJ/DV3diXWbB9YWnJ92+ 9f5Z79t3ey18RY2VO25tWJASX/SR0Ub61Ol2vz+vLCeXi4Z6ifZY/21ceyjT1oClN2Hliq9l 3Jq1i5bXlgexKLEUZyQaajEXFScCALxQwSqiAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: linux-samsung-soc@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use 'for' statemant instead of hard-coded 'if' statement. Changelog v3: - none Changelog v2: - none Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 3ac39b6..4579186 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -587,9 +587,16 @@ static struct platform_driver exynos_drm_platform_driver = { }, }; +static const char * const strings[] = { + "samsung,exynos3", + "samsung,exynos4", + "samsung,exynos5", +}; + static int exynos_drm_init(void) { - int ret; + bool is_exynos = false; + int ret, i; /* * Register device object only in case of Exynos SoC. @@ -598,9 +605,14 @@ static int exynos_drm_init(void) * by Exynos drm driver when using multi-platform kernel. * So these codes will be replaced with more generic way later. */ - if (!of_machine_is_compatible("samsung,exynos3") && - !of_machine_is_compatible("samsung,exynos4") && - !of_machine_is_compatible("samsung,exynos5")) + for (i = 0; i < ARRAY_SIZE(strings); i++) { + if (of_machine_is_compatible(strings[i])) { + is_exynos = true; + break; + } + } + + if (!is_exynos) return -ENODEV; exynos_drm_pdev = platform_device_register_simple("exynos-drm", -1,