From patchwork Thu Nov 20 23:42:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 5351321 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6214D9F2F1 for ; Thu, 20 Nov 2014 23:43:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9E5F22021B for ; Thu, 20 Nov 2014 23:43:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id B5D5C201FA for ; Thu, 20 Nov 2014 23:43:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22F4D6F7D3; Thu, 20 Nov 2014 15:43:07 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qa0-f43.google.com (mail-qa0-f43.google.com [209.85.216.43]) by gabe.freedesktop.org (Postfix) with ESMTP id C41906F7D3 for ; Thu, 20 Nov 2014 15:43:05 -0800 (PST) Received: by mail-qa0-f43.google.com with SMTP id bm13so2689822qab.2 for ; Thu, 20 Nov 2014 15:43:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7n/mi9d1NZAdllmZYUzfOATGPcrTfESgUttPp5l/fMc=; b=Sf3Exs/8EHtr1pBMIM4odJ118i8iJUJsqeL8JXoHjWUGqYL3e8SFXHo6eYJqlQtqSd hqEctUaNrb9bQ8WPIoYDfN4NQUJWLRMWRLBt9hqyaZhRdd/ctyC4hWPFnQa4N7i7fU1q j5r6ehYEUK/aYSClHndpcVUKp9946QTE4b2MbpWprSlK32IWaDnoa3WO9bpLjB/AI34i uGtWhpXRRao8NHHXG5/GZULXojTcL9wdsJvA6HCccy80VMA6YoaD33MyopHnLLJMwb/M 3AQt7IeCTa3ip3ro0kJYv17hSr1IzFROna/qJdLIelqUThtKe864PRAn8jFaf3mqk/Hz jZHw== X-Received: by 10.224.65.69 with SMTP id h5mr1534233qai.69.1416526985365; Thu, 20 Nov 2014 15:43:05 -0800 (PST) Received: from localhost.localdomain ([187.34.44.229]) by mx.google.com with ESMTPSA id o30sm961607qge.33.2014.11.20.15.43.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Nov 2014 15:43:04 -0800 (PST) From: Gustavo Padovan To: linux-samsung-soc@vger.kernel.org Subject: [PATCH 1/3] drm/exynos: revert fixes for the infinite loop issue Date: Thu, 20 Nov 2014 21:42:54 -0200 Message-Id: <1416526976-9467-2-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1416526976-9467-1-git-send-email-gustavo@padovan.org> References: <1416526976-9467-1-git-send-email-gustavo@padovan.org> Cc: Gustavo Padovan , dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan This reverts commit 06a2f5c2c4e0cb4ff38ca3769ae1f81cc2d030cf and f7c2f36f4395f12d8ecb25c28ee88ec87b457089. These two patches were trying to fix an issue that was causing an infinite loop at the load of the exynos-drm but they were not tackling the source of the problem. A new patch that move the platform driver registration exynos_drm_init() follows this revert and fix the issue properly. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index eab12f0..b94c9d1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -484,12 +484,6 @@ static struct component_match *exynos_drm_match_add(struct device *dev) mutex_lock(&drm_component_lock); - /* Do not retry to probe if there is no any kms driver regitered. */ - if (list_empty(&drm_component_list)) { - mutex_unlock(&drm_component_lock); - return ERR_PTR(-ENODEV); - } - list_for_each_entry(cdev, &drm_component_list, list) { /* * Add components to master only in case that crtc and @@ -674,18 +668,6 @@ static int exynos_drm_init(void) { int ret; - /* - * Register device object only in case of Exynos SoC. - * - * Below codes resolves temporarily infinite loop issue incurred - * by Exynos drm driver when using multi-platform kernel. - * So these codes will be replaced with more generic way later. - */ - if (!of_machine_is_compatible("samsung,exynos3") && - !of_machine_is_compatible("samsung,exynos4") && - !of_machine_is_compatible("samsung,exynos5")) - return -ENODEV; - exynos_drm_pdev = platform_device_register_simple("exynos-drm", -1, NULL, 0); if (IS_ERR(exynos_drm_pdev))