| Message ID | 1417980062-25151-8-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, 07 Dec 2014, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > Replace a misspelled function name by %s and then __func__. > > This was done using Coccinelle, including the use of Levenshtein distance, > as proposed by Rasmus Villemoes. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > The semantic patch is difficult to summarize, but is available in the cover > letter of this patch series. > > The message is sort of ambiguous, but I assume that it is intended to refer > to the function in which the problem is detected. Hmm, DRM_DEBUG prints __func__ too. Jani. > > drivers/gpu/drm/i915/i915_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index d2ba315..fa21d1c 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -4335,7 +4335,7 @@ i915_gem_unpin_ioctl(struct drm_device *dev, void *data, > } > > if (obj->pin_filp != file) { > - DRM_DEBUG("Not pinned by caller in i915_gem_pin_ioctl(): %d\n", > + DRM_DEBUG("Not pinned by caller in %s(): %d\n", __func__, > args->handle); > ret = -EINVAL; > goto out; >
On Mon, Dec 08, 2014 at 12:24:27PM +0200, Jani Nikula wrote: > On Sun, 07 Dec 2014, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > > Replace a misspelled function name by %s and then __func__. > > > > This was done using Coccinelle, including the use of Levenshtein distance, > > as proposed by Rasmus Villemoes. > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > > > --- > > The semantic patch is difficult to summarize, but is available in the cover > > letter of this patch series. > > > > The message is sort of ambiguous, but I assume that it is intended to refer > > to the function in which the problem is detected. > > Hmm, DRM_DEBUG prints __func__ too. We've killed the pin ioctl for 3.20 hence didn't even bother to come up with an opinion ;-) -Daniel
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index d2ba315..fa21d1c 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -4335,7 +4335,7 @@ i915_gem_unpin_ioctl(struct drm_device *dev, void *data, } if (obj->pin_filp != file) { - DRM_DEBUG("Not pinned by caller in i915_gem_pin_ioctl(): %d\n", + DRM_DEBUG("Not pinned by caller in %s(): %d\n", __func__, args->handle); ret = -EINVAL; goto out;
Replace a misspelled function name by %s and then __func__. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- The semantic patch is difficult to summarize, but is available in the cover letter of this patch series. The message is sort of ambiguous, but I assume that it is intended to refer to the function in which the problem is detected. drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)