diff mbox

drm/exynos: hdmi: replace fb size with mode size from win commit

Message ID 1422606645-25491-1-git-send-email-sw0312.kim@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Seung-Woo Kim Jan. 30, 2015, 8:30 a.m. UTC
For default graphic window, mixer_win_commit() sets display size
register as fb size. Calling setplane with smaller fb size than
mode size to default window causes distorted display result. So
this patch replaces fb size with mode size for display size from
the mixer_win_commit().

Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_mixer.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Joonyoung Shim Jan. 30, 2015, 8:36 a.m. UTC | #1
Hi,

On 01/30/2015 05:30 PM, Seung-Woo Kim wrote:
> For default graphic window, mixer_win_commit() sets display size
> register as fb size. Calling setplane with smaller fb size than
> mode size to default window causes distorted display result. So
> this patch replaces fb size with mode size for display size from
> the mixer_win_commit().
> 
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_mixer.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
> index 6766271..086fe0e 100644
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> @@ -584,8 +584,8 @@ static void mixer_graph_buffer(struct mixer_context *ctx, int win)
>  	/* setup display size */
>  	if (ctx->mxr_ver == MXR_VER_128_0_0_184 &&
>  		win == MIXER_DEFAULT_WIN) {
> -		val  = MXR_MXR_RES_HEIGHT(win_data->fb_height);
> -		val |= MXR_MXR_RES_WIDTH(win_data->fb_width);
> +		val  = MXR_MXR_RES_HEIGHT(win_data->mode_height);
> +		val |= MXR_MXR_RES_WIDTH(win_data->mode_width);
>  		mixer_reg_write(res, MXR_RESOLUTION, val);
>  	}
>  
> 

Acked-by: Joonyoung Shim <jy0922.shim@samsung.com>

Thanks.
Inki Dae Feb. 4, 2015, 8:32 a.m. UTC | #2
On 2015? 01? 30? 17:30, Seung-Woo Kim wrote:
> For default graphic window, mixer_win_commit() sets display size
> register as fb size. Calling setplane with smaller fb size than
> mode size to default window causes distorted display result. So
> this patch replaces fb size with mode size for display size from
> the mixer_win_commit().

Applied.

Thanks,
Inki Dae

> 
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_mixer.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
> index 6766271..086fe0e 100644
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> @@ -584,8 +584,8 @@ static void mixer_graph_buffer(struct mixer_context *ctx, int win)
>  	/* setup display size */
>  	if (ctx->mxr_ver == MXR_VER_128_0_0_184 &&
>  		win == MIXER_DEFAULT_WIN) {
> -		val  = MXR_MXR_RES_HEIGHT(win_data->fb_height);
> -		val |= MXR_MXR_RES_WIDTH(win_data->fb_width);
> +		val  = MXR_MXR_RES_HEIGHT(win_data->mode_height);
> +		val |= MXR_MXR_RES_WIDTH(win_data->mode_width);
>  		mixer_reg_write(res, MXR_RESOLUTION, val);
>  	}
>  
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index 6766271..086fe0e 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -584,8 +584,8 @@  static void mixer_graph_buffer(struct mixer_context *ctx, int win)
 	/* setup display size */
 	if (ctx->mxr_ver == MXR_VER_128_0_0_184 &&
 		win == MIXER_DEFAULT_WIN) {
-		val  = MXR_MXR_RES_HEIGHT(win_data->fb_height);
-		val |= MXR_MXR_RES_WIDTH(win_data->fb_width);
+		val  = MXR_MXR_RES_HEIGHT(win_data->mode_height);
+		val |= MXR_MXR_RES_WIDTH(win_data->mode_width);
 		mixer_reg_write(res, MXR_RESOLUTION, val);
 	}