diff mbox

drm: atmel-hlcdc: remove useless pm_runtime_put_sync in probe

Message ID 1423841785-23105-1-git-send-email-boris.brezillon@free-electrons.com (mailing list archive)
State New, archived
Headers show

Commit Message

Boris BREZILLON Feb. 13, 2015, 3:36 p.m. UTC
Remove a useless pm_runtime_put_sync leading to unbalanced
usage_count.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reported-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Sylvain Rochet Feb. 13, 2015, 4:05 p.m. UTC | #1
Hello Boris,

On Fri, Feb 13, 2015 at 04:36:25PM +0100, Boris Brezillon wrote:
> Remove a useless pm_runtime_put_sync leading to unbalanced
> usage_count.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> ---

Indeed, this is actually a necessary fix for my "drm: atmel-hlcdc: PM 
support" series.

Tested-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
Reviewed-by: Sylvain Rochet <sylvain.rochet@finsecur.com>

Sylvain
diff mbox

Patch

diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
index 7320a6c..c1cb174 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
@@ -311,8 +311,6 @@  static int atmel_hlcdc_dc_load(struct drm_device *dev)
 
 	pm_runtime_enable(dev->dev);
 
-	pm_runtime_put_sync(dev->dev);
-
 	ret = atmel_hlcdc_dc_modeset_init(dev);
 	if (ret < 0) {
 		dev_err(dev->dev, "failed to initialize mode setting\n");