| Message ID | 1425902897-13398-1-git-send-email-emil.l.velikov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Mar 9, 2015 at 12:08:16 +0000, Emil Velikov wrote: > By using it, any modifications to configure.ac or the Makefile.am files > won't trigger a rebuild of the makefiles. Drop the switch from the > autogen.sh as well. > Since it was set to enabled in configure.ac, the above is not true, unless you explicitly pass --disable-maintainer-mode to configure. Cheers, Julien
Hi Julien, On 9 March 2015 at 20:28, Julien Cristau <jcristau@debian.org> wrote: > On Mon, Mar 9, 2015 at 12:08:16 +0000, Emil Velikov wrote: > >> By using it, any modifications to configure.ac or the Makefile.am files >> won't trigger a rebuild of the makefiles. Drop the switch from the >> autogen.sh as well. >> > Since it was set to enabled in configure.ac, the above is not true, > unless you explicitly pass --disable-maintainer-mode to configure. > Hmm... you're absolutely correct here. The following commit message should be more appropriate. AM_MAINTAINER_MODE can be used to disable generation of rebuild rules. This is not something we want to condone/support, considering it can cause greater problems than the perceived benefits. Additionally the Automake manual leans towards avoiding the use of AM_MAINTAINER_MODE. http://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html That is unless you're in favour of keeping it ? Afaics at least some X components tend to avoid it. Cheers, Emil
On Tue, Mar 10, 2015 at 16:33:17 +0000, Emil Velikov wrote: > Hi Julien, > On 9 March 2015 at 20:28, Julien Cristau <jcristau@debian.org> wrote: > > On Mon, Mar 9, 2015 at 12:08:16 +0000, Emil Velikov wrote: > > > >> By using it, any modifications to configure.ac or the Makefile.am files > >> won't trigger a rebuild of the makefiles. Drop the switch from the > >> autogen.sh as well. > >> > > Since it was set to enabled in configure.ac, the above is not true, > > unless you explicitly pass --disable-maintainer-mode to configure. > > > Hmm... you're absolutely correct here. The following commit message > should be more appropriate. > > AM_MAINTAINER_MODE can be used to disable generation of rebuild rules. > This is not something we want to condone/support, considering it can > cause greater problems than the perceived benefits. Additionally the > Automake manual leans towards avoiding the use of AM_MAINTAINER_MODE. > > http://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html > > > That is unless you're in favour of keeping it ? Afaics at least some X > components tend to avoid it. > I don't really care whether it stays or goes, but your new commit message looks good to me :) Cheers, Julien
On 10 March 2015 at 16:41, Julien Cristau <jcristau@debian.org> wrote: > On Tue, Mar 10, 2015 at 16:33:17 +0000, Emil Velikov wrote: > >> Hi Julien, >> On 9 March 2015 at 20:28, Julien Cristau <jcristau@debian.org> wrote: >> > On Mon, Mar 9, 2015 at 12:08:16 +0000, Emil Velikov wrote: >> > >> >> By using it, any modifications to configure.ac or the Makefile.am files >> >> won't trigger a rebuild of the makefiles. Drop the switch from the >> >> autogen.sh as well. >> >> >> > Since it was set to enabled in configure.ac, the above is not true, >> > unless you explicitly pass --disable-maintainer-mode to configure. >> > >> Hmm... you're absolutely correct here. The following commit message >> should be more appropriate. >> >> AM_MAINTAINER_MODE can be used to disable generation of rebuild rules. >> This is not something we want to condone/support, considering it can >> cause greater problems than the perceived benefits. Additionally the >> Automake manual leans towards avoiding the use of AM_MAINTAINER_MODE. >> >> http://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html >> >> >> That is unless you're in favour of keeping it ? Afaics at least some X >> components tend to avoid it. >> > I don't really care whether it stays or goes, but your new commit > message looks good to me :) > Ack. Thanks for spotting that silly mistake. -Emil
diff --git a/autogen.sh b/autogen.sh index 3f190ba..30d679f 100755 --- a/autogen.sh +++ b/autogen.sh @@ -3,4 +3,4 @@ test -n "$srcdir" || srcdir=`dirname "$0"` test -n "$srcdir" || srcdir=. autoreconf --force --install --verbose "$srcdir" -test -n "$NOCONFIGURE" || "$srcdir/configure" --enable-maintainer-mode "$@" +test -n "$NOCONFIGURE" || "$srcdir/configure" "$@" diff --git a/configure.ac b/configure.ac index 8afee83..00685fd 100644 --- a/configure.ac +++ b/configure.ac @@ -30,7 +30,6 @@ AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_AUX_DIR([build-aux]) AM_INIT_AUTOMAKE([1.10 foreign dist-bzip2]) -AM_MAINTAINER_MODE([enable]) # Enable quiet compiles on automake 1.11. m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
By using it, any modifications to configure.ac or the Makefile.am files won't trigger a rebuild of the makefiles. Drop the switch from the autogen.sh as well. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- autogen.sh | 2 +- configure.ac | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)