From patchwork Wed Apr 1 04:14:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyungwon Hwang X-Patchwork-Id: 6137421 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 85588BF4A6 for ; Wed, 1 Apr 2015 04:15:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 74BE020125 for ; Wed, 1 Apr 2015 04:15:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 41E3A2010F for ; Wed, 1 Apr 2015 04:15:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 484A96E7C6; Tue, 31 Mar 2015 21:15:09 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 2748D6E7C6 for ; Tue, 31 Mar 2015 21:15:06 -0700 (PDT) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NM400KXP151AXC0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 01 Apr 2015 13:15:01 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.113]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id B8.4B.11124.5C07B155; Wed, 1 Apr 2015 13:15:01 +0900 (KST) X-AuditID: cbfee68e-f79b46d000002b74-c6-551b70c5adf1 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 58.DE.20081.5C07B155; Wed, 1 Apr 2015 13:15:01 +0900 (KST) Received: from localhost.localdomain ([10.252.82.145]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NM4004FV14YOKB0@mmp2.samsung.com>; Wed, 01 Apr 2015 13:15:01 +0900 (KST) From: Hyungwon Hwang To: dri-devel@lists.freedesktop.org, inki.dae@samsung.com Subject: [PATCH] drm/exynos: fimd: check whether exynos_drm_crtc_create succeed or not Date: Wed, 01 Apr 2015 13:14:56 +0900 Message-id: <1427861696-4961-1-git-send-email-human.hwang@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHLMWRmVeSWpSXmKPExsWyRsSkUPdogXSowYd2ZYvrX56zWlz5+p7N YumMPlaLSfcnsFi8uHeRxWLG5JdsDmwe97uPM3n0bVnFGMAUxWWTkpqTWZZapG+XwJXxuOUv W8F29oqmWefZGhhXsXUxcnJICJhILP/XwgRhi0lcuLceLC4ksJRRYvUNlS5GDrCaVVdtuxi5 gMLTGSW+r2hlgnB+MEpMnToLrJlNQE9iwbUf7CC2iIClxIOtv5lBmpkFyiRaz2WAhIUFIiSW /ekCm88ioCrRv2sFC4jNK+Amser2Tagb5CROHpvMCjJfQuA5m8Slne+ZIRoEJL5NPsQCcZCs xKYDzBD1khIHV9xgmcAouICRYRWjaGpBckFxUnqRkV5xYm5xaV66XnJ+7iZGYDCe/vesbwfj zQPWhxgFOBiVeHg1IqRDhVgTy4orcw8xmgJtmMgsJZqcDwz5vJJ4Q2MzIwtTE1NjI3NLMyVx 3gSpn8FCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGGP77n1ruJOb7ntSQ3e1v2T77MgLjyQm nyrR+vVD4vptrisl91cJl1aKOfke3FZu7VEiGJ3b2fd2t8P/vXfT19u5dy/0FbZZwTdN8cLU mogN/HwvWBzvxV6+cXvPwaRDslsznJpamiScZqv9jHpdrp9bLBDt/fGWvPbbh/9q3HZOvhdm LCC1UYmlOCPRUIu5qDgRAFoyFLVBAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRmVeSWpSXmKPExsVy+t9jQd2jBdKhBuf+S1lc//Kc1eLK1/ds Fktn9LFaTLo/gcXixb2LLBYzJr9kc2DzuN99nMmjb8sqxgCmqAZGm4zUxJTUIoXUvOT8lMy8 dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygpUoKZYk5pUChgMTiYiV9O0wTQkPc dC1gGiN0fUOC4HqMDNBAwhrGjMctf9kKtrNXNM06z9bAuIqti5GDQ0LARGLVVdsuRk4gU0zi wr31QGEuDiGB6YwS31e0MkE4Pxglpk6dxQRSxSagJ7Hg2g92EFtEwFLiwdbfzCCDmAXKJFrP ZYCEhQUiJJb96WIDsVkEVCX6d61gAbF5BdwkVt2+yQSxTE7i5LHJrBMYuRcwMqxiFE0tSC4o TkrPNdQrTswtLs1L10vOz93ECA72Z1I7GFc2WBxiFOBgVOLhbYiSDhViTSwrrsw9xCjBwawk wrv9iFSoEG9KYmVValF+fFFpTmrxIUZToO0TmaVEk/OBkZhXEm9obGJmZGlkbmhhZGyuJM6r ZN8WIiSQnliSmp2aWpBaBNPHxMEp1cAoI6jSl8N4JShsavCLi/db617eWRXK/GyHoqWPiIV5 h2hTx59Yz52zzpSfzygJOT733A6bvfdLzkm8fmPE27Rmr7Njd3T/45/xXxfZXT99ePnpHuH3 7JxPSh1/HbuXXnR0nWDYFM3+KX8M5Zapbu5qVMu+emfmfI1zxbJqJhIP17uxWmt1mKUrsRRn JBpqMRcVJwIAiM+GwowCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: cw00.choi@samsung.com, sw0312.kim@samsung.com, Hyungwon Hwang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From the commit "drm/exynos: fix the execution order in FIMD initialization" (598285bfdce46d7c47632a2ba4b980f60be4a677), the error checking code is removed improperly. This patch fix the regression. Signed-off-by: Hyungwon Hwang --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 31dfa80..15cee94 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -1060,6 +1060,8 @@ static int fimd_bind(struct device *dev, struct device *master, void *data) ctx->crtc = exynos_drm_crtc_create(drm_dev, ctx->pipe, EXYNOS_DISPLAY_TYPE_LCD, &fimd_crtc_ops, ctx); + if (IS_ERR(ctx->crtc)) + return PTR_ERR(ctx->crtc); if (ctx->display) exynos_drm_create_enc_conn(drm_dev, ctx->display);