From patchwork Thu Apr 2 09:52:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyungwon Hwang X-Patchwork-Id: 6146001 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E9C5FBF4A6 for ; Thu, 2 Apr 2015 09:52:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2840D20266 for ; Thu, 2 Apr 2015 09:52:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id D06DF20263 for ; Thu, 2 Apr 2015 09:52:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5A706E9C3; Thu, 2 Apr 2015 02:52:28 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D65F6E9C3 for ; Thu, 2 Apr 2015 02:52:27 -0700 (PDT) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NM6005X5BFDRD40@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 02 Apr 2015 18:52:25 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.115]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 52.64.18167.9511D155; Thu, 2 Apr 2015 18:52:25 +0900 (KST) X-AuditID: cbfee690-f79ab6d0000046f7-28-551d115991ba Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 22.49.09430.9511D155; Thu, 2 Apr 2015 18:52:25 +0900 (KST) Received: from localhost.localdomain ([10.252.82.145]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NM6003ZBBFAOX10@mmp2.samsung.com>; Thu, 02 Apr 2015 18:52:25 +0900 (KST) From: Hyungwon Hwang To: dri-devel@lists.freedesktop.org, inki.dae@samsung.com Subject: [PATCH] drm/exynos: dsi: remove the empty mode_valid callback Date: Thu, 02 Apr 2015 18:52:20 +0900 Message-id: <1427968340-14879-1-git-send-email-human.hwang@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHLMWRmVeSWpSXmKPExsWyRsSkWDdSUDbUYPdKEYvrX56zWlz5+p7N YumMPlaLSfcnsFi8uHeRxWLG5JdsDmwe97uPM3n0bVnFGMAUxWWTkpqTWZZapG+XwJVxZ+s2 1oL9nBXN53cxNzC2cXQxcnJICJhITFp7nBXCFpO4cG89WxcjF4eQwFJGiVfXTgM5HGBFS75r QcSnM0qsadjDCuH8YJRoeHmGGaSbTUBPYsG1H+wgtoiApcSDrb+ZQZqZBcokWs9lgISFBdwk un6eZwIJswioSnx+aQsS5hVwlzjWshPqBjmJk8cmg42XEHjOJrHjzUmwkSwCAhLfJh9igbhH VmLTAWaIekmJgytusExgFFzAyLCKUTS1ILmgOCm9yESvODG3uDQvXS85P3cTIzAYT/97NmEH 470D1ocYBTgYlXh4M/bIhAqxJpYVV+YeYjQF2jCRWUo0OR8Y8nkl8YbGZkYWpiamxkbmlmZK 4ryvpX4GCwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamBMrk1/+NW96+HGZu0WldrT715Pe/E2 R+RR49c1LuJtynW/wnZpcAi+Wdt2LKjQOEzWKjzF1IZvsWSnnXTDtFKH9rBQxmMJpSnVOv4b Pod8Ys49n7corf5XS+XTstzda2L3WCcYv9YWkFbwC5HK+uTr47ZeuuRmudPCkoMLf85c57RE uLQiSImlOCPRUIu5qDgRAPiFcV5BAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRmVeSWpSXmKPExsVy+t9jQd1IQdlQgx/HeCyuf3nOanHl63s2 i6Uz+lgtJt2fwGLx4t5FFosZk1+yObB53O8+zuTRt2UVYwBTVAOjTUZqYkpqkUJqXnJ+SmZe uq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QUiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYQ1jxp2t21gL9nNWNJ/fxdzA2MbRxcjBISFgIrHku1YXIyeQKSZx 4d56ti5GLg4hgemMEmsa9rBCOD8YJRpenmEGqWIT0JNYcO0HO4gtImAp8WDrb2aQQcwCZRKt 5zJAwsICbhJdP88zgYRZBFQlPr+0BQnzCrhLHGvZyQqxS07i5LHJrBMYuRcwMqxiFE0tSC4o TkrPNdIrTswtLs1L10vOz93ECA71Z9I7GFc1WBxiFOBgVOLhzdgjEyrEmlhWXJl7iFGCg1lJ hPc0h2yoEG9KYmVValF+fFFpTmrxIUZToOUTmaVEk/OBcZhXEm9obGJmZGlkbmhhZGyuJM6r ZN8WIiSQnliSmp2aWpBaBNPHxMEp1cAYWnSocfrd5/of5tmy3ps6nfmuxp3NwlNvaD1dvLlr p/Akx49rHF0WNphaCoo4Bcx+F1O/dvWmTKbU3Z4GjToLry24kqmy8vzXgKu/67IZDnQ/5fbn SwtjONOev1dLfeI0/ju179W2/Xu+Wo0va+aKv6XlB42q4libVhnLSDXu+jYxoKJfRa5CiaU4 I9FQi7moOBEARcmNCYsCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: cw00.choi@samsung.com, sw0312.kim@samsung.com, Hyungwon Hwang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Because the helper function which calls this callback checks whether it is registered or not. It is not necessary if it does nothing. So it would be better to remove the function for clarity. Signed-off-by: Hyungwon Hwang Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 05fe93d..0492715 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1473,12 +1473,6 @@ static int exynos_dsi_get_modes(struct drm_connector *connector) return 0; } -static int exynos_dsi_mode_valid(struct drm_connector *connector, - struct drm_display_mode *mode) -{ - return MODE_OK; -} - static struct drm_encoder * exynos_dsi_best_encoder(struct drm_connector *connector) { @@ -1489,7 +1483,6 @@ exynos_dsi_best_encoder(struct drm_connector *connector) static struct drm_connector_helper_funcs exynos_dsi_connector_helper_funcs = { .get_modes = exynos_dsi_get_modes, - .mode_valid = exynos_dsi_mode_valid, .best_encoder = exynos_dsi_best_encoder, };