diff mbox

[RFC,010/111] staging: etnaviv: fix etnaviv gpu debugfs output

Message ID 1427988653-754-11-git-send-email-l.stach@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Lucas Stach April 2, 2015, 3:29 p.m. UTC 
From: Russell King <rmk+kernel@arm.linux.org.uk>

"0x08%x" is a confusing format.  It prints values prefixed with 0x08
irrespective of their values, which leads you to think that 0x08fe
really is 0x08fe.  Fix the format string to place the % correctly.

Reverse the 64-bit values - even though the GPU wants 64-bit alignment
in the command stream, and sees the stream as 64-bit values, it's more
humanly understandable to print them as separate 32-bit values in
"lo hi" format - the order that they appear in the command stream.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/staging/etnaviv/etnaviv_gpu.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/drivers/staging/etnaviv/etnaviv_gpu.c b/drivers/staging/etnaviv/etnaviv_gpu.c
index 56afba7625ed..df5bef16ff4c 100644
--- a/drivers/staging/etnaviv/etnaviv_gpu.c
+++ b/drivers/staging/etnaviv/etnaviv_gpu.c
@@ -436,8 +436,8 @@  void etnaviv_gpu_debugfs(struct etnaviv_gpu *gpu, struct seq_file *m)
 
 	verify_dma(gpu, &debug);
 
-	seq_printf(m, "\taxi: 0x08%x\n", axi);
-	seq_printf(m, "\tidle: 0x08%x\n", idle);
+	seq_printf(m, "\taxi: 0x%08x\n", axi);
+	seq_printf(m, "\tidle: 0x%08x\n", idle);
 	if ((idle & VIVS_HI_IDLE_STATE_FE) == 0)
 		seq_puts(m, "\t FE is not idle\n");
 	if ((idle & VIVS_HI_IDLE_STATE_DE) == 0)
@@ -491,7 +491,8 @@  void etnaviv_gpu_debugfs(struct etnaviv_gpu *gpu, struct seq_file *m)
 	seq_printf(m, "\t address 1: 0x%08x\n", debug.address[1]);
 	seq_printf(m, "\t state 0: 0x%08x\n", debug.state[0]);
 	seq_printf(m, "\t state 1: 0x%08x\n", debug.state[1]);
-	seq_printf(m, "\t last fetch 64 bit word: 0x%08x-0x%08x\n", dma_hi, dma_lo);
+	seq_printf(m, "\t last fetch 64 bit word: 0x%08x 0x%08x\n",
+		   dma_lo, dma_hi);
 }
 #endif