diff mbox

[libdrm] xf86drm: remove makedev() hack/workaround

Message ID 1438965588-6231-1-git-send-email-emil.l.velikov@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Emil Velikov Aug. 7, 2015, 4:39 p.m. UTC
Back when this was introduced commit 569da5a42eb(Merged glxmisc-3-0-0)
sys/sysmacros.h was used instead of the respecive headers (as per the
manual).

We've been handling it correctly for a little while now - in Linux, BSD
and Solaris. Thus we can drop this workaround.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
---
 xf86drm.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Emil Velikov Sept. 7, 2015, 9:53 a.m. UTC | #1
On 7 August 2015 at 17:39, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> Back when this was introduced commit 569da5a42eb(Merged glxmisc-3-0-0)
> sys/sysmacros.h was used instead of the respecive headers (as per the
> manual).
>
> We've been handling it correctly for a little while now - in Linux, BSD
> and Solaris. Thus we can drop this workaround.
>
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
>  xf86drm.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/xf86drm.c b/xf86drm.c
> index 5e02969..7e41537 100644
> --- a/xf86drm.c
> +++ b/xf86drm.c
> @@ -94,14 +94,6 @@
>  #define DRM_MAJOR 226          /* Linux */
>  #endif
>
> -/*
> - * This definition needs to be changed on some systems if dev_t is a structure.
> - * If there is a header file we can get it from, there would be best.
> - */
> -#ifndef makedev
> -#define makedev(x,y)    ((dev_t)(((x) << 8) | (y)))
> -#endif
> -
>  #define DRM_MSG_VERBOSITY 3
>
>  #define memclear(s) memset(&s, 0, sizeof(s))
> --
> 2.5.0
>
Humble ping anyone ?

-Emil
diff mbox

Patch

diff --git a/xf86drm.c b/xf86drm.c
index 5e02969..7e41537 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -94,14 +94,6 @@ 
 #define DRM_MAJOR 226		/* Linux */
 #endif
 
-/*
- * This definition needs to be changed on some systems if dev_t is a structure.
- * If there is a header file we can get it from, there would be best.
- */
-#ifndef makedev
-#define makedev(x,y)    ((dev_t)(((x) << 8) | (y)))
-#endif
-
 #define DRM_MSG_VERBOSITY 3
 
 #define memclear(s) memset(&s, 0, sizeof(s))