diff mbox

[v2,1/2] drm/panel: simple: Add bus format for HannStar HSD070PWW1 LVDS panel

Message ID 1439375533-28718-1-git-send-email-l.stach@pengutronix.de (mailing list archive)
State Accepted
Headers show

Commit Message

Lucas Stach Aug. 12, 2015, 10:32 a.m. UTC
From: Philipp Zabel <p.zabel@pengutronix.de>

The bus format both specifies the bpc and the way the individual bits get
serialized into the 7 LVDS timeslots.

While the is only one standard mapping for 6 bpc and so the driver could
infer the bit mapping from the bpc alone, there are more options for the
8 bpc case which makes specifiying the bus format mandatory.
To keep things consistent across panels and to set a precedent for new
panel additions add the proper bus format.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
v2: lst: added more elaborate commit message
---
 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thierry Reding Aug. 13, 2015, 12:14 p.m. UTC | #1
On Wed, Aug 12, 2015 at 12:32:12PM +0200, Lucas Stach wrote:
> From: Philipp Zabel <p.zabel@pengutronix.de>
> 
> The bus format both specifies the bpc and the way the individual bits get
> serialized into the 7 LVDS timeslots.
> 
> While the is only one standard mapping for 6 bpc and so the driver could
> infer the bit mapping from the bpc alone, there are more options for the
> 8 bpc case which makes specifiying the bus format mandatory.
> To keep things consistent across panels and to set a precedent for new
> panel additions add the proper bus format.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2: lst: added more elaborate commit message
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 1 +
>  1 file changed, 1 insertion(+)

Both patches applied, thanks.

Thierry
diff mbox

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index f94201b6e882..a1cd431e17a6 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -729,6 +729,7 @@  static const struct panel_desc hannstar_hsd070pww1 = {
 		.width = 151,
 		.height = 94,
 	},
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
 };
 
 static const struct display_timing hannstar_hsd100pxn1_timing = {