From patchwork Thu Oct 8 14:10:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 7353041 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5BF109F4DC for ; Thu, 8 Oct 2015 14:10:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7B65D20822 for ; Thu, 8 Oct 2015 14:10:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 1585E20810 for ; Thu, 8 Oct 2015 14:10:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D5586ED00; Thu, 8 Oct 2015 07:10:34 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qg0-f48.google.com (mail-qg0-f48.google.com [209.85.192.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 242006ED00 for ; Thu, 8 Oct 2015 07:10:33 -0700 (PDT) Received: by qgt47 with SMTP id 47so42661940qgt.2 for ; Thu, 08 Oct 2015 07:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=HgfjtD7uozk59BtkoH30qydAJad9njROKlvQnx052jc=; b=ioimFAt3o1qBC6wxW4onqswbMVKYAMMDmMPsr/7v3fYxgyzNgCvgxfy7il4ikpiixa fkCxP/pbTuVNDDtfKKcMXKDtP5/KLVxL/+vNGN5CUSyqJsSQOssroMemmGQS711SMwBW YjypPI4osxQnQo64xOG8FQ2a7AXixE49lVVsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HgfjtD7uozk59BtkoH30qydAJad9njROKlvQnx052jc=; b=HaJkqfyFAvZqLMakzHNeROhWrxgOfnprJinMhED3sNsd0Xq/yX8VA7fNMwpUvR4rgU iq+6p/T7bois/s8H5N+I1KkKRjncM8RUz9Ips7vpjSIXSjzceLxgxHzi4UO+tMRmoXn6 2chK+A8NCNq72g+fkiU15H+6/pXv+qSvTCkxSK1LJkIAiym2n97eSWi0Qunm2FSHDPx4 lR3iK46lIXUf9MOca8LeKF2mqy/xHdCdN5GK80Meet8uw6sFPXhWwXGd5mNcJ10v7i8a aL+hfRlwCJDcdp2fPkPR6/Gt0G9VFo7M/Eay+d7HZg4c3X+UJBDVEIXZozAdT2kgY37A lWWQ== X-Gm-Message-State: ALoCoQnrKmi0Rk9LPxfuSp/SrT9bA+RCL0TvnRM1ndAIULq8ywCWVnO7haT+VeGWIYMdiptY3xMk X-Received: by 10.140.131.70 with SMTP id 67mr9204219qhd.70.1444313432237; Thu, 08 Oct 2015 07:10:32 -0700 (PDT) Received: from billyjoel.roam.corp.google.com (cpe-75-189-128-87.nc.res.rr.com. [75.189.128.87]) by smtp.gmail.com with ESMTPSA id r38sm16559004qkr.29.2015.10.08.07.10.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 08 Oct 2015 07:10:31 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, airlied@linux.ie Subject: [PATCH] drm: Correct arguments to list_tail_add in create blob ioctl Date: Thu, 8 Oct 2015 10:10:24 -0400 Message-Id: <1444313424-31988-1-git-send-email-seanpaul@chromium.org> X-Mailer: git-send-email 2.6.0.rc2.230.g3dd15c0 Cc: daniels@collabora.com, mmaneetsingh@nvidia.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Maneet Singh From: Maneet Singh Arguments passed to list_add_tail were reversed resulting in deletion of old blob property everytime the new one is added. Signed-off-by: Maneet Singh [seanpaul tweaked commit subject a little] Signed-off-by: Sean Paul Reviewed-by: Daniel Stone Reviewed-by: Jani Nikula --- drivers/gpu/drm/drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index e600a5f..049c7b7 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -4454,7 +4454,7 @@ int drm_mode_createblob_ioctl(struct drm_device *dev, * not associated with any file_priv. */ mutex_lock(&dev->mode_config.blob_lock); out_resp->blob_id = blob->base.id; - list_add_tail(&file_priv->blobs, &blob->head_file); + list_add_tail(&blob->head_file, &file_priv->blobs); mutex_unlock(&dev->mode_config.blob_lock); return 0;