From patchwork Mon Dec 7 18:55:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harry Wentland X-Patchwork-Id: 7789281 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 58DDB9F54E for ; Mon, 7 Dec 2015 19:11:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 82FE0203B7 for ; Mon, 7 Dec 2015 19:11:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DAA522055C for ; Mon, 7 Dec 2015 19:11:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1F5C6E6EC; Mon, 7 Dec 2015 11:11:28 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 912 seconds by postgrey-1.34 at gabe; Mon, 07 Dec 2015 11:11:26 PST Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0099.outbound.protection.outlook.com [207.46.100.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C7776E6EB for ; Mon, 7 Dec 2015 11:11:26 -0800 (PST) Received: from CY1PR12CA0044.namprd12.prod.outlook.com (10.163.230.12) by BLUPR12MB0706.namprd12.prod.outlook.com (10.163.218.144) with Microsoft SMTP Server (TLS) id 15.1.337.19; Mon, 7 Dec 2015 18:56:10 +0000 Received: from BY2NAM03FT004.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e4a::204) by CY1PR12CA0044.outlook.office365.com (2a01:111:e400:c42b::12) with Microsoft SMTP Server (TLS) id 15.1.337.19 via Frontend Transport; Mon, 7 Dec 2015 18:56:10 +0000 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=permerror action=none header.from=amd.com; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from atltwp01.amd.com (165.204.84.221) by BY2NAM03FT004.mail.protection.outlook.com (10.152.84.66) with Microsoft SMTP Server id 15.1.346.13 via Frontend Transport; Mon, 7 Dec 2015 18:56:10 +0000 X-WSS-ID: 0NZ04LL-07-1CW-02 X-M-MSG: Received: from satlvexedge02.amd.com (satlvexedge02.amd.com [10.177.96.29]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by atltwp01.amd.com (Axway MailGate 5.3.1) with ESMTPS id 240A0CAF33F for ; Mon, 7 Dec 2015 13:56:09 -0500 (EST) Received: from SATLEXDAG01.amd.com (10.181.40.3) by SATLVEXEDGE02.amd.com (10.177.96.29) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 7 Dec 2015 12:56:28 -0600 Received: from STOREXDAG02.amd.com (10.1.13.11) by SATLEXDAG01.amd.com (10.181.40.3) with Microsoft SMTP Server (TLS) id 14.3.266.1; Mon, 7 Dec 2015 13:56:08 -0500 Received: from cnhwentlanub.amd.com (172.29.225.36) by storexdag02.amd.com (10.1.13.11) with Microsoft SMTP Server id 14.3.266.1; Mon, 7 Dec 2015 13:56:07 -0500 From: Harry Wentland To: Subject: [PATCH 1/2] drm/dp/mst: reply with ACK for UP reqs Date: Mon, 7 Dec 2015 13:55:51 -0500 Message-ID: <1449514552-10236-2-git-send-email-harry.wentland@amd.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1449514552-10236-1-git-send-email-harry.wentland@amd.com> References: <1449514552-10236-1-git-send-email-harry.wentland@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(428002)(189002)(199003)(87936001)(77096005)(5008740100001)(33646002)(2950100001)(5003600100002)(575784001)(450100001)(101416001)(189998001)(36756003)(229853001)(2351001)(50226001)(48376002)(50466002)(1220700001)(105586002)(97736004)(92566002)(110136002)(86362001)(19580405001)(19580395003)(586003)(106466001)(53416004)(76176999)(50986999)(5003940100001)(47776003)(11100500001)(1096002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR12MB0706; H:atltwp01.amd.com; FPR:; SPF:None; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BLUPR12MB0706; 2:pEVZzm5r+3DIxWOzCV4B46rfJ1S8St/X4yXgAFs63q7AMolUX6E2RXEgc5XmaGxpdbm1jjQmkicN0STYHPQJeP3ZBPXcsLVNb8/zTse442OMy5TIoZTvkJrYd8p6ORgVRD2/fS8zOOuyaNMr2aYaWg==; 3:x5LVzd7dfIvSxgO4i+HSuRgtr2snoY61D3t4KWNYmqFGVzGh0eyw6w1tJy6bfVTQOL3ObWoc/3u3xrcLQiW9+GCHakJbtq3Olq8RArg7KgDXWhS3BSXCiPuMONpGd+nOUsZ4wxYY6ICnmUmsyqIgrOr3S+trLnz4+NmzKohW/I3/uH8rXQGyTad66cole/xG9XfrHXNCKYGTjmfo0I4ISBhe2SzY9aznuogb97hx6iE=; 25:nJLGk9uEsqFfobujTxSxPcNB4WShvSv2n0uu7bV71qZntOm8H2fTiDgaaaDJ5PIvYR5vmMVovzCZksp7IF1+RGXAYPpW+QC65pDmvnIpIpinOW/+yVXAr2QGGAc85lvyQE2Lt2BTWx5Cp3M/oDmOq6yuzbx9LNDb/dAZhEhWZIubKyv66aBFw5viriSUwWv8hxcQ/pCtKJn7EsFjz/cUKwJ4ZPvxDm4jHt/zHDjSuXksu5lcxfVC6j2fQXfLd2MWXhvq1/1U8ywcVy68V/mitQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0706; X-Microsoft-Exchange-Diagnostics: 1; BLUPR12MB0706; 20:akqUKG2Qf/7FujqzYkp8g6aKH+PGnOqYDxfi8qozMGb1/xKrpUfW1OgTdyj3KdcB7AwmcSsPLG5N1R3CAlW8wMsh/7csRf1vK5+uMEbjGioSIhPkZKtoWsZhREfsQUm7i+Za0tQpwaL1wk3LHFuKdvyPfy5ojmjvqEtWywLfD50a2jNG/KsqHKiJeoKGIdHD06STXuVNhu1c3TvQ7SInMm6RWA5HVszHMls0VNvAR2gSmYYE94327+k7QQ8+0V51MIhFzYRL2j5KD5U2pZZYAirM5SEr2DqWJv71UlDnIUV74k2e2WCiJx9D4dUxvp60G2SlZQHykngavMNrlj6NemmZozGeWNTV+NAozdh/7ZOoDUR1T1WTw/s6foMcJaUx16cocFyx5YQn2x0PgyJrNOgBqlSeGRvbwCCwt8KvdHmLZmg1KUd0PL2XOV4WpwzEsKdg8j0MY6NTGcqzSA/pw+KC0PHaOheH7tOwptILwqLR2rOc1C2eSze2lIjK8gAx; 4:ejwmLZJtbutsoAjb9sIwesftxvEwZJ7oRxCmm9rRr/6pRZXfd9MMjDh+bkQpzj8bdmxx5SFxCGksGnmnWrYawOSM3Kj457EQFP0RzwmtnC+r1vaXnv991qu6zdwTzPQr5rAoX0LwH/74V+DndFtWhiZqM/qXAvA+txvRVcfn/lSp/nAJULSJt5jTwxmadM6HHVoUT13M1+yhxT2nZGa8MrD/7r10BQm6B2jbmL7aAPMz0Tye8lNYh4Jc0bxW1fK0nPL0sOnOpGytscaWq7h+rmBCzju0hW0dC8D/2GKUg2cy1baKvpIQa5W3yMPVZ6HXQNNGQjsqWdLtMNjBHN5bDR0Bvrd6lC6ljTrd2y5ZhAB8s009gXVvD9SZXRIBxBJyi9CT80Vott4GmKXG5IVCJRzVrRNohhuC/PKFXN9eDV4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046); SRVR:BLUPR12MB0706; BCL:0; PCL:0; RULEID:; SRVR:BLUPR12MB0706; X-Forefront-PRVS: 078310077C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR12MB0706; 23:PgPj+LrHDeKizFdh+agDUhKuCUBUzhKPAWddF4iEY?= =?us-ascii?Q?x0BJjhFC8Lq2s8TDgR+kwq9IyxYeYBmDbjgO8uzFWTOPMx5nXiPcdfwfBqQq?= =?us-ascii?Q?/j4JvpHBp+w525vWlBErTVqM7U/LximM66sDVf/EiS5vsjLnVG+MGQmGdUFb?= =?us-ascii?Q?29nwQd3y4/m/PpFBRNL+F/pIt88HZpv/20Dw7ZgKaXTFz1uz7xNB/WLgEsMe?= =?us-ascii?Q?pyuSPArweLxUiVmPz0OhcPxbhF0CPq9D+6UVPobsd72CofuH/1AqJH+NAQjX?= =?us-ascii?Q?655njfCZSZBs717CPePtpqkOYSsce9w2YX02MEalSg1oedRNzLsGs+ERbN6w?= =?us-ascii?Q?LNkUB7NHnA7J5Ge1aGbflvuxvFfvkUWTP1X3/Efz57S0iu0FpQNp/atAu0wu?= =?us-ascii?Q?/1l9Y6wNS2PhR0H5WhrKtP2JmWcXJXTLlolmTRVwR3UNFec90pUkfu+OWTx2?= =?us-ascii?Q?0ZnEEc4wtnN/3sycrIt3TOXyGRGokc1lFG71VK7CsjQNS2gi3ppuJpJFJUDM?= =?us-ascii?Q?RAntS3ofzEneIcMHYayHJxz+owfbnhdnKy9Hm3rMEUY6E/nsfTIg4Os2WmzP?= =?us-ascii?Q?C/tpXsmZpZOtBDT9Lfi0HqWUNdoxYm0XTmGznAIKQG3ViaT91EPoxuTko43B?= =?us-ascii?Q?6gSoIt+5XrqipzQGwRwVxr971juLNRS9qy3UB2Zrqt4poAMCrQP3dXat+bBZ?= =?us-ascii?Q?qey35wQTrVCfarOd5WMJ5mpRiRysyPM1nkTNpBI5uTFwOzFmzvBxzT+8/EaO?= =?us-ascii?Q?Gg/xAXMYvO857Y79jxND+jVOmFJn71TaJL1VokXIH1IKewxmEXACx9VT+9HY?= =?us-ascii?Q?OILGZ4gDHLH1L1wfYVJEjcR3hRd/dmIUCV4QoSshV+f/KbE/F9Z/DocNS3S2?= =?us-ascii?Q?Mt9pQ+fmTTPOGQtNq9ZHhZWp2vIatj9MB3pJibzL2ZOyn+B2v02eUrMPPjJa?= =?us-ascii?Q?nllM1xR9Q9NGGUAiq4c+twRiD3oBFA+lO6zb3aUDwfzu57pDgO0FSct8KbAW?= =?us-ascii?Q?m741lPU1w5V9srkIa8z530imaDIoz1u9mdvixFTsLmmTg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR12MB0706; 5:NCrKVubjOJ8rWMDBxAttK07dis0gxO/qdO7M60NQidkJE6Ck9WD6IZRveSlYAJPkn3rLsb+kfB4Vlk3+xDltKnVN1x1t/YOIfEJGBFdUS1swG1KDPXdAdPNcvDfEKaHNMsifBxM5lCr66AAanOB4CQ==; 24:PNcvlPVSedhG8mNx4/dxtse++ctnD1xlD3YCrpJMozyCzz/sgLGxMJm4+BENzbYojPqqa9l69QOiF5bAcqzbFPtfxBML2NIc8+HHEVzsxDE=; 20:ZbJd9ACQ+UU6MN+7sDSAwqfYaoOnkCzVhkmD1bdn7f51Ml3ze63seOvIAwkpB+naEyP/M2BwcJ3FjmdI+vC2ebxZSG0f1FOf+VenBYZbOPCVDycL9d653A8wOP3qtA0QmyOb5yBxhreU1MwCXPbavrWZaxQbn3w0EswOCeODXA2WqmbY33zd1Nk0FCp7RG1SSWutBgEEPSjr7IaI997CjC6uKX/nCqa82d+l6F7H06fEDybH2OG7G5eJntW9zKy+ SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2015 18:56:10.0904 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.221]; Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0706 Cc: Mykola Lysenko X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAD_ENC_HEADER,BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Mykola Lysenko Currently we reply with NACK to UP requests which might confuse receivers. We haven't seen any actual issues with this but should still respond to UP requests correctly. Signed-off-by: Mykola Lysenko --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 809959d56d78..64a0a3729643 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -1823,7 +1823,7 @@ static int drm_dp_encode_up_ack_reply(struct drm_dp_sideband_msg_tx *msg, u8 req { struct drm_dp_sideband_msg_reply_body reply; - reply.reply_type = 1; + reply.reply_type = 0; reply.req_type = req_type; drm_dp_encode_sideband_reply(&reply, msg); return 0;