| Message ID | 1450467477-30870-1-git-send-email-stefan@agner.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Stefan, On 18 December 2015 at 19:37, Stefan Agner <stefan@agner.ch> wrote: > From: Stefan Agner <stefan.agner@toradex.com> > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > tests/kmstest/main.c | 1 + > tests/modetest/modetest.c | 2 +- > tests/proptest/proptest.c | 2 +- > tests/vbltest/vbltest.c | 2 +- > 4 files changed, 4 insertions(+), 3 deletions(-) > I've pushed a series (where this patch will conflict) around the same time you sent this. Please can take a look at tests/util/kms.c... although kmstest, (even modeprint and others) could be updated to use the new helper. Although I'd really love if one updates the drm*Device API to handle platform devices. I've been looking for volunteers, although most platform people tend to say low :-P Feel free to skim through tests/drmdevice.c or let me know if something feels amiss. Thanks Emil
On 2015-12-19 08:49, Emil Velikov wrote: > Hi Stefan, > > On 18 December 2015 at 19:37, Stefan Agner <stefan@agner.ch> wrote: >> From: Stefan Agner <stefan.agner@toradex.com> >> >> Signed-off-by: Stefan Agner <stefan@agner.ch> >> --- >> tests/kmstest/main.c | 1 + >> tests/modetest/modetest.c | 2 +- >> tests/proptest/proptest.c | 2 +- >> tests/vbltest/vbltest.c | 2 +- >> 4 files changed, 4 insertions(+), 3 deletions(-) >> > I've pushed a series (where this patch will conflict) around the same > time you sent this. Please can take a look at tests/util/kms.c... > although kmstest, (even modeprint and others) could be updated to use > the new helper. I see, will rebase my patch. > > Although I'd really love if one updates the drm*Device API to handle > platform devices. I've been looking for volunteers, although most > platform people tend to say low :-P Do I get that right, you would like to extend drm*Device API to also enumerate platform devices? Hm, I guess one would have to have a reasonable understanding of what variations are out there to make the API future proof. I think right now I will join the other platform device developers and stay low :-) > Feel free to skim through tests/drmdevice.c or let me know if > something feels amiss. -- Stefan
On 20 December 2015 at 04:37, Stefan Agner <stefan@agner.ch> wrote: > On 2015-12-19 08:49, Emil Velikov wrote: >> Hi Stefan, >> >> On 18 December 2015 at 19:37, Stefan Agner <stefan@agner.ch> wrote: >>> From: Stefan Agner <stefan.agner@toradex.com> >>> >>> Signed-off-by: Stefan Agner <stefan@agner.ch> >>> --- >>> tests/kmstest/main.c | 1 + >>> tests/modetest/modetest.c | 2 +- >>> tests/proptest/proptest.c | 2 +- >>> tests/vbltest/vbltest.c | 2 +- >>> 4 files changed, 4 insertions(+), 3 deletions(-) >>> >> I've pushed a series (where this patch will conflict) around the same >> time you sent this. Please can take a look at tests/util/kms.c... >> although kmstest, (even modeprint and others) could be updated to use >> the new helper. > > I see, will rebase my patch. > >> >> Although I'd really love if one updates the drm*Device API to handle >> platform devices. I've been looking for volunteers, although most >> platform people tend to say low :-P > > Do I get that right, you would like to extend drm*Device API to also > enumerate platform devices? That's right. > Hm, I guess one would have to have a > reasonable understanding of what variations are out there to make the > API future proof. I think right now I will join the other platform > device developers and stay low :-) > I wouldn't worry that much about future proofing it. The first implementation (of everything) is never perfect. Something like the platform id (alike the one reported by the kernel module) perhaps even the id "fused" with the location (like the one produced due to the DT bindings) or anything that you believe is reasonable. -Emil
diff --git a/tests/kmstest/main.c b/tests/kmstest/main.c index 120bc0f..54b2155 100644 --- a/tests/kmstest/main.c +++ b/tests/kmstest/main.c @@ -66,6 +66,7 @@ static const char *drivers[] = { "imx-drm", "rockchip", "atmel-hlcdc", + "fsl-dcu-drm", NULL }; diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 3b01918..05b6266 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -1554,7 +1554,7 @@ int main(int argc, char **argv) int drop_master = 0; int test_vsync = 0; int test_cursor = 0; - const char *modules[] = { "i915", "radeon", "nouveau", "vmwgfx", "omapdrm", "exynos", "tilcdc", "msm", "sti", "tegra", "imx-drm", "rockchip", "atmel-hlcdc" }; + const char *modules[] = { "i915", "radeon", "nouveau", "vmwgfx", "omapdrm", "exynos", "tilcdc", "msm", "sti", "tegra", "imx-drm", "rockchip", "atmel-hlcdc", "fsl-dcu-drm" }; char *device = NULL; char *module = NULL; unsigned int i; diff --git a/tests/proptest/proptest.c b/tests/proptest/proptest.c index b9296bd..5a79114 100644 --- a/tests/proptest/proptest.c +++ b/tests/proptest/proptest.c @@ -303,7 +303,7 @@ static void printUsage(void) int main(int argc, char *argv[]) { - const char *modules[] = { "i915", "radeon", "nouveau", "vmwgfx", "omapdrm", "msm", "rockchip" }; + const char *modules[] = { "i915", "radeon", "nouveau", "vmwgfx", "omapdrm", "msm", "rockchip", "fsl-dcu-drm" }; unsigned int i, ret = 0; for (i = 0; i < ARRAY_SIZE(modules); i++){ diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c index e27f45c..531196c 100644 --- a/tests/vbltest/vbltest.c +++ b/tests/vbltest/vbltest.c @@ -106,7 +106,7 @@ int main(int argc, char **argv) { unsigned i; int c, fd, ret; - const char *modules[] = { "i915", "radeon", "nouveau", "vmwgfx", "exynos", "omapdrm", "tilcdc", "msm", "tegra", "imx-drm" , "rockchip" }; + const char *modules[] = { "i915", "radeon", "nouveau", "vmwgfx", "exynos", "omapdrm", "tilcdc", "msm", "tegra", "imx-drm" , "rockchip", "fsl-dcu-drm" }; drmVBlank vbl; drmEventContext evctx; struct vbl_info handler_info;