| Message ID | 1454316643-3931-1-git-send-email-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 1, 2016 at 2:50 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > This adds device tree bindings for the TPO TPG110 panel found > mounted in the Nomadik NHK8815. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../bindings/display/panel/tpo,tpg110.txt | 47 ++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt > new file mode 100644 > index 000000000000..acbc6bef3593 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt > @@ -0,0 +1,47 @@ > +TPO TPG110 Panel > +================ > + > +This binding builds on the DPI bindings, adding a few properties > +as a superset of a DPI. See panel-dpi.txt for the required DPI > +bindings. > + > +Required properties: > +- compatible : "tpo,tpg110" > +- grestb-gpio : panel reset GPIO -gpios The example is correct. Otherwise, Acked-by: Rob Herring <robh@kernel.org> > +- scen-gpios : serial control enable GPIO > +- scl-gpios : serial control clock line GPIO > +- sda-gpios : serial control data line GPIO > + > +Required nodes: > +- Video port for DPI input, see panel-dpi.txt > +- Panel timing for DPI setup, see panel-dpi.txt > + > +Example > +------- > + > +panel { > + compatible = "tpo,tpg110", "panel-dpi"; > + grestb-gpios = <&stmpe_gpio44 5 GPIO_ACTIVE_LOW>; > + scen-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; > + scl-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>; > + sda-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>; > + backlight = <&bl>; > + > + port { > + nomadik_clcd_panel: endpoint { > + remote-endpoint = <&nomadik_clcd_pads>; > + }; > + }; > + > + panel-timing { > + clock-frequency = <33200000>; > + hactive = <800>; > + hback-porch = <216>; > + hfront-porch = <40>; > + hsync-len = <1>; > + vactive = <480>; > + vback-porch = <35>; > + vfront-porch = <10>; > + vsync-len = <1>; > + }; > +}; > -- > 2.4.3 >
On Mon, Feb 01, 2016 at 09:50:43AM +0100, Linus Walleij wrote: > This adds device tree bindings for the TPO TPG110 panel found > mounted in the Nomadik NHK8815. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../bindings/display/panel/tpo,tpg110.txt | 47 ++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt > new file mode 100644 > index 000000000000..acbc6bef3593 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt > @@ -0,0 +1,47 @@ > +TPO TPG110 Panel > +================ > + > +This binding builds on the DPI bindings, adding a few properties > +as a superset of a DPI. See panel-dpi.txt for the required DPI > +bindings. It is unfortunate that we have these two types of bindings, one used by some of the legacy fbdev drivers and the other by DRM/KMS drivers. There isn't really much we can do about it, though, as far as I can see. This panel is used with an fbdev driver, right? Thierry
On Tue, Feb 2, 2016 at 5:28 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > On Mon, Feb 01, 2016 at 09:50:43AM +0100, Linus Walleij wrote: >> +This binding builds on the DPI bindings, adding a few properties >> +as a superset of a DPI. See panel-dpi.txt for the required DPI >> +bindings. > > It is unfortunate that we have these two types of bindings, one used by > some of the legacy fbdev drivers and the other by DRM/KMS drivers. There > isn't really much we can do about it, though, as far as I can see. I wasn't aware that they were any different. Where is the equivalent binding for DRM/KMS panels? I guess one must have been merged first and the second one screwed up by not reusing the first one :( > This panel is used with an fbdev driver, right? Yes. I don't know if I will be able to convert the AMBA CLCD driver from fbdev to DRM/KMS but I was hoping I would not have to change the DT to redescribe the same hardware for that, but now it sounds like that is a consequence... Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt new file mode 100644 index 000000000000..acbc6bef3593 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt @@ -0,0 +1,47 @@ +TPO TPG110 Panel +================ + +This binding builds on the DPI bindings, adding a few properties +as a superset of a DPI. See panel-dpi.txt for the required DPI +bindings. + +Required properties: +- compatible : "tpo,tpg110" +- grestb-gpio : panel reset GPIO +- scen-gpios : serial control enable GPIO +- scl-gpios : serial control clock line GPIO +- sda-gpios : serial control data line GPIO + +Required nodes: +- Video port for DPI input, see panel-dpi.txt +- Panel timing for DPI setup, see panel-dpi.txt + +Example +------- + +panel { + compatible = "tpo,tpg110", "panel-dpi"; + grestb-gpios = <&stmpe_gpio44 5 GPIO_ACTIVE_LOW>; + scen-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; + scl-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>; + sda-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>; + backlight = <&bl>; + + port { + nomadik_clcd_panel: endpoint { + remote-endpoint = <&nomadik_clcd_pads>; + }; + }; + + panel-timing { + clock-frequency = <33200000>; + hactive = <800>; + hback-porch = <216>; + hfront-porch = <40>; + hsync-len = <1>; + vactive = <480>; + vback-porch = <35>; + vfront-porch = <10>; + vsync-len = <1>; + }; +};
This adds device tree bindings for the TPO TPG110 panel found mounted in the Nomadik NHK8815. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- .../bindings/display/panel/tpo,tpg110.txt | 47 ++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt