From patchwork Tue Feb 9 20:11:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 8266941 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EF330BF0A9 for ; Wed, 10 Feb 2016 00:16:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 29C892027D for ; Wed, 10 Feb 2016 00:16:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 0BD4B20254 for ; Wed, 10 Feb 2016 00:16:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8B8C6E627; Tue, 9 Feb 2016 16:16:36 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAD566E15E for ; Tue, 9 Feb 2016 12:11:28 -0800 (PST) Received: by mail-wm0-f53.google.com with SMTP id c200so76518404wme.0 for ; Tue, 09 Feb 2016 12:11:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KTgymiW7B5ONuvo6W2CkSol+4JJNMfeorkXl/5YafLU=; b=VooW+eJX5OzQcueQ+VmcEsCg862R9hLVKWf59XcUO2e2YmC97/3GF0J4rWO8Y8tedL TRKTM03E3k1jY7+4Z8vc98/hCwjf1lSL5mg5PCJMh/rTwK9aKE6n1Z5zc9h51DVFu6zJ m4KMSJ32LASH3Q1JEJZkavPv3fb6F+rUolQQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KTgymiW7B5ONuvo6W2CkSol+4JJNMfeorkXl/5YafLU=; b=YqzCMPWFfobw4J2YiuUWDjLIGJDUUpfGQrErqP+YsPVxE8SMOILbHMTn+jsLabPjBc BQptwTvgZPI1xfSI/LnQK5MSbD2eP+QkEdSX0wWIXG5xT2MmVywVDby/7rulyOWGMGwD o/T/MT5WiPSSgC9lZfY3JgT5t4U/6wV/2gaQNQJe8h4W7zYI0rvCbmcrU+zPc2KjFRAS YKpydAsSzKV6IsJVVqBvTwHA3kbMB8tpB4F02SY/LHJ8Zwlsc5Rn1yxhxT0S0d4c0nnJ 3cxH7OtqvxodtYt/ccC/DNY+ONRA8zYLav6+nasyF9/Kld9MK5O/bI6/0Od8kCMLLute dgkA== X-Gm-Message-State: AG10YOQsh27M+8wanhengPwS0c1SP5tVTnLGRUcMS7mqJOJJ8KzgVztlbD76HZboZoQuEA== X-Received: by 10.28.52.195 with SMTP id b186mr6731173wma.40.1455048687587; Tue, 09 Feb 2016 12:11:27 -0800 (PST) Received: from wildmoose.dk (lvps87-230-87-209.dedicated.hosteurope.de. [87.230.87.209]) by smtp.gmail.com with ESMTPSA id h14sm1384331wjs.41.2016.02.09.12.11.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 Feb 2016 12:11:27 -0800 (PST) From: Rasmus Villemoes To: Patrik Jakobsson , David Airlie Subject: [PATCH 1/5] drm/gma500: fix error path in gma_intel_setup_gmbus() Date: Tue, 9 Feb 2016 21:11:12 +0100 Message-Id: <1455048677-19882-2-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailman-Approved-At: Tue, 09 Feb 2016 16:16:35 -0800 Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The current code fails to call i2c_del_adapter on dev_prev->gmbus[0].adapter, and if the for loop above failed already at i==0, all hell breaks loose when we do the loop body for i = -1,-2,... Signed-off-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/gma500/intel_gmbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 566d330aaeea..e7e22187c539 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -436,7 +436,7 @@ int gma_intel_setup_gmbus(struct drm_device *dev) return 0; err: - while (--i) { + while (i--) { struct intel_gmbus *bus = &dev_priv->gmbus[i]; i2c_del_adapter(&bus->adapter); }