From patchwork Fri Feb 12 12:13:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 8290471 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BFF319FE98 for ; Fri, 12 Feb 2016 12:15:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E0C6F203F7 for ; Fri, 12 Feb 2016 12:15:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id E3FEC2041E for ; Fri, 12 Feb 2016 12:15:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 917356EA91; Fri, 12 Feb 2016 04:15:17 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C5B76EA89 for ; Fri, 12 Feb 2016 04:15:15 -0800 (PST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2F00I4GOPBQH00@mailout2.w1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 12 Feb 2016 12:15:11 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-c9-56bdcccfc902 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id A6.97.16778.FCCCDB65; Fri, 12 Feb 2016 12:15:11 +0000 (GMT) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O2F00L4POP94J20@eusync1.samsung.com>; Fri, 12 Feb 2016 12:15:11 +0000 (GMT) From: Andrzej Hajda To: Inki Dae Subject: [PATCH 2/4] drm/exynos/fimc: remove unused camera interface polarization code Date: Fri, 12 Feb 2016 13:13:57 +0100 Message-id: <1455279239-13609-3-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1455279239-13609-1-git-send-email-a.hajda@samsung.com> References: <1455279239-13609-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCLMWRmVeSWpSXmKPExsVy+t/xy7rnz+wNMzj8kN3i1rpzrBYbZ6xn tbjy9T2bxZ6r95gsJt2fwGKx4stMdosZ5/cxWaw9cpfdgcNj56y77B73u48zefRtWcXo8XmT XABLFJdNSmpOZllqkb5dAlfG/fuLmApmClRM7jvJ2sB4lreLkZNDQsBEonXjIyYIW0ziwr31 bF2MXBxCAksZJeZ8W8IO4TQxSTw7MpEdpIpNQFPi7+abbCC2iICyxKp97WBFzAIfmCQerJnA CJIQFoiQWHRgAQuIzSKgKnF2y21WEJtXwFniSPsdVoh1chInj00GszkFXCRauvYwdzFyAG1z ltj2qXYCI+8CRoZVjKKppckFxUnpuYZ6xYm5xaV56XrJ+bmbGCFh9WUH4+JjVocYBTgYlXh4 DW7tCRNiTSwrrsw9xCjBwawkwmvQtDdMiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/cXe9DhATS E0tSs1NTC1KLYLJMHJxSDYwrb278qBi5f9+W24vbvCYFzcizc5LWE71VZl3F/TjWt67qQ8/V QLOb6x110pYrnKnZ4MXWZMV+a07GeabnFeru/zcduHW88f413zlpG4vm61x4s3fBmgAu9gub 2ULf/DPQXnT5wJVTM78uN9WefKVE1OfcHo0WrvIl7k8af/QwRjDnlXuz9NxWYinOSDTUYi4q TgQACYhsKScCAAA= Cc: linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jingoo Han , emil.l.velikov@gmail.com, "open list:DRM DRIVERS FOR EXYNOS" , Andrzej Hajda , Marek Szyprowski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Polarization was never configured for DRM-FIMC device, so fimc_set_polarity function did nothing. In fact DRM does not use camera interface so there is no point in configuring it. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 8a4f4a0..0525c56 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -163,7 +163,6 @@ struct fimc_context { u32 clk_frequency; struct regmap *sysreg; struct fimc_scaler sc; - struct exynos_drm_ipp_pol pol; int id; int irq; bool suspended; @@ -260,32 +259,6 @@ static void fimc_set_type_ctrl(struct fimc_context *ctx, enum fimc_wb wb) fimc_write(ctx, cfg, EXYNOS_CIGCTRL); } -static void fimc_set_polarity(struct fimc_context *ctx, - struct exynos_drm_ipp_pol *pol) -{ - u32 cfg; - - DRM_DEBUG_KMS("inv_pclk[%d]inv_vsync[%d]\n", - pol->inv_pclk, pol->inv_vsync); - DRM_DEBUG_KMS("inv_href[%d]inv_hsync[%d]\n", - pol->inv_href, pol->inv_hsync); - - cfg = fimc_read(ctx, EXYNOS_CIGCTRL); - cfg &= ~(EXYNOS_CIGCTRL_INVPOLPCLK | EXYNOS_CIGCTRL_INVPOLVSYNC | - EXYNOS_CIGCTRL_INVPOLHREF | EXYNOS_CIGCTRL_INVPOLHSYNC); - - if (pol->inv_pclk) - cfg |= EXYNOS_CIGCTRL_INVPOLPCLK; - if (pol->inv_vsync) - cfg |= EXYNOS_CIGCTRL_INVPOLVSYNC; - if (pol->inv_href) - cfg |= EXYNOS_CIGCTRL_INVPOLHREF; - if (pol->inv_hsync) - cfg |= EXYNOS_CIGCTRL_INVPOLHSYNC; - - fimc_write(ctx, cfg, EXYNOS_CIGCTRL); -} - static void fimc_handle_jpeg(struct fimc_context *ctx, bool enable) { u32 cfg; @@ -1467,7 +1440,6 @@ static int fimc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd) /* If set ture, we can save jpeg about screen */ fimc_handle_jpeg(ctx, false); fimc_set_scaler(ctx, &ctx->sc); - fimc_set_polarity(ctx, &ctx->pol); switch (cmd) { case IPP_CMD_M2M: