From patchwork Fri Mar 4 23:22:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 8508151 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7A204C0554 for ; Fri, 4 Mar 2016 23:22:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AA955202AE for ; Fri, 4 Mar 2016 23:22:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id BB0CD2026F for ; Fri, 4 Mar 2016 23:22:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6488D6E85B; Fri, 4 Mar 2016 23:22:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x22c.google.com (mail-pf0-x22c.google.com [IPv6:2607:f8b0:400e:c00::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D7786E85B for ; Fri, 4 Mar 2016 23:22:40 +0000 (UTC) Received: by mail-pf0-x22c.google.com with SMTP id x188so19270264pfb.2 for ; Fri, 04 Mar 2016 15:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=oIPZ5p5MQL8ncb+P3euuw4jJBpEZrqKknhGKl6IGcvk=; b=O2PmkDTz16Uzn3/rG8F8QajdTz8fpWCahYnKH0WSTAuG4FZtWMl+uMaQiR3xQnZPDo PEhkhsurJ27yDDjPKmXNp+ZHTzaWi3Vb8ftL9z2XAa17bqtBTLzGBRdMf5yZUGA6C7zJ 9zYrmhsWOfv2Ms+MEnrNXHFOlM++/RhdbZCFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oIPZ5p5MQL8ncb+P3euuw4jJBpEZrqKknhGKl6IGcvk=; b=PKHmjxjVhut/flID3oeeiZOFqRLiO2pKsgWBApbEMkTkcoI0aUJ2XdcvHJ2Oy6tEHz PUib56NWxHs0FTJKGhZVXUAagumMxZWWiaEKQ/PKfuP3jpynCiUyWUSDIh2nhw2kMEhT 9G1CWRT5sA+yoKTmPRASJNSesybRIw+siWvKbQdYviGx+FYNJrBE3H3/wcL92vHqTbVV +z3MUPLEp0FU1qLpFPpqHXjh0dMlJldFx306BAbM1HR1ciTxe75VvqgC87nk5+0b4Bx+ k3MseuaaIY65nJFi3pY3xp9P7GTbEj7DqYZoIG1eVNw1ypjzZLFzuCMNnX3VC3MJiUVz OPtg== X-Gm-Message-State: AD7BkJKFsEGWRkEL02ucp0Og5rUjtJ8dJ16qrY6oRr/OQG+oQWQMOl/PQB4lrLSZyl1b0Q== X-Received: by 10.98.70.139 with SMTP id o11mr15800732pfi.123.1457133759843; Fri, 04 Mar 2016 15:22:39 -0800 (PST) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id 67sm7897375pfi.2.2016.03.04.15.22.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Mar 2016 15:22:39 -0800 (PST) From: Douglas Anderson To: Mark Yao , David Airlie , Heiko Stuebner Subject: [PATCH 1/2] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path Date: Fri, 4 Mar 2016 15:22:01 -0800 Message-Id: <1457133723-24869-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 Cc: Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The drm_encoder_cleanup() was missing both from the error path of dw_hdmi_rockchip_bind(). This caused a crash when slub_debug was enabled and we ended up deferring probe of HDMI at boot. This call isn't needed from unbind() because if dw_hdmi_bind() returns no error then it takes over the job of freeing the encoder (in dw_hdmi_unbind). Signed-off-by: Douglas Anderson --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 3d3cf2f8891e..88776aba984e 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -293,7 +293,16 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, drm_encoder_init(drm, encoder, &dw_hdmi_rockchip_encoder_funcs, DRM_MODE_ENCODER_TMDS, NULL); - return dw_hdmi_bind(dev, master, data, encoder, iores, irq, plat_data); + ret = dw_hdmi_bind(dev, master, data, encoder, iores, irq, plat_data); + + /* + * If dw_hdmi_bind() fails we'll never call dw_hdmi_unbind(), + * which would have called the encoder cleanup. Do it manually. + */ + if (ret) + drm_encoder_cleanup(encoder); + + return ret; } static void dw_hdmi_rockchip_unbind(struct device *dev, struct device *master,