| Message ID | 1460839349-1253588-1-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann <arnd@arndb.de> wrote: > A recent cleanup removed the only user of the 'kms' variable in > msm_preclose(), causing a harmless compiler warning: > > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose': > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' [-Werror=unused-variable] > > This removes the variable as well. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal") thanks, I'll pull that in for 4.7.. danvet actually pointed that out to me yesterday (a needed fix of a fix.. ;-)) BR, -R > --- > drivers/gpu/drm/msm/msm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index c03b96709179..701c51ed3e7c 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -465,7 +465,6 @@ static void msm_preclose(struct drm_device *dev, struct drm_file *file) > { > struct msm_drm_private *priv = dev->dev_private; > struct msm_file_private *ctx = file->driver_priv; > - struct msm_kms *kms = priv->kms; > > mutex_lock(&dev->struct_mutex); > if (ctx == priv->lastctx) > -- > 2.7.0 >
On Saturday 16 April 2016 16:49:08 Rob Clark wrote: > On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > A recent cleanup removed the only user of the 'kms' variable in > > msm_preclose(), causing a harmless compiler warning: > > > > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose': > > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' [-Werror=unused-variable] > > > > This removes the variable as well. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal") > > thanks, I'll pull that in for 4.7.. danvet actually pointed that out > to me yesterday (a needed fix of a fix.. ;-)) I just realized that this is now the only defconfig warning we get in v4.6 with a recent compiler. Any chance we can still squeeze this in the current release? Arnd
On Sun, Apr 24, 2016 at 6:15 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Saturday 16 April 2016 16:49:08 Rob Clark wrote: >> On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann <arnd@arndb.de> wrote: >> > A recent cleanup removed the only user of the 'kms' variable in >> > msm_preclose(), causing a harmless compiler warning: >> > >> > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose': >> > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' [-Werror=unused-variable] >> > >> > This removes the variable as well. >> > >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal") >> >> thanks, I'll pull that in for 4.7.. danvet actually pointed that out >> to me yesterday (a needed fix of a fix.. ;-)) > > I just realized that this is now the only defconfig warning we get in v4.6 with > a recent compiler. Any chance we can still squeeze this in the current release? I don't have anything else to send for -fixes at the moment, but Signed-off-by: Rob Clark <robdclark@gmail.com> Dave, if you are sending another -fixes, mind grabbing this: git pw apply -s 5827 (or if you are still on the old pw, 'pwclient git-am 8277241') BR, -R > Arnd
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index c03b96709179..701c51ed3e7c 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -465,7 +465,6 @@ static void msm_preclose(struct drm_device *dev, struct drm_file *file) { struct msm_drm_private *priv = dev->dev_private; struct msm_file_private *ctx = file->driver_priv; - struct msm_kms *kms = priv->kms; mutex_lock(&dev->struct_mutex); if (ctx == priv->lastctx)
A recent cleanup removed the only user of the 'kms' variable in msm_preclose(), causing a harmless compiler warning: drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose': drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' [-Werror=unused-variable] This removes the variable as well. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal") --- drivers/gpu/drm/msm/msm_drv.c | 1 - 1 file changed, 1 deletion(-)