From patchwork Wed May 11 12:34:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9069061 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 15F06BF29F for ; Wed, 11 May 2016 12:35:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3D354201BB for ; Wed, 11 May 2016 12:35:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 5EB832017D for ; Wed, 11 May 2016 12:35:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3A066E717; Wed, 11 May 2016 12:35:27 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EFCD6E717 for ; Wed, 11 May 2016 12:35:25 +0000 (UTC) Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0MV4mL-1b7xAs22hR-00YQoq; Wed, 11 May 2016 14:35:07 +0200 From: Arnd Bergmann To: David Airlie , Philipp Zabel Subject: [PATCH] drm: mediatek: add COMMON_CLK dependency Date: Wed, 11 May 2016 14:34:22 +0200 Message-Id: <1462970100-240687-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:Fz7vBh0k0DZfFtPGk4Iw4ew8FCVOlbOgtHqijvd3vu47HM/G4jx qdbnOGa3z0NsGbcxgnyP+52IAVS6ipPOBMhuYLnwHckvUFrXXkF9LQkqI1Hu3Y6w//cjaf6 Pfyqer082NTYAGeLzIFxNn/0ekI853sm4+CD4NraPKl2j3nrtcUYwYfN67NpG38XD6egIBT PhOGpBzkGiw6cmqOyZJKg== X-UI-Out-Filterresults: notjunk:1; V01:K0:/SwhI51IOCo=:9P4/P5se65V8GmWcG4EGYO T6WaYaUHekfsf2WARh/mEEogY++L9IgzdBVgAgjoGY+jOs6Aa21JY6jqU3t73gUyb5qNTU6oa br5Uc9f2NCR3KYhO05aqEZ+lHr/jJEzTDuiuWm4Qo6VHq4DvkfyMbVrtwg+VGzdxiWg43H62Y gvar1bkeN8jJg3D8a2/MtgnJ+YC00tblmCrr5HKuUBx0y6XK7gp3FXzVHsEfxc4tadneiVIvo wWuT/bfXNnzguBhVRgrUMS4gPu+kArnBQr2+WMkHH/QLSgURGroxlBOfkOw/W0ifxaN1pHO3X pz6TKDveRIxnH9t7rUEUdoE6AIEVVz9+JunN5iIDO6PdZ5z1bwpi9k19wE6jbelkvnUZBtgT6 aNTIj5sPDphbdBeAtrWx1Zf+uioP3u2Nc1hQ8GOV1aNLbj8f9kgYf4Xh8WnTEajvJA4gXlXab Y2uU7HcPBjnmp0dlk3rNdgIDub7pkpC1UukvJ2pGGqqow1ScvF+PbmpppUWwOgK/l1DCVeLdl /Jtpog+bnPDXlVPJ7WK2A1YXZOKCbqg+6BdptxiG4oh7vhGTa5ec1SQOanRvX1nJysbhbXXaM U8ybkyLASun6DvSKpsZDWi2u1TjjnWkaldqN04t87GcPGl5ea4KaJKRxZcVcHrmeRyJ4MFE0X H7EXauUnZiDUyqzYGepe99fxm9i1SmkRU3/IpPSC4cOjPgBgesUk6+V2ymreIPx12hlU= Cc: Jitao Shi , Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mao Huang , YT Shen , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On kernel builds without COMMON_CLK, the newly added mediatek drm driver fails to build: drivers/gpu/drm/mediatek/mtk_mipi_tx.c:130:16: error: field 'pll_hw' has incomplete type struct clk_hw pll_hw; ^~~~~~ In file included from ../include/linux/clk.h:16:0, from ../drivers/gpu/drm/mediatek/mtk_mipi_tx.c:14: drivers/gpu/drm/mediatek/mtk_mipi_tx.c: In function 'mtk_mipi_tx_from_clk_hw': include/linux/kernel.h:831:48: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ /drivers/gpu/drm/mediatek/mtk_mipi_tx.c:136:9: note: in expansion of macro 'container_of' return container_of(hw, struct mtk_mipi_tx, pll_hw); ^~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_mipi_tx.c: At top level: drivers/gpu/drm/mediatek/mtk_mipi_tx.c:302:21: error: variable 'mtk_mipi_tx_pll_ops' has initializer but incomplete type static const struct clk_ops mtk_mipi_tx_pll_ops = { This adds the required Kconfig dependency. Signed-off-by: Arnd Bergmann Acked-by: Philipp Zabel --- drivers/gpu/drm/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index eeefc971801a..0c06a69d7f04 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -2,6 +2,7 @@ config DRM_MEDIATEK tristate "DRM Support for Mediatek SoCs" depends on DRM depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST) + depends on COMMON_CLK select DRM_GEM_CMA_HELPER select DRM_KMS_HELPER select DRM_MIPI_DSI