| Message ID | 1463742948-15592-1-git-send-email-hs@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Heiko, On Fri, May 20, 2016 at 8:15 AM, Heiko Schocher <hs@denx.de> wrote: > commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading") > breaks the aristainetos2 board with the "lg,lg4573" panel. > > This reverts the above commit. > > Signed-off-by: Heiko Schocher <hs@denx.de> > > --- > Any hint, how to bring back the display on the aristainetos2 > board without reverting this commit would be appreciated. Philipp sent the following patch that fixes the issue: http://www.spinics.net/lists/dri-devel/msg107524.html
Hello Fabio, Am 20.05.2016 um 13:40 schrieb Fabio Estevam: > Hi Heiko, > > On Fri, May 20, 2016 at 8:15 AM, Heiko Schocher <hs@denx.de> wrote: >> commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading") >> breaks the aristainetos2 board with the "lg,lg4573" panel. >> >> This reverts the above commit. >> >> Signed-off-by: Heiko Schocher <hs@denx.de> >> >> --- >> Any hint, how to bring back the display on the aristainetos2 >> board without reverting this commit would be appreciated. > > Philipp sent the following patch that fixes the issue: > http://www.spinics.net/lists/dri-devel/msg107524.html Thanks for the hint! This patch fixes the issue see log: http://xeidos.ddns.net/buildbot/builders/ari_lx/builds/0/steps/shell/logs/tbotlog bye, Heiko
diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index abb98c7..e00db3f 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1068,6 +1068,7 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base) goto err_register; } + pdev->dev.of_node = of_node; pdev->dev.parent = dev; ret = platform_device_add_data(pdev, ®->pdata, @@ -1078,12 +1079,6 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base) platform_device_put(pdev); goto err_register; } - - /* - * Set of_node only after calling platform_device_add. Otherwise - * the platform:imx-ipuv3-crtc modalias won't be used. - */ - pdev->dev.of_node = of_node; } return 0;
commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading") breaks the aristainetos2 board with the "lg,lg4573" panel. This reverts the above commit. Signed-off-by: Heiko Schocher <hs@denx.de> --- Any hint, how to bring back the display on the aristainetos2 board without reverting this commit would be appreciated. Board DTS: arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi arch/arm/boot/dts/imx6dl-aristainetos2_4.dts see the log of a full automated "git bisect" session with tbot testcase: https://github.com/hsdenx/tbot/blob/master/src/tc/board/tc_board_aristainetos2_linux_bisect.py here: http://xeidos.ddns.net/buildbot/builders/ari_lx_bi/builds/3/steps/shell/logs/tbotlog for details. drivers/gpu/ipu-v3/ipu-common.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)