From patchwork Fri May 20 11:15:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Schocher X-Patchwork-Id: 9129273 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 36D0B60762 for ; Fri, 20 May 2016 11:16:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 290C325D91 for ; Fri, 20 May 2016 11:16:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D79E27C23; Fri, 20 May 2016 11:16:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DF7425D91 for ; Fri, 20 May 2016 11:16:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91D396E32B; Fri, 20 May 2016 11:16:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F8796E32B for ; Fri, 20 May 2016 11:15:59 +0000 (UTC) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3rB52z4pW6z3hl8J; Fri, 20 May 2016 13:15:54 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3rB52y47qmzvkKF; Fri, 20 May 2016 13:15:54 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.184]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id kJvwKiAQ4Mtt; Fri, 20 May 2016 13:15:52 +0200 (CEST) X-Auth-Info: qh/Sj7/3ORadYwdSqv0IVdBridFwl8w/twcG3xhBP+w= Received: from mail-internal.denx.de (host-82-135-33-74.customer.m-online.net [82.135.33.74]) by smtp-auth.mnet-online.de (Postfix) with ESMTPA; Fri, 20 May 2016 13:15:52 +0200 (CEST) Received: from pollux.denx.de (pollux [192.168.1.1]) by mail-internal.denx.de (Postfix) with ESMTP id 1B423180719; Fri, 20 May 2016 13:15:51 +0200 (CEST) Received: by pollux.denx.de (Postfix, from userid 515) id D435A1FE8; Fri, 20 May 2016 13:15:50 +0200 (CEST) From: Heiko Schocher To: linux-kernel@vger.kernel.org Subject: [PATCH] gpu: ipu-v3: display support on the aristainetos2 board broken Date: Fri, 20 May 2016 13:15:48 +0200 Message-Id: <1463742948-15592-1-git-send-email-hs@denx.de> X-Mailer: git-send-email 2.5.5 Cc: Dennis Gilmore , stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie , Heiko Schocher X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading") breaks the aristainetos2 board with the "lg,lg4573" panel. This reverts the above commit. Signed-off-by: Heiko Schocher --- Any hint, how to bring back the display on the aristainetos2 board without reverting this commit would be appreciated. Board DTS: arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi arch/arm/boot/dts/imx6dl-aristainetos2_4.dts see the log of a full automated "git bisect" session with tbot testcase: https://github.com/hsdenx/tbot/blob/master/src/tc/board/tc_board_aristainetos2_linux_bisect.py here: http://xeidos.ddns.net/buildbot/builders/ari_lx_bi/builds/3/steps/shell/logs/tbotlog for details. drivers/gpu/ipu-v3/ipu-common.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index abb98c7..e00db3f 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1068,6 +1068,7 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base) goto err_register; } + pdev->dev.of_node = of_node; pdev->dev.parent = dev; ret = platform_device_add_data(pdev, ®->pdata, @@ -1078,12 +1079,6 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base) platform_device_put(pdev); goto err_register; } - - /* - * Set of_node only after calling platform_device_add. Otherwise - * the platform:imx-ipuv3-crtc modalias won't be used. - */ - pdev->dev.of_node = of_node; } return 0;