From patchwork Tue May 31 19:59:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 9145579 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A4CA360761 for ; Tue, 31 May 2016 20:02:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99396263DC for ; Tue, 31 May 2016 20:02:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8C54226538; Tue, 31 May 2016 20:02:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89613263DC for ; Tue, 31 May 2016 20:02:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CA806E733; Tue, 31 May 2016 20:02:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yw0-f193.google.com (mail-yw0-f193.google.com [209.85.161.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id A56126E733 for ; Tue, 31 May 2016 20:02:11 +0000 (UTC) Received: by mail-yw0-f193.google.com with SMTP id n16so20433078ywd.2 for ; Tue, 31 May 2016 13:02:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GhMHP1r6EfY66b0DDkXovahVl6fwk3/4aidbxC7T0Gw=; b=BEBillCBT8XOH1wqk0SuScerz2zp/7vSiYniYtklPj7Alyhfvxdf5tzaVrQvcdyMtw liLZMXiCoODtFWER+jgfjIBD8A/R3eVkUqIFV/NJOtgAfHNAhpVavmY+JdXE7j4sPTn6 b4cWgAxXGR4IhqyjtYBDnCmwThZXZMDbr2aTi/ejFAB3ZPOpUcD1RFYaxH2ogRzK6rGo c6Vw2NwKjB5P1KGlSiLymoHIP0TKb82TE4/9jS22LNLxaJrGe10V+cVcdLEQGOOykV6l mrWlGXiUp/ZQVMPqpFRAm0BUznJ7E/sWMKoEazYN3388l335nctpu1lSmFURdHPq9MrF aaDA== X-Gm-Message-State: ALyK8tL4R9zWvFnEVb+04T9XnYkPcbu7HWLmdYFcaS27hPrOn5bIHQtYAGFUY3Mat+S6kg== X-Received: by 10.37.192.205 with SMTP id c196mr10326668ybf.69.1464724930561; Tue, 31 May 2016 13:02:10 -0700 (PDT) Received: from jade.localdomain ([187.64.210.186]) by smtp.gmail.com with ESMTPSA id w185sm17322549ywe.1.2016.05.31.13.02.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 May 2016 13:02:09 -0700 (PDT) From: Gustavo Padovan To: Greg Kroah-Hartman Subject: [PATCH 14/18] staging/android: remove 'destroyed' member from struct sync_timeline Date: Tue, 31 May 2016 16:59:09 -0300 Message-Id: <1464724753-2490-15-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1464724753-2490-1-git-send-email-gustavo@padovan.org> References: <1464724753-2490-1-git-send-email-gustavo@padovan.org> Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Gustavo Padovan , John Harrison X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan 'destroyed' was set but not used ny anyone. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c | 5 ----- drivers/staging/android/sync.h | 5 +---- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index 72262ba..1f956b9 100644 --- a/drivers/staging/android/sw_sync.c +++ b/drivers/staging/android/sw_sync.c @@ -107,11 +107,6 @@ static void sync_timeline_put(struct sync_timeline *obj) */ static void sync_timeline_destroy(struct sync_timeline *obj) { - obj->destroyed = true; - /* - * Ensure timeline is marked as destroyed before - * changing timeline's fences status. - */ smp_wmb(); sync_timeline_put(obj); diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h index 3a50851..3c551f5 100644 --- a/drivers/staging/android/sync.h +++ b/drivers/staging/android/sync.h @@ -25,10 +25,8 @@ * @kref: reference count on fence. * @drv_name: drv_name of the driver using the sync_timeline * @name: name of the sync_timeline. Useful for debugging - * @destroyed: set when sync_timeline is destroyed * @child_list_head: list of children sync_pts for this sync_timeline - * @child_list_lock: lock protecting @child_list_head, destroyed, and - * fence.status + * @child_list_lock: lock protecting @child_list_head and fence.status * @active_list_head: list of active (unsignaled/errored) sync_pts * @sync_timeline_list: membership in global sync_timeline_list */ @@ -38,7 +36,6 @@ struct sync_timeline { char name[32]; /* protected by child_list_lock */ - bool destroyed; int context, value; struct list_head child_list_head;