From patchwork Thu Jun 9 10:17:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinay Simha B N X-Patchwork-Id: 9166725 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8D15B607DA for ; Thu, 9 Jun 2016 11:10:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D34024151 for ; Thu, 9 Jun 2016 11:10:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 718122766D; Thu, 9 Jun 2016 11:10:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5721A24151 for ; Thu, 9 Jun 2016 11:10:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D12A6EB4D; Thu, 9 Jun 2016 11:10:51 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-x242.google.com (mail-pa0-x242.google.com [IPv6:2607:f8b0:400e:c03::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1895F6EB33 for ; Thu, 9 Jun 2016 10:18:17 +0000 (UTC) Received: by mail-pa0-x242.google.com with SMTP id fg1so2476307pad.3 for ; Thu, 09 Jun 2016 03:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=e7fGqapT6c3WzodszBaOfiR2m6owmoxme8OhFvDFK2U=; b=pBwXfFgmzBE6U3wYMqWPjs3SFXOEln05TA1CaoL+WbeGoxKIeAkjZMjEJVcMCbCKPx 7kEf85jCG4RWfNPqhMum+0RrWIL8Al5HO+RjRMC6llxreR1c4KLnIdXkSEvwM895Nldr ilDQaGl8LzPJ/v0YGc+11gNNWbXBC8mZnpoxqvtxCzXAz+fx+F5k2HzDLZjr1WBl/+JG dQNHFsyB9lKFT/uds3O/TLqQddWoaexb8/i6Uxzctt6AEAa2lj1vV0BAmTLTqK1mB+RZ 5JEFSAw/RPF2KX0cLpYEf+BNOxeuuX+SQPGLOaZf10Y6nMm1h0Lb9DJbOtLa43gYINnq ZzcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=e7fGqapT6c3WzodszBaOfiR2m6owmoxme8OhFvDFK2U=; b=ZX4lVtyeB961pxCXcfLChkSN+HQj35ZJh0OmtAmBUeQFpECqT1RlehSn+9TdquuCf+ HMleI47rLkQjdIOVIdldSk9XawfmEtIheUX9GTdU8fuCIqCZV54Fi/cHnTPA4Jua9dUs KuVO3Sl4lXApFdk+88U1RjQTvU5iDT7ddz1agA2URY86H0TrADL/S5aid25uBWfRqtcq wnSdSzVVYIXJBCuUwIHkQWoBPeocxCQe9/JnkbEgLHvYxfZhn6J6yy9K1eQL+hNijbuU VjGIGAI8KapOoI7DkEBOSZG+qKmHd1Mib8kFRmlZwm0sJqtYc8ex2nuzb33k/G90ra1t drCQ== X-Gm-Message-State: ALyK8tIAAWrF7MjXt0qqy4MqRbJelWeV/Jh6gkvrHORM00s9Dc+NuFj9SeepoVCFydOBVw== X-Received: by 10.66.25.38 with SMTP id z6mr10119570paf.11.1465467496105; Thu, 09 Jun 2016 03:18:16 -0700 (PDT) Received: from vinay-inforce-3-062.local.lan ([115.99.1.205]) by smtp.gmail.com with ESMTPSA id q88sm8899713pfj.4.2016.06.09.03.18.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jun 2016 03:18:15 -0700 (PDT) From: Vinay Simha BN To: Subject: [PATCH v2] drm/dsi: Implement dcs set/get display brightness Date: Thu, 9 Jun 2016 15:47:58 +0530 Message-Id: <1465467479-16585-1-git-send-email-simhavcs@gmail.com> X-Mailer: git-send-email 2.1.2 X-Mailman-Approved-At: Thu, 09 Jun 2016 11:10:40 +0000 Cc: open list , "open list:DRM DRIVERS" , Vinay Simha BN , Archit Taneja X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Signed-off-by: Vinay Simha BN --- v1: *tested in nexus7 2nd gen. v2: * implemented jani review comments -functions name mapped accordingly -bl value increased from 0xff to 0xffff -backlight interface will be handled in panel driver, so it is moved from the mipi_dsi helper function --- drivers/gpu/drm/drm_mipi_dsi.c | 49 ++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 4 ++++ 2 files changed, 53 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 7938ce7..5661a00 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -1025,6 +1025,55 @@ int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format) } EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format); +/** + * mipi_dsi_dcs_get_display_brightness() - gets the current brightness value + * of the display + * @dsi: DSI peripheral device + * @brightness: brightness value + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, + u16 *brightness) +{ + ssize_t err; + + err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS, + brightness, sizeof(*brightness)); + if (err < 0) { + if (err == 0) + err = -ENODATA; + + return err; + } + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_get_display_brightness); + +/** + * mipi_dsi_dcs_set_display_brightness() - sets the brightness value of + * the display + * @dsi: DSI peripheral device + * @brightness: brightness value + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, + u16 brightness) +{ + ssize_t err; + u8 bl_value[2] = { brightness & 0xff, brightness >> 8 }; + + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, + bl_value, sizeof(bl_value)); + if (err < 0) + return err; + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_set_display_brightness); + static int mipi_dsi_drv_probe(struct device *dev) { struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index ec55285..4494641 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -268,6 +268,10 @@ int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, enum mipi_dsi_dcs_tear_mode mode); int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format); +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, + u16 *brightness); +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, + u16 brightness); /** * struct mipi_dsi_driver - DSI driver