From patchwork Mon Jun 20 05:53:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinay Simha B N X-Patchwork-Id: 9187791 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1B86F601C0 for ; Mon, 20 Jun 2016 15:22:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 073861FFC9 for ; Mon, 20 Jun 2016 15:22:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F03B62793A; Mon, 20 Jun 2016 15:22:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79BC31FFC9 for ; Mon, 20 Jun 2016 15:22:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C3F16E5C5; Mon, 20 Jun 2016 15:22:51 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 644706E41C for ; Mon, 20 Jun 2016 05:54:44 +0000 (UTC) Received: by mail-pf0-x242.google.com with SMTP id i123so7800052pfg.3 for ; Sun, 19 Jun 2016 22:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=zr3Md1GBmAahG83B+5K3H8uj8Z21O40oyqlnnaUeAlI=; b=uvx6HFzqfcm3oCH1F7fhvSSLEDC5T0tp6TxJgOp0TWBwKe3BhwDfEstQDyFr3yLIyl QCpGnuGkjX5jNE8XKIgpuvjKpnqKW2qbghVI4cs31DVrzVKOFMjgxFjWcfmE4mX/6Lq4 NutP0iHwQ1tcIyBXUrKdUNOPUHeW4V+Lxah6a+QXClS9tnBR/IVEos2h6nA1ds0GNl7l G6vJ4OZXdgHpLPg5MEgpeh95nG5okm6xpk6RX9hDbzS3A6siZ/jQ4w7D1MojDIrHg4Iu /vVLcBQUUzgh2h51YpehEt0NhlfOrHYndui1SwEgCZ6mqODOzBdS0Vu5hs5ULD1bImXg Dqmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zr3Md1GBmAahG83B+5K3H8uj8Z21O40oyqlnnaUeAlI=; b=fIVgi/AflAeMQkQUlgQRsx06d1EOAsHMJndrzHjhEMJ3XsCN4b7r3W0sZmxmZnV7f+ /awwfeLzoV5Ri4JSp7zVKEQLMveuuYIc0hnu2t+3tXar5MEqXePMgIA4HVCCv7gO5i8f 6vXPk6j4zCVHWeU+Hfu6B9WsNGLCSe3wYZ/CkfblHGAaUcL7YI0bGUqWfiMfYzjCf1jl 9feI7qj6OOQo73pJ9HpnjNB5LUOqKmZNhx7iFNyQEYo+t95NnjfjEbRkETOZOQVWSo9e X7yb78eDg2Z/c3EGcPg7motILrzirfnk7cbQqZ5ax0lxQSJ8ordLsPuWdswaCwgjM63X iBGA== X-Gm-Message-State: ALyK8tIQ0ZfmbxaLMKQj36X40P15BC7JSHIA4fRo42LRys0vhXQviX3y+cOrqqF8fL7qSg== X-Received: by 10.98.7.22 with SMTP id b22mr20044263pfd.56.1466402083419; Sun, 19 Jun 2016 22:54:43 -0700 (PDT) Received: from localhost.localdomain ([115.99.1.27]) by smtp.gmail.com with ESMTPSA id g63sm62920210pfb.7.2016.06.19.22.54.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 19 Jun 2016 22:54:42 -0700 (PDT) From: Vinay Simha BN To: Subject: [PATCH v2 1/2] drm/dsi: Implement dcs set/get display brightness Date: Mon, 20 Jun 2016 11:23:48 +0530 Message-Id: <1466402029-23252-1-git-send-email-simhavcs@gmail.com> X-Mailer: git-send-email 2.1.2 X-Mailman-Approved-At: Mon, 20 Jun 2016 15:22:50 +0000 Cc: open list , "open list:DRM DRIVERS" , Vinay Simha BN , Archit Taneja X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Signed-off-by: Vinay Simha BN --- v1: *tested in nexus7 2nd gen. v2: * implemented jani review comments -functions name mapped accordingly -bl value increased from 0xff to 0xffff -backlight interface will be handled in panel driver, so it is moved from the mipi_dsi helper function --- drivers/gpu/drm/drm_mipi_dsi.c | 49 ++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 4 ++++ 2 files changed, 53 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 49311fc..2c03784 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -1041,6 +1041,55 @@ int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format) } EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format); +/** + * mipi_dsi_dcs_get_display_brightness() - gets the current brightness value + * of the display + * @dsi: DSI peripheral device + * @brightness: brightness value + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, + u16 *brightness) +{ + ssize_t err; + + err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS, + brightness, sizeof(*brightness)); + if (err < 0) { + if (err == 0) + err = -ENODATA; + + return err; + } + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_get_display_brightness); + +/** + * mipi_dsi_dcs_set_display_brightness() - sets the brightness value of + * the display + * @dsi: DSI peripheral device + * @brightness: brightness value + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, + u16 brightness) +{ + ssize_t err; + u8 bl_value[2] = { brightness & 0xff, brightness >> 8 }; + + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, + bl_value, sizeof(bl_value)); + if (err < 0) + return err; + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_set_display_brightness); + static int mipi_dsi_drv_probe(struct device *dev) { struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 72f5b15..4d77bb0 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -270,6 +270,10 @@ int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, enum mipi_dsi_dcs_tear_mode mode); int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format); +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, + u16 *brightness); +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, + u16 brightness); /** * struct mipi_dsi_driver - DSI driver