From patchwork Wed Jul 13 16:44:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinay Simha B N X-Patchwork-Id: 9229179 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 84D3F6075D for ; Thu, 14 Jul 2016 08:09:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7776D26464 for ; Thu, 14 Jul 2016 08:09:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6C2C82810E; Thu, 14 Jul 2016 08:09:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4B4326464 for ; Thu, 14 Jul 2016 08:09:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CF196E89A; Thu, 14 Jul 2016 08:09:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80CDC6E799 for ; Wed, 13 Jul 2016 16:44:50 +0000 (UTC) Received: by mail-pf0-x244.google.com with SMTP id g202so3412174pfb.1 for ; Wed, 13 Jul 2016 09:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gm6wlhf38eJ4jNMjPmgfU1obXyatql9KggEzbEuh3HQ=; b=XXtgqWEdt6xPr/8POSyQ3eRZLFdn2LtLOdvAFiVbbzLFnLLjsoEhGP9Ka8LAMIcBbY 1pY/d9Y4QY5P/GWTudWlN1GANG1LJvAZru1ZXUsC2XC5kA7THN9UygpSKfg9nuIY22Ut IQ+VMc8citdU/F6PI7z1RiR/9SapOqnc7z1M+yKe4fPLb41SpfJ7EzDvoJy8nvQqr74h OtPsjfLppwOxcls3rXnVDCPvirvGQnvuK81ceEI+WuT2ZIhNmWeAVBKVJ7gbNnaHkpaP CLHkAtfgcRYw6lo40pSTPxRyN6a6DkLTOlHtiCd3MXu3HZ2cKPtVKzFBWA4jkFEmUnqA m06Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gm6wlhf38eJ4jNMjPmgfU1obXyatql9KggEzbEuh3HQ=; b=j6QQHkXZPQjfJekulVTg+hyrtjV95Fy9Gz34vezFSAtb++uez+rorjc3L3Zfqp3RKI 8jA34YT4RR+vP7JwWKESIHReU8N/c/I21HRw0W7PnH3S4tsvD/9bbi0ul7Yi8jWhilB1 WsQb/AK7ZzP6afYjqN8cePEm7OgfsXxV1BxfNF2wjUrwjo1sZmmtmcQh1K5Uk2hm5xPS nu7/v/sctqgnwIrB+4xmqWmphgSdVTCvHe3jZVyf/uYyqHCtTdni39rrExYvyz5ONDQZ ucqSECkov0an+gysZH+OixHCtPdVXML3xvs4+UpVO72huA3/2e3P4BfnMKGtlDeMpK4K zFiA== X-Gm-Message-State: ALyK8tI7j4Ukpjha8BDz1OJHu8oZY/Td0mFbwWGIXzU0hF064VDUISKLwwfu/kur7V7URQ== X-Received: by 10.98.64.93 with SMTP id n90mr5021439pfa.29.1468428288901; Wed, 13 Jul 2016 09:44:48 -0700 (PDT) Received: from localhost.localdomain ([122.171.70.176]) by smtp.gmail.com with ESMTPSA id l82sm1274974pfk.8.2016.07.13.09.44.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Jul 2016 09:44:48 -0700 (PDT) From: Vinay Simha BN To: Subject: [PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness Date: Wed, 13 Jul 2016 22:14:15 +0530 Message-Id: <1468428258-5601-3-git-send-email-simhavcs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1468428258-5601-1-git-send-email-simhavcs@gmail.com> References: <1468428258-5601-1-git-send-email-simhavcs@gmail.com> X-Mailman-Approved-At: Thu, 14 Jul 2016 08:08:24 +0000 Cc: open list , "open list:DRM DRIVERS" , Vinay Simha BN , Archit Taneja X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Signed-off-by: Vinay Simha BN --- v1: *tested in nexus7 2nd gen. v2: * implemented jani review comments -functions name mapped accordingly -bl value increased from 0xff to 0xffff -backlight interface will be handled in panel driver, so it is moved from the mipi_dsi helper function --- drivers/gpu/drm/drm_mipi_dsi.c | 49 ++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 4 ++++ 2 files changed, 53 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index af0d471..7c22f64 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -1041,6 +1041,55 @@ int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format) } EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format); +/** + * mipi_dsi_dcs_get_display_brightness() - gets the current brightness value + * of the display + * @dsi: DSI peripheral device + * @brightness: brightness value + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, + u16 *brightness) +{ + ssize_t err; + + err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS, + brightness, sizeof(*brightness)); + if (err < 0) { + if (err == 0) + err = -ENODATA; + + return err; + } + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_get_display_brightness); + +/** + * mipi_dsi_dcs_set_display_brightness() - sets the brightness value of + * the display + * @dsi: DSI peripheral device + * @brightness: brightness value + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, + u16 brightness) +{ + ssize_t err; + u8 bl_value[2] = { brightness & 0xff, brightness >> 8 }; + + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, + bl_value, sizeof(bl_value)); + if (err < 0) + return err; + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_set_display_brightness); + static int mipi_dsi_drv_probe(struct device *dev) { struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 47ac925..404c373 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -270,6 +270,10 @@ int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, enum mipi_dsi_dcs_tear_mode mode); int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format); +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, + u16 *brightness); +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, + u16 brightness); /** * struct mipi_dsi_driver - DSI driver