From patchwork Mon Jul 18 08:28:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinay Simha B N X-Patchwork-Id: 9234449 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1E341607FF for ; Mon, 18 Jul 2016 11:27:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 107C12094F for ; Mon, 18 Jul 2016 11:27:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0510B263DC; Mon, 18 Jul 2016 11:27:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 925C22094F for ; Mon, 18 Jul 2016 11:27:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 44C2A6E386; Mon, 18 Jul 2016 11:26:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-x243.google.com (mail-pa0-x243.google.com [IPv6:2607:f8b0:400e:c03::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 83E106E28C for ; Mon, 18 Jul 2016 08:28:41 +0000 (UTC) Received: by mail-pa0-x243.google.com with SMTP id q2so10650436pap.0 for ; Mon, 18 Jul 2016 01:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=fJgWHyp+DOu9OJB2E7IQVLCLJA1BJMNbt0y3F2hVLo0=; b=HyseXBbx42mzfv9N7HB9wj7L+z86z4KG7o1xL0VXUB08y7tyCYSkxiwu2AB9WaGaAK KDYWhzYXd21x51b4yoCQMfMNkyNuNZ8j0d+h1FGkHsyu1ANYS7vQX23jvfov949dlLQq 8fmt2S8YEXNvbtpfbJ5aGFX+S0mdk/9ki32k9kNqO0tc0dMoMWwBORZYogwhwQHy3QDD O8U/aOyNMYlvVsfu0HkINORlxCCxR2wQ0V9hwJY9ZVX6EjTubMjl330rznjpG86RF1SK bdr3OklWlnnmbHC9sAZ+70JevWFch4tUNLdrQZ3vruwmw1PkVpVeFoMUax+JpIHDm4Ai 20KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fJgWHyp+DOu9OJB2E7IQVLCLJA1BJMNbt0y3F2hVLo0=; b=Ddt6BtL8sVdl/5qwRZ6F4oZD0e3ue9cQg+TssMuPt3xAmZiqqRx7brZ6iasT0Ze4UN WUDdjiEIywoRczRuABSiNxfLIiSUW2bVXR6SWfesT8NRJzVD/0m/o697MlYEos0IPas8 xAX5tZOxYb7duhwsvUqVxvMlgei2mA+6nM50SyELyQ+RdiMJp3QHXA0AiOIIUGbQGJa6 cEakXTflNScu7mXS9O14G/b9sX+gSA7zuT1g9vHp1IFjo2NymU9Rn5IpBb8pM3Zg8SIm Y0Ouqks0xLgepAyrRA5GNvi7VWLIC6cnaf676Ioz+17oExd5fkJfytMi8v7D4vHy0dHg Nc9g== X-Gm-Message-State: ALyK8tJv9g52/Rub3Ema3lpTyqRRBlhQKv7kFsbW8KZEbhcW9zs0i8/SLdfB9JLNtjMNFQ== X-Received: by 10.66.81.3 with SMTP id v3mr54354335pax.121.1468830520301; Mon, 18 Jul 2016 01:28:40 -0700 (PDT) Received: from localhost.localdomain ([202.83.17.75]) by smtp.gmail.com with ESMTPSA id c7sm2885018pfj.25.2016.07.18.01.28.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jul 2016 01:28:39 -0700 (PDT) From: Vinay Simha BN To: Subject: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness Date: Mon, 18 Jul 2016 13:58:24 +0530 Message-Id: <1468830508-15244-1-git-send-email-simhavcs@gmail.com> X-Mailer: git-send-email 2.1.2 X-Mailman-Approved-At: Mon, 18 Jul 2016 11:26:55 +0000 Cc: Emil Velikov , open list , "open list:DRM DRIVERS" , Vinay Simha BN , Archit Taneja X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Cc: Emil Velikov Signed-off-by: Vinay Simha BN Reviewed-by: Emil Velikov --- v1: *tested in nexus7 2nd gen. v2: * implemented jani review comments -functions name mapped accordingly -bl value increased from 0xff to 0xffff -backlight interface will be handled in panel driver, so it is moved from the mipi_dsi helper function v3: * emil review comments (err < 0) supposed to be (err <= 0) --- drivers/gpu/drm/drm_mipi_dsi.c | 49 ++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 4 ++++ 2 files changed, 53 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index af0d471..43aa743 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -1041,6 +1041,55 @@ int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format) } EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format); +/** + * mipi_dsi_dcs_get_display_brightness() - gets the current brightness value + * of the display + * @dsi: DSI peripheral device + * @brightness: brightness value + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, + u16 *brightness) +{ + ssize_t err; + + err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS, + brightness, sizeof(*brightness)); + if (err <= 0) { + if (err == 0) + err = -ENODATA; + + return err; + } + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_get_display_brightness); + +/** + * mipi_dsi_dcs_set_display_brightness() - sets the brightness value of + * the display + * @dsi: DSI peripheral device + * @brightness: brightness value + * + * Return: 0 on success or a negative error code on failure. + */ +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, + u16 brightness) +{ + ssize_t err; + u8 bl_value[2] = { brightness & 0xff, brightness >> 8 }; + + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, + bl_value, sizeof(bl_value)); + if (err < 0) + return err; + + return 0; +} +EXPORT_SYMBOL(mipi_dsi_dcs_set_display_brightness); + static int mipi_dsi_drv_probe(struct device *dev) { struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 47ac925..404c373 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -270,6 +270,10 @@ int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, enum mipi_dsi_dcs_tear_mode mode); int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format); +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, + u16 *brightness); +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, + u16 brightness); /** * struct mipi_dsi_driver - DSI driver