From patchwork Thu Jul 28 02:09:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9250783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A90D06075F for ; Thu, 28 Jul 2016 07:49:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D9D9219AC for ; Thu, 28 Jul 2016 07:49:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 922A325223; Thu, 28 Jul 2016 07:49:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A1E6219AC for ; Thu, 28 Jul 2016 07:49:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 38B076E76A; Thu, 28 Jul 2016 07:49:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-x243.google.com (mail-pa0-x243.google.com [IPv6:2607:f8b0:400e:c03::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id D11306E10A for ; Thu, 28 Jul 2016 02:09:26 +0000 (UTC) Received: by mail-pa0-x243.google.com with SMTP id q2so2650918pap.0 for ; Wed, 27 Jul 2016 19:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=G0dcUUPB9y5kxUvGfHfWyBK3L9+t7zWKLpZPTEbiIfs=; b=JXSqxRofXbV1wt9xq+V6Cr0jfVZagQIFF47/AFy2MCI6Oqe/T7NtbmM30dXPMqykz/ 2kjUHFfJbJv7rUoehag8v+k7EtB9ekQdE3RHTFuGf8kBiqjdEXRTfg/cY4hatjcj0INY 8x5b7+aZ32ZXJCtxr9vKByIbirlNk9cQM9NdzonjeZEkBBlA5b12D0z7hFJolHKUwahD gJECNHOjCR2oKCw7ETQWi1F9POLFCSHRXGaGxJfmhie3aPMLNb8SJgF+ohjxmm91p7pL wk7fSJyRNbHCsO44sif4uQju/+CtGQQH0ERjW88y679aZi+XFDTRay+OKWJ3Zlm6ao1O o17g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=G0dcUUPB9y5kxUvGfHfWyBK3L9+t7zWKLpZPTEbiIfs=; b=M9CpbJiOnYnFEn//DyVRYXWH2FvPv0cDNA+BeGi+p9WWxHbw4mGlZhRmEZfVnMn8gm XcTGf3yfJ+BeEeBzjOqWGW7B4Hf7OiSXPc5Uxqic1jj/vg/glejFD5aYzymGPyEmbjSz Dq1tmtRCfQDVfG6bTo7bOoiRfq23lT2HzGnfIEUcRUlrY2cbFEusfIAIfAfjBkZxvKiB 9i/0et/WjsYVgLo3fF16kFK5cMFpauHDRn6vCPtZT4bWbWszKMsAXZhrbWdvnGjm7R8s 1/FaUHELBVlognPUe1X5FHii6iyrXvZ96UjkAgp994XFN/thBPEUNsMOm/iCiOFsiEFT 44WQ== X-Gm-Message-State: AEkoouvVTdi7kO/XBQOggk0YoeF0a7aIq0YC/bz2+UyHLHZNR2E0Hq+lPjxJG1ET0vAgdQ== X-Received: by 10.66.21.167 with SMTP id w7mr54892807pae.62.1469671765326; Wed, 27 Jul 2016 19:09:25 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id 71sm12139060pfy.32.2016.07.27.19.09.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jul 2016 19:09:24 -0700 (PDT) From: Wei Yongjun To: Liviu Dudau , Brian Starkey , Mali DP Maintainers , David Airlie Subject: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind() Date: Thu, 28 Jul 2016 02:09:13 +0000 Message-Id: <1469671753-12961-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-TMASE-Version: CloudMessageScanner-0.0.0000-7.5.1021-22478.000 X-TMASE-Result: 10--6.452500-10.000000 X-TMASE-MatchedRID: dkXzegJ39QA4tGBQPT0ZoUhEDfw/93Bu+uIuZYGsMgRUjspoiX02Fwku iFJsQqOR5BvGbXImZuj1VmTZnVKT+JCoy9iDotiwFYJUGv4DL3zEoDEGChh7CWxZRBWPMUZWo8W MkQWv6iV95l0nVeyiuETkGP72Yfdk0C1sQRfQzEHEQdG7H66TyMdRT5TQAJnA3VrxtNgwsZP35A ELJ+YnDz0rMwlAg2Ps33bPJyI8CqieqD9WtJkSIw== X-Mailman-Approved-At: Thu, 28 Jul 2016 07:48:42 +0000 Cc: Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP There is a error message within devm_ioremap_resource already, so remove the DRM_ERROR call to avoid redundant error message. Signed-off-by: Wei Yongjun Acked-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 4e61ea5..1160322 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -285,10 +285,8 @@ static int malidp_bind(struct device *dev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); hwdev->regs = devm_ioremap_resource(dev, res); - if (IS_ERR(hwdev->regs)) { - DRM_ERROR("Failed to map control registers area\n"); + if (IS_ERR(hwdev->regs)) return PTR_ERR(hwdev->regs); - } hwdev->pclk = devm_clk_get(dev, "pclk"); if (IS_ERR(hwdev->pclk))