From patchwork Mon Aug 8 21:24:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 9269765 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BEE54607D6 for ; Mon, 8 Aug 2016 21:24:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE78A205AB for ; Mon, 8 Aug 2016 21:24:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A34CB28113; Mon, 8 Aug 2016 21:24:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4E4E7205AB for ; Mon, 8 Aug 2016 21:24:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF54A6E42A; Mon, 8 Aug 2016 21:24:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yb0-f195.google.com (mail-yb0-f195.google.com [209.85.213.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC2246E425 for ; Mon, 8 Aug 2016 21:24:36 +0000 (UTC) Received: by mail-yb0-f195.google.com with SMTP id x196so3564793ybe.1 for ; Mon, 08 Aug 2016 14:24:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TqThxeH5rFqWoDySxJIQRtI2WdQpVLLmg0iVlZ3RStY=; b=UXo7JT9g1ThEX/e81k/u1Fd+sycav6oswItLlOAeRzsAE9rpk/BZYL0humnKfP3OqV D5JGmZCpt64IvQTrwFAY59uQbvAue5zqHURJEtIa+Hq7tC3Y1pR8lHtv3rru6d+L3ycu jcvouRFxztC79yf0hI0mZxGUuYzjPR06TF5d97oPWNC8zZfOV2yWiFxMTPagZPFe29Bp J7f33vC5Yeq3t3atrCcOvcqyxwxSrf4xKq5nEo/9qgO5q8g0RBfmy5gfujzW3jo1nTRH 2/ROqDcnxjFbdmH+qjVNl8U+ccjD9+cg9OQjuZKyHRbQyKY4kGiGUIm+Qjinbk7W7w7p CSLA== X-Gm-Message-State: AEkoouvlwQh+69Ezlqm1N8IBiHWomGsGQOdRAHAtz9xEjeC8Idb6xiWcZhK4tnXlH8fNrA== X-Received: by 10.37.199.83 with SMTP id w80mr52167732ybe.93.1470691475960; Mon, 08 Aug 2016 14:24:35 -0700 (PDT) Received: from jade.localdomain ([201.82.189.183]) by smtp.gmail.com with ESMTPSA id p21sm14634807ywg.10.2016.08.08.14.24.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Aug 2016 14:24:33 -0700 (PDT) From: Gustavo Padovan To: Greg Kroah-Hartman Subject: [PATCH v2 1/6] staging/android: remove doc from sw_sync Date: Mon, 8 Aug 2016 18:24:17 -0300 Message-Id: <1470691462-19140-2-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1470691462-19140-1-git-send-email-gustavo@padovan.org> References: <1470691462-19140-1-git-send-email-gustavo@padovan.org> Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , pavel@ucw.cz, Gustavo Padovan , John Harrison X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan SW_SYNC should never be used by other pieces of the kernel apart from sync_debug as it is only a Sync File Validation Framework, so hide any info to avoid confuse this with a standard kernel internal API. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c | 26 -------------------------- drivers/staging/android/sync_debug.h | 15 --------------- 2 files changed, 41 deletions(-) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index 115c917..b4ae092 100644 --- a/drivers/staging/android/sw_sync.c +++ b/drivers/staging/android/sw_sync.c @@ -46,13 +46,6 @@ static inline struct sync_pt *fence_to_sync_pt(struct fence *fence) return container_of(fence, struct sync_pt, base); } -/** - * sync_timeline_create() - creates a sync object - * @name: sync_timeline name - * - * Creates a new sync_timeline. Returns the sync_timeline object or NULL in - * case of error. - */ struct sync_timeline *sync_timeline_create(const char *name) { struct sync_timeline *obj; @@ -94,14 +87,6 @@ static void sync_timeline_put(struct sync_timeline *obj) kref_put(&obj->kref, sync_timeline_free); } -/** - * sync_timeline_signal() - signal a status change on a sync_timeline - * @obj: sync_timeline to signal - * @inc: num to increment on timeline->value - * - * A sync implementation should call this any time one of it's fences - * has signaled or has an error condition. - */ static void sync_timeline_signal(struct sync_timeline *obj, unsigned int inc) { unsigned long flags; @@ -122,17 +107,6 @@ static void sync_timeline_signal(struct sync_timeline *obj, unsigned int inc) spin_unlock_irqrestore(&obj->child_list_lock, flags); } -/** - * sync_pt_create() - creates a sync pt - * @parent: fence's parent sync_timeline - * @size: size to allocate for this pt - * @inc: value of the fence - * - * Creates a new sync_pt as a child of @parent. @size bytes will be - * allocated allowing for implementation specific data to be kept after - * the generic sync_timeline struct. Returns the sync_pt object or - * NULL in case of error. - */ static struct sync_pt *sync_pt_create(struct sync_timeline *obj, int size, unsigned int value) { diff --git a/drivers/staging/android/sync_debug.h b/drivers/staging/android/sync_debug.h index fab6639..5b82cf8 100644 --- a/drivers/staging/android/sync_debug.h +++ b/drivers/staging/android/sync_debug.h @@ -20,15 +20,6 @@ #include #include -/** - * struct sync_timeline - sync object - * @kref: reference count on fence. - * @name: name of the sync_timeline. Useful for debugging - * @child_list_head: list of children sync_pts for this sync_timeline - * @child_list_lock: lock protecting @child_list_head and fence.status - * @active_list_head: list of active (unsignaled/errored) sync_pts - * @sync_timeline_list: membership in global sync_timeline_list - */ struct sync_timeline { struct kref kref; char name[32]; @@ -51,12 +42,6 @@ static inline struct sync_timeline *fence_parent(struct fence *fence) child_list_lock); } -/** - * struct sync_pt - sync_pt object - * @base: base fence object - * @child_list: sync timeline child's list - * @active_list: sync timeline active child's list - */ struct sync_pt { struct fence base; struct list_head child_list;