From patchwork Thu Aug 11 09:44:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 9276939 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7BDD860752 for ; Fri, 12 Aug 2016 13:14:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D4A4289E8 for ; Fri, 12 Aug 2016 13:14:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 61E23289EB; Fri, 12 Aug 2016 13:14:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EA27E289E8 for ; Fri, 12 Aug 2016 13:14:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E50F66EB6D; Fri, 12 Aug 2016 13:13:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0048.outbound.protection.outlook.com [104.47.32.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4163F6E1C4 for ; Thu, 11 Aug 2016 09:54:13 +0000 (UTC) Received: from DM2PR03CA0044.namprd03.prod.outlook.com (10.141.96.43) by CY1PR0301MB0602.namprd03.prod.outlook.com (10.160.142.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Thu, 11 Aug 2016 09:54:09 +0000 Received: from BL2FFO11FD044.protection.gbl (2a01:111:f400:7c09::154) by DM2PR03CA0044.outlook.office365.com (2a01:111:e400:2428::43) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.549.15 via Frontend Transport; Thu, 11 Aug 2016 09:54:09 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD044.mail.protection.outlook.com (10.173.161.140) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.557.8 via Frontend Transport; Thu, 11 Aug 2016 09:54:09 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u7B9s5Wt019232; Thu, 11 Aug 2016 02:54:07 -0700 From: Peter Chen To: , , Subject: [PATCH 1/1] Revert "gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle" Date: Thu, 11 Aug 2016 17:44:54 +0800 Message-ID: <1470908694-16362-1-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131153828499508535; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(19580395003)(229853001)(68736007)(4326007)(106466001)(19580405001)(305945005)(48376002)(8676002)(97736004)(11100500001)(47776003)(33646002)(50226002)(626004)(87936001)(7846002)(2906002)(81166006)(81156014)(8936002)(104016004)(5003940100001)(105606002)(50466002)(8666005)(36756003)(189998001)(356003)(92566002)(50986999)(2201001)(5001770100001)(85426001)(77096005)(86362001)(586003)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB0602; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD044; 1:fFKR+UL7N2n2MN+e8uwizZ07tupf7XXLbkYeIIEX0u3DrqbP2oBqwhIS3jmDxDEaHvZ0YSwD6Qk+9uy7TH4eGYNTkdMUjlSr5xwVPO8tLhDlLOwGbE2JcPQaC500mP2j8FPIkdsX1tTO3nV+koKOfUxPQeyB67w+lOKxN4TKyaqTSFElo6tH6tH/ioGbnPlALLJ0H0GnSUdsdUjcubJmg4D6id0/Rsu47wxYkP3dyl9tXqYE1lMZ+Uw2wLlfO1GMJZZEa+r6OFUmlNVUWh48dg6Imb1IgYLNUkGBmZAwNu75ELg4pg4gAnDjKrohZbKni4DDkpKeqq+XuqsuvYV3sjgOg8vf9lqeZYZ7yHXFGeuazswUPXWE5rU+ctAU0Ry/HQYEIccIK8DHTNpPr+uRWCvGER1RW/6BpOZWzJ/087Ante41i3r6xlaQNfqkAq8SLJ0sn/lf/PxOfGORzO9tLa0xU0KILet3qgAlMJWczLCNdHQm2j7x0ff2FkQb3tDI9hpQseLuD6OvC7Bw7eafTpNyQCd2DrN91a8ajuaepyJaK1nrNQsShncR40KsLRMSCOJRNIuV4QywkUILP1YUTsZX7kElNRHczC5w7kdsFlR2ygmXp9zVjfG1Ewj1XM/0gO1akM58sJIXeME2x7b80J0ecFbIvN3zQWszRaJPmcaMcLRBUYkS1Q2R7YIgq/ciL371Qr3twS9IWbupYWfvtBuCJ6WocTqwEG136v0Iu4g= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: df8af9b8-0d5a-4f34-2914-08d3c1cd7115 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0602; 2:S+uzIMZHFQgDiPrZLUBU34vSaCXgCzrH+Qj5+Sgn7U1hwBGvpbyuahG2M/KcPEB2dh9w088cblggF5qs/IbJqAgHbLwqiDsS9y7RfQ5l9HwjaThcE9PUgjyP3jrZX7e39ni/Vr0ui/c5r902sldFEAKhqJ6/7ssEVQjpL5b2b/Er+V5CtIj9yFJgkniEgV0B; 3:3CK6RRukK5EfDVmWyy6OKksjUxF5ncFxGrM6gXEZ+c3NAMdodea9+OAPP8tE9i7Sx8DlQYx2DRv7z92IKWOd7JtnHtHSiMChwM+/KOurk1k+rS5NNP4jimrr/IMnKMQ49/sv3iBGJ31sO77S+SgO5j6m+Zxh1KvlEYHoyNPVqoQH3hxDvZfSJMabMJwrOB07jShlxj91O7a3yofSNTrd/+LUoWZum6IHSixyJmVpEhw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0602; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0602; 25:gmE2pMDYPB9p10fsR/Mavm60+wBwi2a3GwSGrDuS5OphuaB16nG8zHb1z8ekzSsoJG6EqNphm1zLEXEIvYx7HoP2/FPolXoOmBXdd2nf6ClOuFC8SMD7h/LAJfdgjhg8hCBYLZqXx3VOLgTRNOXyiPMq/fu32bexN2gzW3wAPBsxjmO+dWM8UCtFyvJ7o/ryYVJM9TsDm85a7jiS/u+AnfDZL0YJf5Rjn744bbOQYnXoTL+2TBlhHIFbwLnBwAupFJuWnqOH+FYIhv/G+oGNTbSnwcbMgTP21SENHB2rEEp7QD1mG9iDsSl7ebgscusImxHFLOz3/lJqL+pG055Y6/FrDYLXnNrd3jX61BPU/qKzm6Ohzas613VBfz+jTBPDA3D/ATkd7ceJs0aoJOOy7vRUwaD4k6AyhwyDoB3U2mMRGlqcvTMXMe2chZXBOvyjuyqUyLz5wywJYzknLV9201izNgic9Hkf3X2CKfl1nB49EqnlFN+jdoswb7lB7W+MuyPh5iLrr/B2KpjD6tCl8XUh2riu5Y7gLPpXDjIf8op5mUCCikBDOohFKeuE2elchaU3/q5YiNduwrkyrrZEPbaoaFjIsc5sX//27PHi2/jTgGl5/fgnDgvUoOQG5poJji51HnAbh0txkmq4c52B0wcjBe5/FcJCOh9X6/k3W6GiFY6KfyZXHqqhHROvLvd8+NjpBmC63NXsXLscupR3DQ==; 31:h7Oydcrvrtzn9dG3PtBXnOMg0JIMoFpfEIJE7iUEIEHFENVI3dGg+x/95L2migqBfGDyir6Nphq1M+vg+3MkMqqu6wrRQGpLuytO5DN3jYXR6dTaEVofWkJGC4SMQqZLPOXQL19pTWnoIbBlJHtAe6WMdDkE+E56wRIDTsBEi0rHBchK7Zw2Me5iq19RceIUVX8/MxqgLMAVclL5oTyNgTe5Yz9mFiaDhubQyxf8O/E= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(31051911155226)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040171)(601004)(2401047)(13024025)(13017025)(13015025)(13018025)(13023025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:CY1PR0301MB0602; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB0602; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0602; 4:ymBh4AUJq++YqL3RfDD316p8sFWQIzJ85BJNnRi+OdlvnJZADCkBDisZeI44QtInQn6bIAyJZKkO2CggZ5QWdwLUiUA+BnNVXS4jsn7Ic/w0/U0BN2gOyNzlwrRUL95AHieVlymQrYvGQNw9YKQ+4cilJ5IWEP1drPXB1NZ1Nu56iv+pqPUqieQ3eEj/qUjHa9hGk9+pDV+Hc626QNReFdG2fIBJ4zOsUcAG77BqhxKe+XIyvTN7lhyvdOX6S48ztz1neb0BD0JNP3E7q3NbMnQLlzXs3FeDl/9+REOeTQMhum/EQAIx52trdXv6QsWHh/sp9r6vG26H2zITErvhYexaFTUg8HoK9Z4zvsKbyjqFBhOpR5K8QclbJBnyk5X4ceh2XKDDsYJwGwdul5KW8/FJnKefhAOTu5Yp3iT7lJa7aJHKv/gKcQweUG+q2oT93wYjc0RcIAhZzCEzjdDgmVLe6YMITRJdpd6lTxeST7SWJHbg5ebBtPjuK8DynnZaGtPRCnqNctrcBTOtLIv2lOJEJOBr9pTjUWR34iZ1f84UW77UP0yzdrkfHAkC5qeS X-Forefront-PRVS: 0031A0FFAF X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB0602; 23:hD2otse2I86gRQo2U0aNhwPGDVkTSI59UIJRnpf?= =?us-ascii?Q?XgU2Zy5U1iFuK8Tsw2UUWZ7CSqgCzlfVbdgeiudddUJZY3B4fcZkV/sHeznj?= =?us-ascii?Q?6fpr+lG3upGW25qfcxB0Reeb7vrF6tekTGmC+QpXf+dJQBRypUy0RKFuOynP?= =?us-ascii?Q?YvtkI+K9lDQcSuM3jCc/VqIFpOgRYD7OvpMlT6xhTosh8LYRBwSLo3CdKcr5?= =?us-ascii?Q?hpIsIDCx9Dds7jsjI+x/lYUoziTn63pesGUGK1DHd98FGzHs/VQGhG05KQCG?= =?us-ascii?Q?QI9FQmj8zUUZIbCQLteGrG7d5jDJ14+e8tqIzp8AUclcJwfDCtZ6wmy3QQEg?= =?us-ascii?Q?n6zaP+Ua6VTPM0jsLu94P5zlo4Vgqopc0jwoJiFaNkK+42p9roG1z0jkAP4z?= =?us-ascii?Q?uLc4aDM5084TjDdBrA55yAWTYkIyrTxYSdLt19CQASSQkEiE/0KDMNYKgiSs?= =?us-ascii?Q?mVoBItdGpZpnnC0WaV+BiFFK3Lp/CtbGt0zMQaSRUydgyD5XgvXtjhwI7f5C?= =?us-ascii?Q?jm6d69dcAEIEntN02ZqVk4hH2JKDznBaAsKc+EOQNaMUOK+o9z9jydB1BmB5?= =?us-ascii?Q?dkD2jGjrRCbQmgvluYKqpP6L3/fpa7jn4g/Br0mvTR0t0drnScJ3n+9FlzxJ?= =?us-ascii?Q?JYVOS1rvMo/nJRb6TzGMn1KNRh9z/bobbmp/TqMRpmgwzNeg2zqLh7iGP1c1?= =?us-ascii?Q?fBxYVous4Ag59ozEYxUwRfpEed7q9kXVSkcT7RUrooDmwuzSXCimo6j7mZND?= =?us-ascii?Q?vE5wZ4Y0URFllmnecAFBCxnQubC24RaaSfwUMCd129kY69gnCAP4rRsv+W5D?= =?us-ascii?Q?+e6PrO4LyXyjgAll1/gXq7jVQjHy5NUV9IphehqUTKwHUfDNzsdboKLd4eLz?= =?us-ascii?Q?eyS967KZxuWD7kVAcGFukHKr87ar0LAhhLzBgacWprNV7u1HecNvHJG82SBf?= =?us-ascii?Q?Fg3gVoArdYwgBVmL0EpiZ62uriEzjBk3uN3SQOxMUEj0NXLnvMB4s4P51kA5?= =?us-ascii?Q?/828Btw9QLsdEFXp9uVdfYjdh8Eax1KJ970q3p3wFi0gHhzCD3e7jPDnhMZH?= =?us-ascii?Q?59evCEiVnPbuYvx2SEjdazFGJpjBRsfpd3lNZS6SD/XFo66w/jz4OdK4z+Uo?= =?us-ascii?Q?YXVWNa+KoZ0I=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0602; 6:mBw9rJL/LUj/+7qfT5DV3ICgj5ml9f5JYkV9ptehKZEErippzNsPyjMmmOSigOz9By7CzHaT2wUBhImM5Qbnz1s4dVIdNcZgKNEhOePNnrI0+Q1Mlb9QYFX8vJZTggKj16zXCNSltcZDBSj5N6taY53heToh5o5+vtN1ETGU3FCtqPUXxu9aY/X80c0mOoAAXmd53tMeNeESF3JqcO1kFrgPrSOyfwznafJx1Syf1GalbQ0L6iy19LAU2numiY264s5f7G4HKl8XO13zM7nzfEyE4QvST9LYkzqDC1hah7s=; 5:mnYjkEkoOszebAu5rOxLWi2VbSkavbYLbaval58iHQJaoPzYnyTbPt6l3GHtWP4DjUUF7Ha54z9jLvGXz/X8Micfxrwsquili18pZncFyDT0uHlbw4hf3il5e9qmro2T9DWEfzHJ5/tQQ1/BZGVTafDQZOLygT4AieCA07CmFMw=; 24:PKl5AW/NZpAyKC3FcJoeKsge1OMaIA1rDttQPyFZMjvEeTGnrzP+TtZWARG5QhhpMqdJFauou1Ixgt64TDl/QMsXwJMP/5T9NRvRDlhrtkc=; 7:o1jtrOC2cMc+RKO+/JrcTeWAuq6z1fJfPlMTrCks8OAIMMuzRA/fJxqFU+mmM0jxOWz+PwOg/hPt1zhYZffAEYDaWHFr+xTKo5EvxewktBgFcr7C2LbSmgeNI5bHOX29Rr5H8V87i+du/5PcmP42p1VVFOhjUJ/XXD661pIFzWjF5d4kVhUAXeJEphGFIVYZFfs8JN8kwxcFvFfYBLFNIe8pQ+8yBE9c64DU4BjoosRYVW2BaCVV0L5H8LvrkfUF SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2016 09:54:09.7168 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0602 X-Mailman-Approved-At: Fri, 12 Aug 2016 13:13:55 +0000 Cc: Peter Chen , dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f. The of_get_next_parent will drop refcount on the passed node, so the reverted patch is wrong, thanks for Tomi Valkeinen points it. Cc: Tomi Valkeinen Signed-off-by: Peter Chen --- drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c b/drivers/gpu/drm/omapdrm/dss/dss-of.c index e256d87..dfd4e96 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss-of.c +++ b/drivers/gpu/drm/omapdrm/dss/dss-of.c @@ -125,16 +125,15 @@ u32 dss_of_port_get_port_number(struct device_node *port) static struct device_node *omapdss_of_get_remote_port(const struct device_node *node) { - struct device_node *np, *np_parent; + struct device_node *np; np = of_parse_phandle(node, "remote-endpoint", 0); if (!np) return NULL; - np_parent = of_get_next_parent(np); - of_node_put(np); + np = of_get_next_parent(np); - return np_parent; + return np; } struct device_node *