From patchwork Wed Aug 17 21:10:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 9286703 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 70F8A60839 for ; Thu, 18 Aug 2016 01:01:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61C8229005 for ; Thu, 18 Aug 2016 01:01:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 565AC292BF; Thu, 18 Aug 2016 01:01:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E820428AFB for ; Thu, 18 Aug 2016 01:01:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 159486E977; Thu, 18 Aug 2016 01:01:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4FC5E6E929 for ; Wed, 17 Aug 2016 21:10:27 +0000 (UTC) Received: by mail-pa0-x230.google.com with SMTP id fi15so39436008pac.1 for ; Wed, 17 Aug 2016 14:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=7xasqhT10Xax/dtvp5Ff47uRhntsZXlfo0LC3eMcn0M=; b=bRhs57hANK3DLNMQY/B+FOm/as6WbnV4RNxw0jpB0d6ron5INIo27xfTa0Owzd/gQj 4cs2NEYG0Cvjl5sUHpar4XLh4KJaDmghX5oNnZAamMLe8IYPJl7h7GGkhe2C0Se7AW3D iSrFhcq5THMcRfJHpik+YjRQ6n20v0lhJsSRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7xasqhT10Xax/dtvp5Ff47uRhntsZXlfo0LC3eMcn0M=; b=QAJ//MPK6/pY2FRyixlSlyHOTCxdmJdDMcyEHcVhzbZWSV1r4m1qEA9RRY9ReJE45B ZjxjwmAtVvb1p+wFWtl74D/YktukGtll9ua+8zwFwcGllN8f4k1OtGGEtvFV5G1xc1HN IAh/KtgPeW2GSuqgNkgzY9qGdC47Lp8QaVecp87dwPOEWpgvgnlLJ3BzHiFuNd3bZOrg 0kGwte1PcpCiQsg9qVkMGjk1lOtzJ5iXqoRufdcoLJzKInyH52MHVNwOdbYL8jSJPOYh bP23ot0eK6nqPAoVn0jqqi6HMx8jBJoRLqrEpjDcPh6Lo/b+wlXPdCSlBF1RzdH2YBxU 5JxQ== X-Gm-Message-State: AEkoouv1iU8YE531VYukYmctYcoRnJ+qjmsgeyTO03Ku8danMgvwM0bn5B6/r6ZCYjCSOd7+ X-Received: by 10.66.165.67 with SMTP id yw3mr4147816pab.8.1471468226930; Wed, 17 Aug 2016 14:10:26 -0700 (PDT) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id i137sm15827837pfe.64.2016.08.17.14.10.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Aug 2016 14:10:25 -0700 (PDT) From: Brian Norris To: Mark Yao Subject: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print Date: Wed, 17 Aug 2016 14:10:09 -0700 Message-Id: <1471468209-31192-1-git-send-email-briannorris@chromium.org> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 X-Mailman-Approved-At: Thu, 18 Aug 2016 01:01:14 +0000 Cc: Brian Norris , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP This driver is the only user of of_drm_find_panel() which prints an error before doing probe deferral, yielding messages like this on boot, before eventually succeeding: [ 2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel ... [ 4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel ... Let's just drop the message. Signed-off-by: Brian Norris --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index 89aadbf465f8..045fcc46827c 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev) panel = of_drm_find_panel(panel_node); of_node_put(panel_node); - if (!panel) { - DRM_ERROR("failed to find panel\n"); + if (!panel) return -EPROBE_DEFER; - } } dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);