From patchwork Sat Sep 10 12:33:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9325027 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D1C456077F for ; Sat, 10 Sep 2016 16:11:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2BA4297E3 for ; Sat, 10 Sep 2016 16:11:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B755F297ED; Sat, 10 Sep 2016 16:11:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A9266297E9 for ; Sat, 10 Sep 2016 16:11:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 289BF6E2C0; Sat, 10 Sep 2016 16:11:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-x242.google.com (mail-pa0-x242.google.com [IPv6:2607:f8b0:400e:c03::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF71D6E171 for ; Sat, 10 Sep 2016 12:33:36 +0000 (UTC) Received: by mail-pa0-x242.google.com with SMTP id bu8so516198pab.1 for ; Sat, 10 Sep 2016 05:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jUROFzJLF7d1gfF5Ktx5XB7S+aeNcG+4kkBfOCJduAc=; b=ii2jkFIygd+c32MNbz0Bemklwv21cfpsiNSC/vSJFzet0C7ZtoRWlJnPPDu/yQEIgI bxBLiSurbfqni190hl9BseBNWCz+Ph93ReVBNT7WpcVaKQGUl1K3Vy7aZ4JrwsrOHsQA 6oxoP3T3YeFj70/bzdRSFtg6iou/rs+i4gMRrKENwfyLDHg69qDsDshTTvjvZMlOU3hW oii9nyI1th82AzsJrCdtwVN3QtWDNORBYZu2J0mwZQ7eIGflOriwEIoDmad6pbGslDA/ iIOAcUb4DrtJCFeaDdG4WBZbaeVnhhxdZPOC5v8XCMWR5Rvzf8pf4UD+fZeMngiDuahG 8Y0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jUROFzJLF7d1gfF5Ktx5XB7S+aeNcG+4kkBfOCJduAc=; b=Cw/cK/28/JLo+Kd8gWESJBSAnwjjJsphJnPrWX0zm9fdVB7NYPeeJrSmcPhUQWEFq+ 6o+zzkZK3Q/O3ctwJA5+f/5zRNVLx2Xr8KFACx5FvFwZ6RCTts4ia4OtsgJSOHtvC/Og jVRoVu3Y8P5H3hKAVyI4awkMTZbCjAd/iLJudx4saUGvDH/a1HZwGYJ7zFJmH9oIt8Ge dfAkWcLh3kvzPzcH0oL13ixvMqqvGJSLBg+sJUSID+yEpvhqyRcp7y/6ARbEw3G4hUrt SVcSjnd29iA5naLZnLupqR9Xg7aiwfA3WO8Gqx3VJ9cs48S31BxC7wQbCrmImnyIcaTF 3MxQ== X-Gm-Message-State: AE9vXwMwfCSUPQ71JnomsMmbk5J57Uw5tJfGWcpU/zRfYqTvuFKldYAhHI/JE1Eaj6nJsQ== X-Received: by 10.66.86.198 with SMTP id r6mr15823300paz.72.1473510816568; Sat, 10 Sep 2016 05:33:36 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id r16sm1309681pfi.76.2016.09.10.05.33.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Sep 2016 05:33:36 -0700 (PDT) From: Wei Yongjun To: CK Hu , Philipp Zabel , David Airlie , Matthias Brugger Subject: [PATCH -next] drm/mediatek: Remove redundant dev_err call in mtk_drm_probe() Date: Sat, 10 Sep 2016 12:33:29 +0000 Message-Id: <1473510809-26606-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 10 Sep 2016 16:11:14 +0000 Cc: linux-mediatek@lists.infradead.org, Wei Yongjun , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 72c1ae4..f4f90e8 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -365,12 +365,8 @@ static int mtk_drm_probe(struct platform_device *pdev) mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); private->config_regs = devm_ioremap_resource(dev, mem); - if (IS_ERR(private->config_regs)) { - ret = PTR_ERR(private->config_regs); - dev_err(dev, "Failed to ioremap mmsys-config resource: %d\n", - ret); - return ret; - } + if (IS_ERR(private->config_regs)) + return PTR_ERR(private->config_regs); /* Iterate over sibling DISP function blocks */ for_each_child_of_node(dev->of_node->parent, node) {