From patchwork Thu Sep 15 03:25:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9332901 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C0ED5607FD for ; Thu, 15 Sep 2016 07:31:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B747F291E8 for ; Thu, 15 Sep 2016 07:31:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AC09229336; Thu, 15 Sep 2016 07:31:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4DB90291E8 for ; Thu, 15 Sep 2016 07:31:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 238636E800; Thu, 15 Sep 2016 07:31:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07A926E163 for ; Thu, 15 Sep 2016 03:26:06 +0000 (UTC) Received: by mail-pf0-x242.google.com with SMTP id 128so1605957pfb.0 for ; Wed, 14 Sep 2016 20:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MpxIKzvEkoKMr9iPAjnimyRZxOmT135tk0+BEynoU50=; b=d060OooQR/IbIFpViLTOLx97bqI9Sxb7nbfsjEeAJ/6YwS8QLDmkUrlBFtrvvheIQG 1zJazFSWWIkYNbejwn5YwhYy0uFEtmHdfeiFspMzgmq8ymwwUaCtRQwGNcz+pOjFsFqP s2frIH44TcdW+fX2oyaL4bsEZ9IfWBggfPFI0pKiIW4Pvgyn0ECQP1k1kzVcMpc5PgSp rAwcBZ0WbRXq4oliH3tzYysVfc1UP8KKc597/fKGH3KgBZEUuc0DYFNTTp6jhH5sj7js PEQZFw+/2o15LWyrmbG+PVofUYQWNj+JdR5z4jSzkLFBC9bERhRFWc8prgN7LmC2YfDt pcAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MpxIKzvEkoKMr9iPAjnimyRZxOmT135tk0+BEynoU50=; b=T8AfHscy+aCimbxcEW5WRZ+4x4uueS/uAhJBNXCn+E2SRxHtf8ecVZsjh1A6ClImva /dhh5G7Be3xg5xNxW23JV+2254ECJaGf3/+o8LAOERD6oiM4e7TMuLuaPa0LSbqYBk4b RurfefGZjofoavCoHqUNuhmgAZEz8B/ljqmppZbkGYZ/pG9E2ldEAEC44heD1C2eSUvQ wdii0q6h6jz+GBaBqmK//0WJuTPjp9wwpCqSUv8XFAsLGA5KakxDldAQKnzb/EXTLbyP 8mErTfswEbXFCbMlb+3nxRpNCSD0dSBBd76OEUCPCa7DFY3+pwZaZObwnEnCBMhp8FKp nr/Q== X-Gm-Message-State: AE9vXwPUYB5dAXWX0UncUmZRm+KgY4xrfMNTbcDdEYZHy6X3WkXinGPkbK4gETdLlLmLOQ== X-Received: by 10.98.11.156 with SMTP id 28mr10663384pfl.165.1473909964527; Wed, 14 Sep 2016 20:26:04 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id 3sm41039393pfz.33.2016.09.14.20.26.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2016 20:26:04 -0700 (PDT) From: Wei Yongjun To: Maxime Ripard , David Airlie , Chen-Yu Tsai Subject: [PATCH -next] drm/sun4i: backend: remove redundant dev_err call in sun4i_backend_bind() Date: Thu, 15 Sep 2016 03:25:58 +0000 Message-Id: <1473909958-30216-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 15 Sep 2016 07:31:29 +0000 Cc: Wei Yongjun , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c index 91a7022..fcd4e91 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c @@ -288,10 +288,8 @@ static int sun4i_backend_bind(struct device *dev, struct device *master, res = platform_get_resource(pdev, IORESOURCE_MEM, 0); regs = devm_ioremap_resource(dev, res); - if (IS_ERR(regs)) { - dev_err(dev, "Couldn't map the backend registers\n"); + if (IS_ERR(regs)) return PTR_ERR(regs); - } backend->regs = devm_regmap_init_mmio(dev, regs, &sun4i_backend_regmap_config);