From patchwork Tue Sep 27 13:36:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 9351883 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 125E86077B for ; Tue, 27 Sep 2016 13:36:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0219E28F6C for ; Tue, 27 Sep 2016 13:36:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EAE1228FB2; Tue, 27 Sep 2016 13:36:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B130728F6C for ; Tue, 27 Sep 2016 13:36:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6423988E07; Tue, 27 Sep 2016 13:36:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9662F6E6A7 for ; Tue, 27 Sep 2016 13:36:41 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OE600N9V0H23870@mailout1.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 27 Sep 2016 14:36:38 +0100 (BST) Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20160927133638eucas1p17cb08787834f976539cb9e88bf998129~4MZYAXhbS2082920829eucas1p1d; Tue, 27 Sep 2016 13:36:38 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges5.samsung.com (EUCPMTA) with SMTP id 22.BD.19540.5E57AE75; Tue, 27 Sep 2016 14:36:38 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20160927133637eucas1p149185d3cd9a657fa5a9ff6986db25f5f~4MZXXfYMs1941519415eucas1p1z; Tue, 27 Sep 2016 13:36:37 +0000 (GMT) X-AuditID: cbfec7f5-f79ce6d000004c54-88-57ea75e5ba99 Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 87.C7.10494.9B57AE75; Tue, 27 Sep 2016 14:35:53 +0100 (BST) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OE600AGC0GSQO20@eusync2.samsung.com>; Tue, 27 Sep 2016 14:36:37 +0100 (BST) From: Andrzej Hajda To: Daniel Vetter Subject: [RFC PATCH 3/6] drm/malidp: use helper for arming crtc completion event Date: Tue, 27 Sep 2016 15:36:16 +0200 Message-id: <1474983379-852-4-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1474983379-852-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsWy7djPc7rPSl+FGxw8x2hxa905VouNM9az WvzfNpHZ4srX92wWa4/cZXdg9dj7bQGLx/3u40wefVtWMQYwR3HZpKTmZJalFunbJXBlPGm4 x1bwlKtiTfM7xgbGeZxdjJwcEgImEsdetzBB2GISF+6tZ+ti5OIQEljKKPHx4F8o5zOjxKed J4GqOMA6/nUrQ8SXMUos/d7GCuH8Z5RY9ucqO8goNgFNib+bb7KB2CICyhL9m+eAFTELrGeU WPNsAiNIQlggSOLOx/tgRSwCqhLLzywGi/MKOErsmPGMEeImOYmb5zqZQWxOASeJiS9+MoMM khC4zSZx4OYPZoiTZCU2HWCGqHeReL9yEguELSzx6vgWdghbRuLy5G4WiN5uoHf6T7BDOFMY Jf59mAHVbS1x+PhFVhCbWYBPYtK26VALeCU62oQgSjwkzr+8CTXUUeLTs/lgDwgJTGWUWHyt egKjzAJGhlWMIqmlxbnpqcWmesWJucWleel6yfm5mxiB0Xn63/GvOxiXHrM6xCjAwajEw8tQ 9CpciDWxrLgy9xCjBAezkgjvuWKgEG9KYmVValF+fFFpTmrxIUZpDhYlcd49C66ECwmkJ5ak ZqemFqQWwWSZODilGhhXiDMo3jP3EY2M49kQ9uud0oFK257DoamrWHqehq6Z/PZq2ZFav2mx D+vD953Rvn6kj/PD8Ycnv4jYC5j5bDmz/9RFX/VfITMcpOecuNZ3WGCVWXa63ErlrBTNRW9U v63ScZaXm7FnsWfTSrUrVyokMszU4nbNqT3dJH98L/8y0Qgz/m/H3hYqsRRnJBpqMRcVJwIA 3N8fVcoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t/xK7o7S1+FG1xot7G4te4cq8XGGetZ Lf5vm8hsceXrezaLtUfusjuweuz9toDF4373cSaPvi2rGAOYo9xsMlITU1KLFFLzkvNTMvPS bZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CW8aThHlvBU66KNc3v GBsY53F2MXJwSAiYSPzrVu5i5AQyxSQu3FvP1sXIxSEksIRRYs3s7cwgCSGBRiaJN6sFQGw2 AU2Jv5tvsoHYIgLKEv2b57CCNDALrGeU2DDlNiPIUGGBAInje2pAalgEVCWWn1nMCGLzCjhK 7JjxjBFimZzEzXOdYPM5BZwkJr74CbXLUeLe5BNMExh5FzAyrGIUSS0tzk3PLTbSK07MLS7N S9dLzs/dxAgM0W3Hfm7Zwdj1LvgQowAHoxIP74r8V+FCrIllxZW5hxglOJiVRHjPFQOFeFMS K6tSi/Lji0pzUosPMZoCHTWRWUo0OR8YP3kl8YYmhuaWhkbGFhbmRkZK4rxTP1wJFxJITyxJ zU5NLUgtgulj4uCUamDMit28OfLjVSnOlT4L1aosxL7e8Bfzq+N4enCZtOmnScnb6ia6eO7e +ENpSeivizMf+l3KmXJBeNFfA2H3/MkdKw0fMt12cN3iaB5zbKnjC6bgok/1S/j2WH2uOPEv 4+Nv+1lXkhKWN61Xnj+N02dxfcEWH8e5jpubzynzslycq1Hyep+N5n5OJZbijERDLeai4kQA DANnF2cCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160927133637eucas1p149185d3cd9a657fa5a9ff6986db25f5f X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160927133637eucas1p149185d3cd9a657fa5a9ff6986db25f5f X-RootMTR: 20160927133637eucas1p149185d3cd9a657fa5a9ff6986db25f5f References: <1474983379-852-1-git-send-email-a.hajda@samsung.com> Cc: Marek Szyprowski , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Replace custom code with core helper. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/arm/malidp_drv.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 82171d2..e8bd8b0 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -63,7 +63,6 @@ static void malidp_output_poll_changed(struct drm_device *drm) static void malidp_atomic_commit_hw_done(struct drm_atomic_state *state) { - struct drm_pending_vblank_event *event; struct drm_device *drm = state->dev; struct malidp_drm *malidp = drm->dev_private; int ret = malidp_set_and_wait_config_valid(drm); @@ -71,17 +70,7 @@ static void malidp_atomic_commit_hw_done(struct drm_atomic_state *state) if (ret) DRM_DEBUG_DRIVER("timed out waiting for updated configuration\n"); - event = malidp->crtc.state->event; - if (event) { - malidp->crtc.state->event = NULL; - - spin_lock_irq(&drm->event_lock); - if (drm_crtc_vblank_get(&malidp->crtc) == 0) - drm_crtc_arm_vblank_event(&malidp->crtc, event); - else - drm_crtc_send_vblank_event(&malidp->crtc, event); - spin_unlock_irq(&drm->event_lock); - } + drm_crtc_arm_completion_event(&malidp->crtc); drm_atomic_helper_commit_hw_done(state); }