From patchwork Tue Oct 18 14:27:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 9382181 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6E2B160839 for ; Tue, 18 Oct 2016 14:27:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FA2E2944E for ; Tue, 18 Oct 2016 14:27:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 52A8829627; Tue, 18 Oct 2016 14:27:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 427DD2944E for ; Tue, 18 Oct 2016 14:27:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E3E76E21E; Tue, 18 Oct 2016 14:27:44 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D11F6E73D for ; Tue, 18 Oct 2016 14:27:43 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id y38so7425721qta.3 for ; Tue, 18 Oct 2016 07:27:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z5ywm+B4q5e3FHfAR1xtmifNJvzQm+sxxOBuVADO2f4=; b=GNcDHl/itHsYswzN/AsZKiW1LhZQJy/6z1DuB+CH0P1O52B7RhR52T8goYLB7N03Yc Y+uAaS5VDvxUDqcK134fXrWdycxq6eiQH3lVY1RgFXBP4DOYvPrFsqpDOHeu/EVfVLXi VGGbUYN7C0HdwlatQK0gxuwB5025jHvnXhex8MZcxnsMVyDO3oLR08bRGIF7x44GYQ8N yVzOcbzRL7TU5PlOoiIW8KKMYAypGuOmVQsL2OXFPAhrQ3h1kVsAWLVwh3o53mn+MZmd qfKMpe4/K5qjV69qiQHs61lNA+gJTfF1PYMzIPaFFwOmhGzC27vY3qxoBYiI5JUDIhoa +9Lw== X-Gm-Message-State: AA6/9RkrDdT2QUPk84o6sOl9L+IZ0OcpHWj6avpZCmDg3CO2XAYCMqP+EgnPkB8IgIcQOw== X-Received: by 10.200.42.1 with SMTP id k1mr831993qtk.128.1476800862104; Tue, 18 Oct 2016 07:27:42 -0700 (PDT) Received: from jade.localdomain (189-46-184-178.dsl.telesp.net.br. [189.46.184.178]) by smtp.gmail.com with ESMTPSA id m201sm7388329qke.1.2016.10.18.07.27.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Oct 2016 07:27:39 -0700 (PDT) From: Gustavo Padovan To: dri-devel@lists.freedesktop.org Subject: [PATCH v2] virtio-gpu: fix vblank events Date: Tue, 18 Oct 2016 12:27:28 -0200 Message-Id: <1476800848-27682-1-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1476359705-12589-1-git-send-email-kraxel@redhat.com> References: <1476359705-12589-1-git-send-email-kraxel@redhat.com> Cc: Gustavo Padovan , Gerd Hoffmann X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that. v2: update to use new drm_atomic_helper_commit_planes() API. Signed-off-by: Gerd Hoffmann Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index 6848651..64facc8 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state) drm_atomic_helper_commit_modeset_disables(dev, state); drm_atomic_helper_commit_modeset_enables(dev, state); - drm_atomic_helper_commit_planes(dev, state, - DRM_PLANE_COMMIT_ACTIVE_ONLY); + drm_atomic_helper_commit_planes(dev, state, 0); drm_atomic_helper_commit_hw_done(state);