| Message ID | 1484843100-16284-5-git-send-email-shawnguo@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Freitag, den 20.01.2017, 00:24 +0800 schrieb Shawn Guo: > From: Shawn Guo <shawn.guo@linaro.org> > > It adds bindings doc for ZTE VOU TV Encoder device. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > Documentation/devicetree/bindings/display/zte,vou.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/zte,vou.txt b/Documentation/devicetree/bindings/display/zte,vou.txt > index 740e5bd2e4f7..9c356284232b 100644 > --- a/Documentation/devicetree/bindings/display/zte,vou.txt > +++ b/Documentation/devicetree/bindings/display/zte,vou.txt > @@ -49,6 +49,15 @@ Required properties: > "osc_clk" > "xclk" > > +* TV Encoder output device > + > +Required properties: > + - compatible: should be "zte,zx296718-tvenc" > + - reg: Physical base address and length of the TVENC device IO region > + - zte,tvenc-power-control: the phandle to SYSCTRL block followed by two > + integer cells. The first cell is the offset of SYSCTRL register used > + to control TV Encoder DAC power, and the second cell is the bit mask. I don't know much about this platform, but shouldn't this be handled with a proper power domain driver, rather than bashing bits directly? Regards, Lucas
On Thu, Jan 19, 2017 at 06:11:17PM +0100, Lucas Stach wrote: > Am Freitag, den 20.01.2017, 00:24 +0800 schrieb Shawn Guo: > > From: Shawn Guo <shawn.guo@linaro.org> > > > > It adds bindings doc for ZTE VOU TV Encoder device. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > --- > > Documentation/devicetree/bindings/display/zte,vou.txt | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/zte,vou.txt b/Documentation/devicetree/bindings/display/zte,vou.txt > > index 740e5bd2e4f7..9c356284232b 100644 > > --- a/Documentation/devicetree/bindings/display/zte,vou.txt > > +++ b/Documentation/devicetree/bindings/display/zte,vou.txt > > @@ -49,6 +49,15 @@ Required properties: > > "osc_clk" > > "xclk" > > > > +* TV Encoder output device > > + > > +Required properties: > > + - compatible: should be "zte,zx296718-tvenc" > > + - reg: Physical base address and length of the TVENC device IO region > > + - zte,tvenc-power-control: the phandle to SYSCTRL block followed by two > > + integer cells. The first cell is the offset of SYSCTRL register used > > + to control TV Encoder DAC power, and the second cell is the bit mask. > > I don't know much about this platform, but shouldn't this be handled > with a proper power domain driver, rather than bashing bits directly? There is a power domain controller (PCU) on ZTE platform which controls power for a list of hardware blocks [1]. TVENC DAC is not on the list. Rather than PCU, it's controlled by SYSCTRL block which contains various control bits for various aspects of the system. Shawn [1] https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.git/commit/?h=zte/pm-domains&id=eea1d99b900fe19dce3042dac555c270221be147
On Fri, Jan 20, 2017 at 12:24:59AM +0800, Shawn Guo wrote: > From: Shawn Guo <shawn.guo@linaro.org> > > It adds bindings doc for ZTE VOU TV Encoder device. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > Documentation/devicetree/bindings/display/zte,vou.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/display/zte,vou.txt b/Documentation/devicetree/bindings/display/zte,vou.txt index 740e5bd2e4f7..9c356284232b 100644 --- a/Documentation/devicetree/bindings/display/zte,vou.txt +++ b/Documentation/devicetree/bindings/display/zte,vou.txt @@ -49,6 +49,15 @@ Required properties: "osc_clk" "xclk" +* TV Encoder output device + +Required properties: + - compatible: should be "zte,zx296718-tvenc" + - reg: Physical base address and length of the TVENC device IO region + - zte,tvenc-power-control: the phandle to SYSCTRL block followed by two + integer cells. The first cell is the offset of SYSCTRL register used + to control TV Encoder DAC power, and the second cell is the bit mask. + Example: vou: vou@1440000 { @@ -81,4 +90,10 @@ vou: vou@1440000 { <&topcrm HDMI_XCLK>; clock-names = "osc_cec", "osc_clk", "xclk"; }; + + tvenc: tvenc@2000 { + compatible = "zte,zx296718-tvenc"; + reg = <0x2000 0x1000>; + zte,tvenc-power-control = <&sysctrl 0x170 0x10>; + }; };