From patchwork Mon Jan 30 11:05:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 9544819 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8477360417 for ; Mon, 30 Jan 2017 11:05:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 663B72837F for ; Mon, 30 Jan 2017 11:05:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5B0DD28389; Mon, 30 Jan 2017 11:05:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ECA7E2837F for ; Mon, 30 Jan 2017 11:05:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02BF96E3ED; Mon, 30 Jan 2017 11:05:34 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 012586E3DB for ; Mon, 30 Jan 2017 11:05:27 +0000 (UTC) Received: by mail-wm0-x232.google.com with SMTP id b65so27421340wmf.0 for ; Mon, 30 Jan 2017 03:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VylGbsj3TnkV6N87T91qqKquQbtwwbArzs2DAch8c34=; b=ZrkpKedAveL1q3iOgozlDm+/zXxpS8ksgU6IPGd6hYm8YLzJ9eemZIITtgMYIb0cw+ QaB0uZ/qGL1pqkK/MOgYNdzPYd8Fy6l71rsAV2DX/+G2IXy6VUeiu2MrNvjpw3e66697 ef8cDaFgxktcPfrxYOQMi6/OtgbHzP5XOXuF3GwWgu0gFdXVUGCESnl2Xk7H7Dz+1wfj wD8mb5bEAnbCmmfCd7Q279Ipk5dx3rQC8uZFJqNTu0sxA0WH7OJAskN/vnwwQWFm0+RP zJpkHfleLs6N0id3HG3ANGx4B0bNrtrm2v/kFpWCurwJeSH/F74sgQ9h+qhdCA+Fe3NM w7Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VylGbsj3TnkV6N87T91qqKquQbtwwbArzs2DAch8c34=; b=SsZqnEgJt6uiMvXSDW1vus9H7CwJsvG5aGf3iVjvXREkq/H88Hg7NGc2BAIbO5l2lb RyE8qPSGXzqNu82BDOShiD8Z9ScKHqTHANUXCXw8+g8TEhnB2HlojtpgfIpH5hEdOuMB PqWwEn2S/BK16SVchOQCkxrR6jgKD6MiooWSdPraaN8yTI3qy4YKg8VtepV6jIKZ/04E Q13Feh+b4Mj7YtDDq+hTsfenEFYv2qDpt6xRSURqtN69YGhclcxgJXwUdiMEp3WSeXi3 OHH0P//lzE6N9QgoOUHlhtycuXBNhDhwkwUO+caIU5Jc7ryFD8Fu7dI58W3HoQyohtZ8 B7MA== X-Gm-Message-State: AIkVDXJ0+5X0xRwmmAUfpwN7CvuKxj842f6oAnn+x7+Nof9I83tx8cMC6h92J85mLezaIv6k X-Received: by 10.28.28.143 with SMTP id c137mr12881064wmc.115.1485774325405; Mon, 30 Jan 2017 03:05:25 -0800 (PST) Received: from localhost.localdomain ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id k195sm18165651wmd.7.2017.01.30.03.05.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Jan 2017 03:05:24 -0800 (PST) From: Neil Armstrong To: dri-devel@lists.freedesktop.org, laurent.pinchart+renesas@ideasonboard.com Subject: [PATCH 3/4] drm: bridge: dw-hdmi: Enable CSC even for DVI Date: Mon, 30 Jan 2017 12:05:17 +0100 Message-Id: <1485774318-21916-4-git-send-email-narmstrong@baylibre.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1485774318-21916-1-git-send-email-narmstrong@baylibre.com> References: <1485774318-21916-1-git-send-email-narmstrong@baylibre.com> Cc: Jose.Abreu@synopsys.com, linux-amlogic@lists.infradead.org, kieran.bingham@ideasonboard.com, linux-kernel@vger.kernel.org, Neil Armstrong X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP If the input pixel format is not RGB, the CSC must be enabled in order to provide valid pixel to DVI sinks. This patch removes the hdmi only dependency on the CSC enabling. Reviewed-by: Jose Abreu Reviewed-by: Laurent Pinchart Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c index a8083f4..f75e5f9 100644 --- a/drivers/gpu/drm/bridge/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/dw-hdmi.c @@ -1317,8 +1317,8 @@ static void dw_hdmi_enable_video_path(struct dw_hdmi *hdmi) hdmi_writeb(hdmi, clkdis, HDMI_MC_CLKDIS); } - /* Enable color space conversion if needed (for HDMI sinks only). */ - if (hdmi->sink_is_hdmi && is_color_space_conversion(hdmi)) + /* Enable color space conversion if needed */ + if (is_color_space_conversion(hdmi)) hdmi_writeb(hdmi, HDMI_MC_FLOWCTRL_FEED_THROUGH_OFF_CSC_IN_PATH, HDMI_MC_FLOWCTRL); else