From patchwork Wed Feb 22 11:47:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 9586691 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 006F96020B for ; Wed, 22 Feb 2017 11:47:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D1DF9288E2 for ; Wed, 22 Feb 2017 11:47:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C6A23288EA; Wed, 22 Feb 2017 11:47:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6DD04288E2 for ; Wed, 22 Feb 2017 11:47:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 50EEF6E7C5; Wed, 22 Feb 2017 11:47:51 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA4A76E7C5 for ; Wed, 22 Feb 2017 11:47:49 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OLR00D3IY3L5210@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 22 Feb 2017 11:47:45 +0000 (GMT) Received: from eusmges3.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170222114744eucas1p1e9aa69355634b66f13d2efad691ada36~lmYjMqxEC2826228262eucas1p1Z; Wed, 22 Feb 2017 11:47:44 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3.samsung.com (EUCPMTA) with SMTP id 72.7F.09557.06A7DA85; Wed, 22 Feb 2017 11:47:44 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170222114744eucas1p13466cdf79451c94754b6845d15bc5a42~lmYihkPmR2921129211eucas1p1W; Wed, 22 Feb 2017 11:47:44 +0000 (GMT) X-AuditID: cbfec7f2-f790f6d000002555-27-58ad7a60edd9 Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id FF.14.06687.5BA7DA85; Wed, 22 Feb 2017 11:49:09 +0000 (GMT) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OLR00FMDY3JAA40@eusync1.samsung.com>; Wed, 22 Feb 2017 11:47:43 +0000 (GMT) From: Andrzej Hajda To: Archit Taneja , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/bridge/sii8620: add missing error handling in probe Date: Wed, 22 Feb 2017 12:47:37 +0100 Message-id: <1487764057-23362-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsWy7djP87oJVWsjDF6skLW4te4cq0VTx1tW i40z1rNaXPn6ns1i7ZG77A6sHpf7epk87ncfZ/Lo27KKMYA5issmJTUnsyy1SN8ugSujc+4r 5oJZbBUtp8+yNjBOY+1i5OSQEDCRODizmw3CFpO4cG89kM3FISSwlFHi5MZnYAkhgc+MEt9u qsA0dPWsgipaxijx4edTRgjnP6PE1jdfwMayCWhK/N18E6xbRMBbYs7qPrAiZoEeRom51xuY QRLCAh4S+9adZAKxWQRUJZ4f3wrWwCvgLHHjPMhUkHVyEjfPdTKDNEsI7GCTWDTrEZDDAeTI Smw6wAxR4yKx/uxXJghbWOLV8S3sELaMRGfHQSaI3m5GiU/9J9ghnCmMEv8+zIDqtpY4fPwi 2NnMAnwSk7ZNh1rAK9HRJgRR4iHxqeMp1AJHiftP9rNAwiVW4lfvdeYJjNILGBlWMYqklhbn pqcWG+sVJ+YWl+al6yXn525iBEbh6X/HP+1g/HrC6hCjAAejEg/vA/c1EUKsiWXFlbmHGCU4 mJVEeAWS1kYI8aYkVlalFuXHF5XmpBYfYpTmYFES592z4Eq4kEB6YklqdmpqQWoRTJaJg1Oq gTGh6MR6Z9eZFXq1q7q99jAs6Nx47GZE+g6j10xK+5Ra9h8Kjs28UHTGivdgbYarw0Q7kfnc oW+l2b+zvjr0fnV+/664Swu57n/j/Pun0FLc6F+AvTnL7995KheF/ReqS7FGmHzd9vBgyBbp iVtWZR6akvDRkmn9p9Tyzoq3Hz33l6/n1M2SMlJiKc5INNRiLipOBABUn7xbvgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPLMWRmVeSWpSXmKPExsVy+t/xy7pbq9ZGGCy+IG1xa905Voumjres FhtnrGe1uPL1PZvF2iN32R1YPS739TJ53O8+zuTRt2UVYwBzlJtNRmpiSmqRQmpecn5KZl66 rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwyOue+Yi6YxVbRcvos awPjNNYuRk4OCQETia6eVWwQtpjEhXvrgWwuDiGBJYwSh04vZodwGpkkrn7sYwepYhPQlPi7 +SZYh4iAt8Sc1X2MIEXMAn2MEo1/IUYJC3hI7Ft3kgnEZhFQlXh+fCtYnFfAWeLG+aeMEOvk JG6e62SewMi9gJFhFaNIamlxbnpusaFecWJucWleul5yfu4mRmDgbTv2c/MOxksbgw8xCnAw KvHwPnBfEyHEmlhWXJl7iFGCg1lJhFcgaW2EEG9KYmVValF+fFFpTmrxIUZToOUTmaVEk/OB UZFXEm9oYmhuaWhkbGFhbmSkJM5b8uFKuJBAemJJanZqakFqEUwfEwenVAOj1dPd7GbvH+kn GvvwTbaL8Hk9oW3e4n/7N0WlrN22/bP4q3Mlpim+1poPTi6Ievg7Vq5UNZnx3tMbWbNa/E23 67JbZdVW5k7sPSLKGvP4EdveqQ2bpXiFPpcJJuulXLMWWhqUbfeY99O/LcFtchdbvlicudQt ZMwuadzNY604d+KjqRNyam2VWIozEg21mIuKEwEeAyk4UgIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170222114744eucas1p13466cdf79451c94754b6845d15bc5a42 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170222114744eucas1p13466cdf79451c94754b6845d15bc5a42 X-RootMTR: 20170222114744eucas1p13466cdf79451c94754b6845d15bc5a42 References: Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP devm_request_threaded_irq result should be checked for errors. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/bridge/sil-sii8620.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c index cdd0a9d..2d51a22 100644 --- a/drivers/gpu/drm/bridge/sil-sii8620.c +++ b/drivers/gpu/drm/bridge/sil-sii8620.c @@ -2184,6 +2184,10 @@ static int sii8620_probe(struct i2c_client *client, sii8620_irq_thread, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "sii8620", ctx); + if (ret < 0) { + dev_err(dev, "failed to install IRQ handler\n"); + return ret; + } ctx->gpio_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(ctx->gpio_reset)) {