diff mbox

drm/msm/hdmi: redefinitions of macros not required

Message ID 1489469158-29185-1-git-send-email-simhavcs@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vinay Simha B N March 14, 2017, 5:25 a.m. UTC 
4 macros already defined in hdmi.h,
which is not required to redefine in hdmi_audio.c

Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
---
 drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Vinay Simha B N March 22, 2017, 5:11 a.m. UTC | #1 
hi,

Could you please give some feedback or review comments for this patch

On 3/14/17, Vinay Simha BN <simhavcs@gmail.com> wrote:
> 4 macros already defined in hdmi.h,
> which is not required to redefine in hdmi_audio.c
>
> Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
> ---
>  drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> index a54d3bb..8177e85 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> @@ -18,13 +18,6 @@
>  #include <linux/hdmi.h>
>  #include "hdmi.h"
>
> -
> -/* Supported HDMI Audio channels */
> -#define MSM_HDMI_AUDIO_CHANNEL_2		0
> -#define MSM_HDMI_AUDIO_CHANNEL_4		1
> -#define MSM_HDMI_AUDIO_CHANNEL_6		2
> -#define MSM_HDMI_AUDIO_CHANNEL_8		3
> -
>  /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of
> channels: */
>  static int nchannels[] = { 2, 4, 6, 8 };
>
> --
> 2.7.4
>
>
Rob Clark March 22, 2017, 11:19 a.m. UTC | #2 
On Wed, Mar 22, 2017 at 1:11 AM, Vinay Simha B N <simhavcs@gmail.com> wrote:
> hi,
>
> Could you please give some feedback or review comments for this patch

looks good, I've pulled it into msm-next

BR,
-R

> On 3/14/17, Vinay Simha BN <simhavcs@gmail.com> wrote:
>> 4 macros already defined in hdmi.h,
>> which is not required to redefine in hdmi_audio.c
>>
>> Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
>> ---
>>  drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
>> b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
>> index a54d3bb..8177e85 100644
>> --- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
>> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
>> @@ -18,13 +18,6 @@
>>  #include <linux/hdmi.h>
>>  #include "hdmi.h"
>>
>> -
>> -/* Supported HDMI Audio channels */
>> -#define MSM_HDMI_AUDIO_CHANNEL_2             0
>> -#define MSM_HDMI_AUDIO_CHANNEL_4             1
>> -#define MSM_HDMI_AUDIO_CHANNEL_6             2
>> -#define MSM_HDMI_AUDIO_CHANNEL_8             3
>> -
>>  /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of
>> channels: */
>>  static int nchannels[] = { 2, 4, 6, 8 };
>>
>> --
>> 2.7.4
>>
>>
>
>
> --
> regards,
> vinaysimha
diff mbox

Patch

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
index a54d3bb..8177e85 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
@@ -18,13 +18,6 @@ 
 #include <linux/hdmi.h>
 #include "hdmi.h"
 
-
-/* Supported HDMI Audio channels */
-#define MSM_HDMI_AUDIO_CHANNEL_2		0
-#define MSM_HDMI_AUDIO_CHANNEL_4		1
-#define MSM_HDMI_AUDIO_CHANNEL_6		2
-#define MSM_HDMI_AUDIO_CHANNEL_8		3
-
 /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of channels: */
 static int nchannels[] = { 2, 4, 6, 8 };